diff mbox series

lib/mpi: Add the return value check of kcalloc()

Message ID 20211230070331.1046343-1-sunsetdzz@gmail.com
State Accepted
Commit dd827abe296fe4249b2f8c9b95f72f814ea8348c
Headers show
Series lib/mpi: Add the return value check of kcalloc() | expand

Commit Message

Zizhuang Deng Dec. 30, 2021, 7:03 a.m. UTC
Add the return value check of kcalloc() to avoid potential
NULL ptr dereference.

Signed-off-by: Zizhuang Deng <sunsetdzz@gmail.com>
---
 lib/mpi/mpi-mod.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

tianjia.zhang Dec. 30, 2021, 7:26 a.m. UTC | #1
On 12/30/21 3:03 PM, Zizhuang Deng wrote:
> Add the return value check of kcalloc() to avoid potential
> NULL ptr dereference.
> 
> Signed-off-by: Zizhuang Deng <sunsetdzz@gmail.com>
> ---

Reviewed-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>

Best regards,
Tianjia

>   lib/mpi/mpi-mod.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/lib/mpi/mpi-mod.c b/lib/mpi/mpi-mod.c
> index 47bc59edd4ff..54fcc01564d9 100644
> --- a/lib/mpi/mpi-mod.c
> +++ b/lib/mpi/mpi-mod.c
> @@ -40,6 +40,8 @@ mpi_barrett_t mpi_barrett_init(MPI m, int copy)
>   
>   	mpi_normalize(m);
>   	ctx = kcalloc(1, sizeof(*ctx), GFP_KERNEL);
> +	if (!ctx)
> +		return NULL;
>   
>   	if (copy) {
>   		ctx->m = mpi_copy(m);
diff mbox series

Patch

diff --git a/lib/mpi/mpi-mod.c b/lib/mpi/mpi-mod.c
index 47bc59edd4ff..54fcc01564d9 100644
--- a/lib/mpi/mpi-mod.c
+++ b/lib/mpi/mpi-mod.c
@@ -40,6 +40,8 @@  mpi_barrett_t mpi_barrett_init(MPI m, int copy)
 
 	mpi_normalize(m);
 	ctx = kcalloc(1, sizeof(*ctx), GFP_KERNEL);
+	if (!ctx)
+		return NULL;
 
 	if (copy) {
 		ctx->m = mpi_copy(m);