| Message ID | 20211228163930.35524-2-krzysztof.kozlowski@canonical.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | leds/power/regulator/mfd: dt-bindings: maxim,max77693: convert to dtschema | expand |
On Tue, 28 Dec 2021 17:39:27 +0100, Krzysztof Kozlowski wrote: > Convert the LEDs bindings of Maxim MAX77693 MUIC to DT schema format. > The existing bindings were defined in ../bindings/mfd/max77693.txt. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > .../bindings/leds/maxim,max77693.yaml | 105 ++++++++++++++++++ > 1 file changed, 105 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/maxim,max77693.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/common.example.dt.yaml: led-controller@0: 'reg' does not match any of the regexes: '^([a-z]+-)?led[01]?$', 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/maxim,max77693.yaml doc reference errors (make refcheckdocs): Documentation/devicetree/bindings/leds/maxim,max77693.yaml: Documentation/devicetree/bindings/mfd/maxim,max77693.yaml See https://patchwork.ozlabs.org/patch/1573762 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 29/12/2021 18:34, Rob Herring wrote: > On Tue, 28 Dec 2021 17:39:27 +0100, Krzysztof Kozlowski wrote: >> Convert the LEDs bindings of Maxim MAX77693 MUIC to DT schema format. >> The existing bindings were defined in ../bindings/mfd/max77693.txt. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >> --- >> .../bindings/leds/maxim,max77693.yaml | 105 ++++++++++++++++++ >> 1 file changed, 105 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/maxim,max77693.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/common.example.dt.yaml: led-controller@0: 'reg' does not match any of the regexes: '^([a-z]+-)?led[01]?$', 'pinctrl-[0-9]+' > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/maxim,max77693.yaml > > doc reference errors (make refcheckdocs): > Documentation/devicetree/bindings/leds/maxim,max77693.yaml: Documentation/devicetree/bindings/mfd/maxim,max77693.yaml > > See https://patchwork.ozlabs.org/patch/1573762 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > I updated my yamllint and dtschema, run with DT_CHECKER_FLAGS=-m but still cannot reproduce it. Probably because I based on linux-next, so maybe this was a fixed issue in leds/common.yaml. Best regards, Krzysztof
On Thu, Dec 30, 2021 at 11:53:37AM +0100, Krzysztof Kozlowski wrote: > On 29/12/2021 18:34, Rob Herring wrote: > > On Tue, 28 Dec 2021 17:39:27 +0100, Krzysztof Kozlowski wrote: > >> Convert the LEDs bindings of Maxim MAX77693 MUIC to DT schema format. > >> The existing bindings were defined in ../bindings/mfd/max77693.txt. > >> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > >> --- > >> .../bindings/leds/maxim,max77693.yaml | 105 ++++++++++++++++++ > >> 1 file changed, 105 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/leds/maxim,max77693.yaml > >> > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/common.example.dt.yaml: led-controller@0: 'reg' does not match any of the regexes: '^([a-z]+-)?led[01]?$', 'pinctrl-[0-9]+' > > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/maxim,max77693.yaml > > > > doc reference errors (make refcheckdocs): > > Documentation/devicetree/bindings/leds/maxim,max77693.yaml: Documentation/devicetree/bindings/mfd/maxim,max77693.yaml > > > > See https://patchwork.ozlabs.org/patch/1573762 > > > > This check can fail if there are any dependencies. The base for a patch > > series is generally the most recent rc1. > > > > I updated my yamllint and dtschema, run with DT_CHECKER_FLAGS=-m but > still cannot reproduce it. Probably because I based on linux-next, so > maybe this was a fixed issue in leds/common.yaml. Are you setting DT_SCHEMA_FILES, because the error is in common.yaml but caused by this schema. Clearly, 'reg' is not defined here. And there is no change to common.yaml in next. Rob
On 04/01/2022 16:09, Rob Herring wrote: > On Thu, Dec 30, 2021 at 11:53:37AM +0100, Krzysztof Kozlowski wrote: >> On 29/12/2021 18:34, Rob Herring wrote: >>> On Tue, 28 Dec 2021 17:39:27 +0100, Krzysztof Kozlowski wrote: >>>> Convert the LEDs bindings of Maxim MAX77693 MUIC to DT schema format. >>>> The existing bindings were defined in ../bindings/mfd/max77693.txt. >>>> >>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >>>> --- >>>> .../bindings/leds/maxim,max77693.yaml | 105 ++++++++++++++++++ >>>> 1 file changed, 105 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/leds/maxim,max77693.yaml >>>> >>> >>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >>> on your patch (DT_CHECKER_FLAGS is new in v5.13): >>> >>> yamllint warnings/errors: >>> >>> dtschema/dtc warnings/errors: >>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/common.example.dt.yaml: led-controller@0: 'reg' does not match any of the regexes: '^([a-z]+-)?led[01]?$', 'pinctrl-[0-9]+' >>> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/maxim,max77693.yaml >>> >>> doc reference errors (make refcheckdocs): >>> Documentation/devicetree/bindings/leds/maxim,max77693.yaml: Documentation/devicetree/bindings/mfd/maxim,max77693.yaml >>> >>> See https://patchwork.ozlabs.org/patch/1573762 >>> >>> This check can fail if there are any dependencies. The base for a patch >>> series is generally the most recent rc1. >>> >> >> I updated my yamllint and dtschema, run with DT_CHECKER_FLAGS=-m but >> still cannot reproduce it. Probably because I based on linux-next, so >> maybe this was a fixed issue in leds/common.yaml. > > Are you setting DT_SCHEMA_FILES, because the error is in > common.yaml but caused by this schema. > > Clearly, 'reg' is not defined here. And there is no change to > common.yaml in next. > Indeed, I'll fix this up. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/leds/maxim,max77693.yaml b/Documentation/devicetree/bindings/leds/maxim,max77693.yaml new file mode 100644 index 000000000000..86a0005cf156 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/maxim,max77693.yaml @@ -0,0 +1,105 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/maxim,max77693.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim MAX77693 MicroUSB and Companion Power Management IC LEDs + +maintainers: + - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> + +description: | + This is a part of device tree bindings for Maxim MAX77693 MicroUSB Integrated + Circuit (MUIC). + + There are two LED outputs available - FLED1 and FLED2. Each of them can + control a separate LED or they can be connected together to double the + maximum current for a single connected LED. One LED is represented by one + child node. + + See also Documentation/devicetree/bindings/mfd/maxim,max77693.yaml for + additional information and example. + +properties: + compatible: + const: maxim,max77693-led + + maxim,boost-mode: + description: + In boost mode the device can produce up to 1.2A of total current on both + outputs. The maximum current on each output is reduced to 625mA then. If + not enabled explicitly, boost setting defaults to LEDS_BOOST_FIXED in + case both current sources are used. + See LEDS_BOOST_* in include/dt-bindings/leds/common.h. + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [0, 1, 2] + + maxim,boost-mvout: + description: | + Output voltage of the boost module in millivolts. + Valid values: 3300 - 5500, step by 25 (rounded down) + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 3300 + maximum: 5500 + default: 3300 + + maxim,mvsys-min: + description: | + Low input voltage level in millivolts. Flash is not fired if chip + estimates that system voltage could drop below this level due to flash + power consumption. + Valid values: 2400 - 3400, step by 33 (rounded down) + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 2400 + maximum: 3400 + default: 2400 + +patternProperties: + "^([a-z]+-)?led[01]?$": + type: object + $ref: common.yaml# + unevaluatedProperties: false + + properties: + led-sources: + allOf: + - minItems: 1 + maxItems: 2 + items: + minimum: 0 + maximum: 1 + + led-max-microamp: + description: | + Valid values for a LED connected to one FLED output: + 15625 - 250000, step by 15625 (rounded down) + Valid values for a LED connected to both FLED outputs: + 15625 - 500000, step by 15625 (rounded down) + + flash-max-microamp: + description: | + Valid values for a single LED connected to one FLED output + (boost mode must be turned off): + 15625 - 1000000, step by 15625 (rounded down) + Valid values for a single LED connected to both FLED outputs: + 15625 - 1250000, step by 15625 (rounded down) + Valid values for two LEDs case: + 15625 - 625000, step by 15625 (rounded down) + + flash-max-timeout-us: + description: | + Valid values: 62500 - 1000000, step by 62500 (rounded down) + minimum: 62500 + maximum: 1000000 + + required: + - flash-max-microamp + - flash-max-timeout-us + - led-max-microamp + - led-sources + +required: + - compatible + +additionalProperties: false
Convert the LEDs bindings of Maxim MAX77693 MUIC to DT schema format. The existing bindings were defined in ../bindings/mfd/max77693.txt. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- .../bindings/leds/maxim,max77693.yaml | 105 ++++++++++++++++++ 1 file changed, 105 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/maxim,max77693.yaml