| Message ID | f642ef4d-6027-eb2e-0257-1c4f13911aed@omp.ru |
|---|---|
| State | New |
| Headers | show |
| Series | mmc: au1xmmc: propagate errors from platform_get_irq() | expand |
On Thu, Dec 23, 2021 at 7:45 PM Sergey Shtylyov <s.shtylyov@omp.ru> wrote: > > The driver overrides the error codes returned by platform_get_irq() to > -ENODEV. Switch to propagating the error codes upstream. > > Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> Sure, why not. Tested-by: Manuel Lauss <manuel.lauss@gmail.com Manuel
On Thu, 23 Dec 2021 at 19:45, Sergey Shtylyov <s.shtylyov@omp.ru> wrote: > > The driver overrides the error codes returned by platform_get_irq() to > -ENODEV. Switch to propagating the error codes upstream. > > Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> Applied for next, thanks! Kind regards Uffe > > --- > This patch is against the 'next' branch of Ulf Hansson's 'mmc.git' repo. > > drivers/mmc/host/au1xmmc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > Index: linux/drivers/mmc/host/au1xmmc.c > =================================================================== > --- linux.orig/drivers/mmc/host/au1xmmc.c > +++ linux/drivers/mmc/host/au1xmmc.c > @@ -969,8 +969,10 @@ static int au1xmmc_probe(struct platform > } > > host->irq = platform_get_irq(pdev, 0); > - if (host->irq < 0) > + if (host->irq < 0) { > + ret = host->irq; > goto out3; > + } > > mmc->ops = &au1xmmc_ops; >
Index: linux/drivers/mmc/host/au1xmmc.c =================================================================== --- linux.orig/drivers/mmc/host/au1xmmc.c +++ linux/drivers/mmc/host/au1xmmc.c @@ -969,8 +969,10 @@ static int au1xmmc_probe(struct platform } host->irq = platform_get_irq(pdev, 0); - if (host->irq < 0) + if (host->irq < 0) { + ret = host->irq; goto out3; + } mmc->ops = &au1xmmc_ops;
The driver overrides the error codes returned by platform_get_irq() to -ENODEV. Switch to propagating the error codes upstream. Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> --- This patch is against the 'next' branch of Ulf Hansson's 'mmc.git' repo. drivers/mmc/host/au1xmmc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)