| Message ID | 20211220180334.3990693-1-davidm@egauge.net |
|---|---|
| Headers | show |
| Series | wilc1000: Add reset/enable GPIO support to SPI driver | expand |
On Tue, 2021-12-21 at 11:12 -0400, Rob Herring wrote: > On Mon, 20 Dec 2021 18:03:38 +0000, David Mosberger-Tang wrote: > > Add documentation for the ENABLE and RESET GPIOs that may be needed > > by > > wilc1000-spi. > > > > Signed-off-by: David Mosberger-Tang <davidm@egauge.net> > > --- > > .../net/wireless/microchip,wilc1000.yaml | 19 > > +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > Please add Acked-by/Reviewed-by tags when posting new versions. Ah, sorry about that. > However, > there's no need to repost patches *only* to add the tags. The > upstream > maintainer will do that for acks received on the version they apply. > > If a tag was not added on purpose, please state why and what changed. Not on purpose. I just didn't know how this is handled. Thanks and best regards, --david
David Mosberger-Tang <davidm@egauge.net> writes: > On Tue, 2021-12-21 at 11:12 -0400, Rob Herring wrote: >> On Mon, 20 Dec 2021 18:03:38 +0000, David Mosberger-Tang wrote: >> > Add documentation for the ENABLE and RESET GPIOs that may be needed >> > by >> > wilc1000-spi. >> > >> > Signed-off-by: David Mosberger-Tang <davidm@egauge.net> >> > --- >> > .../net/wireless/microchip,wilc1000.yaml | 19 >> > +++++++++++++++++++ >> > 1 file changed, 19 insertions(+) >> > >> >> Please add Acked-by/Reviewed-by tags when posting new versions. > > Ah, sorry about that. > >> However, >> there's no need to repost patches *only* to add the tags. The >> upstream >> maintainer will do that for acks received on the version they apply. >> >> If a tag was not added on purpose, please state why and what changed. > > Not on purpose. I just didn't know how this is handled. No worries, we have a lot of special rules :) I'll add Rob's tag from v5 when I commit the patch. Actually, I'm lazy and patchwork can pick it up automatically: Reviewed-by: Rob Herring <robh@kernel.org>
v6: - Convert line comments to block comments. v5: - Fix a dt_binding_check error by including <dt-bindings/gpio/gpio.h> in microchip,wilc1000.yaml. v4: - Simplify wilc_wlan_power() by letting gpiod_set_value() handle NULL gpios. v3: - Fix to include correct header file. - Rename wilc_set_enable() to wilc_wlan_power(). - Use devm_gpiod_get{,_optional}() instead of of_get_named_gpio() - Parse GPIO pins once at probe time. v2: - Split documentation update and driver changes into seprate patches. David Mosberger-Tang (2): wilc1000: Add reset/enable GPIO support to SPI driver wilc1000: Document enable-gpios and reset-gpios properties .../net/wireless/microchip,wilc1000.yaml | 19 ++++++ drivers/net/wireless/microchip/wilc1000/spi.c | 62 ++++++++++++++++++- .../net/wireless/microchip/wilc1000/wlan.c | 2 +- 3 files changed, 79 insertions(+), 4 deletions(-)