| Message ID | 20211206153124.427102-2-virag.david003@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Initial Samsung Galaxy A8 (2018) support | expand |
On Mon, 06 Dec 2021 16:31:15 +0100, David Virag wrote: > Just like on Exynos850, the clock controller driver is designed to have > separate instances for each particular CMU, so clock IDs start from 1 > for each CMU in this bindings header too. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > Signed-off-by: David Virag <virag.david003@gmail.com> > --- > Changes in v2: > - Added R-b tag by Krzysztof Kozlowski > > Changes in v3: > - Nothing > > Changes in v4: > - Nothing > > include/dt-bindings/clock/exynos7885.h | 115 +++++++++++++++++++++++++ > 1 file changed, 115 insertions(+) > create mode 100644 include/dt-bindings/clock/exynos7885.h > Acked-by: Rob Herring <robh@kernel.org>
On 06/12/2021 16:31, David Virag wrote: > Just like on Exynos850, the clock controller driver is designed to have > separate instances for each particular CMU, so clock IDs start from 1 > for each CMU in this bindings header too. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > Signed-off-by: David Virag <virag.david003@gmail.com> > --- > Changes in v2: > - Added R-b tag by Krzysztof Kozlowski > > Changes in v3: > - Nothing > > Changes in v4: > - Nothing > > include/dt-bindings/clock/exynos7885.h | 115 +++++++++++++++++++++++++ > 1 file changed, 115 insertions(+) > create mode 100644 include/dt-bindings/clock/exynos7885.h > Hi Sylwester, The DTS/DTSI patch (7/7) depends on this one, just like the clock driver. Since some time Arnd and Olof prefer not to have external trees going into the arm-soc, even if this is only the header change. They recommend one of: 1. to hard-code the numbers in DTS and replace numbers->macros later, 2. merge headers to arm-soc tree with DTS and provide the header to an external (e.g. clk) tree, 3. wait with merging DTSI till headers reach mainline. I propose that I take the clock headers, put on separate branch and provide them to you as stable tag. You can base clk driver changes on top of it. Are you okay with this? Best regards, Krzysztof
On 06.12.2021 16:31, David Virag wrote: > Just like on Exynos850, the clock controller driver is designed to have > separate instances for each particular CMU, so clock IDs start from 1 > for each CMU in this bindings header too. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > Signed-off-by: David Virag <virag.david003@gmail.com> Applied patches 1,2,4,5,6, thanks.
On 12/12/2021 19:39, Krzysztof Kozlowski wrote: > On 06/12/2021 16:31, David Virag wrote: >> Just like on Exynos850, the clock controller driver is designed to have >> separate instances for each particular CMU, so clock IDs start from 1 >> for each CMU in this bindings header too. >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >> Signed-off-by: David Virag <virag.david003@gmail.com> >> --- >> Changes in v2: >> - Added R-b tag by Krzysztof Kozlowski >> >> Changes in v3: >> - Nothing >> >> Changes in v4: >> - Nothing >> >> include/dt-bindings/clock/exynos7885.h | 115 +++++++++++++++++++++++++ >> 1 file changed, 115 insertions(+) >> create mode 100644 include/dt-bindings/clock/exynos7885.h >> > > Hi Sylwester, > > The DTS/DTSI patch (7/7) depends on this one, just like the clock driver. > > Since some time Arnd and Olof prefer not to have external trees going > into the arm-soc, even if this is only the header change. They recommend > one of: > 1. to hard-code the numbers in DTS and replace numbers->macros later, > 2. merge headers to arm-soc tree with DTS and provide the header to an > external (e.g. clk) tree, > 3. wait with merging DTSI till headers reach mainline. > > I propose that I take the clock headers, put on separate branch and > provide them to you as stable tag. You can base clk driver changes on > top of it. > > Are you okay with this? Hi Sylwester, I see you applied the patches, so I understand we are not going with this proposal. David, Your DTSI and DTS will have to either wait for next cycle or please resend with clock macros replaced with numbers + TODO note. Best regards, Krzysztof
diff --git a/include/dt-bindings/clock/exynos7885.h b/include/dt-bindings/clock/exynos7885.h new file mode 100644 index 000000000000..1f8701691d62 --- /dev/null +++ b/include/dt-bindings/clock/exynos7885.h @@ -0,0 +1,115 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* + * Copyright (c) 2021 Dávid Virág + * + * Device Tree binding constants for Exynos7885 clock controller. + */ + +#ifndef _DT_BINDINGS_CLOCK_EXYNOS_7885_H +#define _DT_BINDINGS_CLOCK_EXYNOS_7885_H + +/* CMU_TOP */ +#define CLK_FOUT_SHARED0_PLL 1 +#define CLK_FOUT_SHARED1_PLL 2 +#define CLK_DOUT_SHARED0_DIV2 3 +#define CLK_DOUT_SHARED0_DIV3 4 +#define CLK_DOUT_SHARED0_DIV4 5 +#define CLK_DOUT_SHARED0_DIV5 6 +#define CLK_DOUT_SHARED1_DIV2 7 +#define CLK_DOUT_SHARED1_DIV3 8 +#define CLK_DOUT_SHARED1_DIV4 9 +#define CLK_MOUT_CORE_BUS 10 +#define CLK_MOUT_CORE_CCI 11 +#define CLK_MOUT_CORE_G3D 12 +#define CLK_DOUT_CORE_BUS 13 +#define CLK_DOUT_CORE_CCI 14 +#define CLK_DOUT_CORE_G3D 15 +#define CLK_GOUT_CORE_BUS 16 +#define CLK_GOUT_CORE_CCI 17 +#define CLK_GOUT_CORE_G3D 18 +#define CLK_MOUT_PERI_BUS 19 +#define CLK_MOUT_PERI_SPI0 20 +#define CLK_MOUT_PERI_SPI1 21 +#define CLK_MOUT_PERI_UART0 22 +#define CLK_MOUT_PERI_UART1 23 +#define CLK_MOUT_PERI_UART2 24 +#define CLK_MOUT_PERI_USI0 25 +#define CLK_MOUT_PERI_USI1 26 +#define CLK_MOUT_PERI_USI2 27 +#define CLK_DOUT_PERI_BUS 28 +#define CLK_DOUT_PERI_SPI0 29 +#define CLK_DOUT_PERI_SPI1 30 +#define CLK_DOUT_PERI_UART0 31 +#define CLK_DOUT_PERI_UART1 32 +#define CLK_DOUT_PERI_UART2 33 +#define CLK_DOUT_PERI_USI0 34 +#define CLK_DOUT_PERI_USI1 35 +#define CLK_DOUT_PERI_USI2 36 +#define CLK_GOUT_PERI_BUS 37 +#define CLK_GOUT_PERI_SPI0 38 +#define CLK_GOUT_PERI_SPI1 39 +#define CLK_GOUT_PERI_UART0 40 +#define CLK_GOUT_PERI_UART1 41 +#define CLK_GOUT_PERI_UART2 42 +#define CLK_GOUT_PERI_USI0 43 +#define CLK_GOUT_PERI_USI1 44 +#define CLK_GOUT_PERI_USI2 45 +#define TOP_NR_CLK 46 + +/* CMU_CORE */ +#define CLK_MOUT_CORE_BUS_USER 1 +#define CLK_MOUT_CORE_CCI_USER 2 +#define CLK_MOUT_CORE_G3D_USER 3 +#define CLK_MOUT_CORE_GIC 4 +#define CLK_DOUT_CORE_BUSP 5 +#define CLK_GOUT_CCI_ACLK 6 +#define CLK_GOUT_GIC400_CLK 7 +#define CORE_NR_CLK 8 + +/* CMU_PERI */ +#define CLK_MOUT_PERI_BUS_USER 1 +#define CLK_MOUT_PERI_SPI0_USER 2 +#define CLK_MOUT_PERI_SPI1_USER 3 +#define CLK_MOUT_PERI_UART0_USER 4 +#define CLK_MOUT_PERI_UART1_USER 5 +#define CLK_MOUT_PERI_UART2_USER 6 +#define CLK_MOUT_PERI_USI0_USER 7 +#define CLK_MOUT_PERI_USI1_USER 8 +#define CLK_MOUT_PERI_USI2_USER 9 +#define CLK_GOUT_GPIO_TOP_PCLK 10 +#define CLK_GOUT_HSI2C0_PCLK 11 +#define CLK_GOUT_HSI2C1_PCLK 12 +#define CLK_GOUT_HSI2C2_PCLK 13 +#define CLK_GOUT_HSI2C3_PCLK 14 +#define CLK_GOUT_I2C0_PCLK 15 +#define CLK_GOUT_I2C1_PCLK 16 +#define CLK_GOUT_I2C2_PCLK 17 +#define CLK_GOUT_I2C3_PCLK 18 +#define CLK_GOUT_I2C4_PCLK 19 +#define CLK_GOUT_I2C5_PCLK 20 +#define CLK_GOUT_I2C6_PCLK 21 +#define CLK_GOUT_I2C7_PCLK 22 +#define CLK_GOUT_PWM_MOTOR_PCLK 23 +#define CLK_GOUT_SPI0_PCLK 24 +#define CLK_GOUT_SPI0_EXT_CLK 25 +#define CLK_GOUT_SPI1_PCLK 26 +#define CLK_GOUT_SPI1_EXT_CLK 27 +#define CLK_GOUT_UART0_EXT_UCLK 28 +#define CLK_GOUT_UART0_PCLK 29 +#define CLK_GOUT_UART1_EXT_UCLK 30 +#define CLK_GOUT_UART1_PCLK 31 +#define CLK_GOUT_UART2_EXT_UCLK 32 +#define CLK_GOUT_UART2_PCLK 33 +#define CLK_GOUT_USI0_PCLK 34 +#define CLK_GOUT_USI0_SCLK 35 +#define CLK_GOUT_USI1_PCLK 36 +#define CLK_GOUT_USI1_SCLK 37 +#define CLK_GOUT_USI2_PCLK 38 +#define CLK_GOUT_USI2_SCLK 39 +#define CLK_GOUT_MCT_PCLK 40 +#define CLK_GOUT_SYSREG_PERI_PCLK 41 +#define CLK_GOUT_WDT0_PCLK 42 +#define CLK_GOUT_WDT1_PCLK 43 +#define PERI_NR_CLK 44 + +#endif /* _DT_BINDINGS_CLOCK_EXYNOS_7885_H */