| Message ID | C3B4248E-2870-4572-9A11-45AAA7019E9A@icloud.com |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: dts: BCM5301X: Add USB GPIO and missing LEDs on Netgear R6300v2 | expand |
Hi Lisa,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on v5.16-rc5 next-20211215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Lisa-Hill/ARM-dts-BCM5301X-Add-USB-GPIO-and-missing-LEDs-on-Netgear-R6300v2/20211211-165513
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce: make ARCH=arm dtbs_check
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
dtcheck warnings: (new ones prefixed by >>)
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml: usb@22000: '#address-cells', '#size-cells', '#usb-cells', 'port@1', 'port@2' do not match any of the regexes: 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/usb/generic-ohci.yaml
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml: usb@23000: port@1: 'compatible' is a required property
From schema: Documentation/devicetree/bindings/usb/generic-xhci.yaml
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml: usb@23000: Unevaluated properties are not allowed ('#usb-cells', 'phys', 'phy-names', '#address-cells', '#size-cells', 'port@1' were unexpected)
From schema: Documentation/devicetree/bindings/usb/generic-xhci.yaml
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml: cru@100: $nodename:0: 'cru@100' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
From schema: /usr/local/lib/python3.9/dist-packages/dtschema/schemas/simple-bus.yaml
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml:0:0: /nand-controller@18028000/nand@0/partitions: failed to match any schema with compatible: ['brcm,bcm947xx-cfe-partitions']
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml:0:0: /spi@18029200/flash@0/partitions: failed to match any schema with compatible: ['brcm,bcm947xx-cfe-partitions']
>> arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml: leds: 'logo', 'power-amber', 'power-green', 'usb', 'wan-amber', 'wan-green', 'wireless' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
diff --git a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts index 4c60eda296d973..46e77973b12df0 100644 --- a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts +++ b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts @@ -34,20 +34,32 @@ linux,default-trigger = "default-on"; }; - power0 { + power-green { label = "bcm53xx:green:power"; gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>; + linux,default-trigger = "default-on"; }; - power1 { + power-amber { label = "bcm53xx:amber:power"; gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>; - linux,default-trigger = "default-on"; }; usb { label = "bcm53xx:blue:usb"; gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>; + trigger-sources = <&ohci_port1>, <&ehci_port1>, <&xhci_port1>; + linux,default-trigger = "usbport"; + }; + + wan-green { + label = "bcm53xx:green:wan"; + gpios = <&chipcommon 10 GPIO_ACTIVE_LOW>; + }; + + wan-amber { + label = "bcm53xx:amber:wan"; + gpios = <&chipcommon 10 GPIO_ACTIVE_HIGH>; }; wireless { @@ -79,6 +91,14 @@ }; }; +&usb2 { + vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>; +}; + +&usb3 { + vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>; +}; + &spi_nor { status = "okay"; };
Set GPIO controlling power for both USB ports properly, add missing WAN LEDs and specify USB ports for the USB LED on Netgear R6300v2. Signed-off-by: Lisa Hill <f11o1iomh3dmt141n@icloud.com> --- .../arm/boot/dts/bcm4708-netgear-r6300-v2.dts | 26 ++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-)