| Message ID | 20211201000215.1134831-1-luiz.dentz@gmail.com |
|---|---|
| Headers | show |
| Series | Rework parsing of HCI events | expand |
On Tue, 30 Nov 2021 18:16:02 -0800 Luiz Augusto von Dentz wrote: > > It doesn't take a data pointer, so not really analogous to > > skb_put_data() and friends which come to mind. But I have > > no better naming suggestions. You will need to respin, tho, > > if you want us to apply these directly, the patches as posted > > don't apply to either netdev tree. > > I cross posted it to net-dev just in case you guys had some strong > opinions on introducing such a function, Someone else still may, I don't :) > it was in fact suggested by Dan but I also didn't find a better name > so I went with it, if you guys prefer we can merge it in > bluetooth-next first as usual. Going via bluetooth-next sounds good!
Hi Jakub, >>> It doesn't take a data pointer, so not really analogous to >>> skb_put_data() and friends which come to mind. But I have >>> no better naming suggestions. You will need to respin, tho, >>> if you want us to apply these directly, the patches as posted >>> don't apply to either netdev tree. >> >> I cross posted it to net-dev just in case you guys had some strong >> opinions on introducing such a function, > > Someone else still may, I don't :) > >> it was in fact suggested by Dan but I also didn't find a better name >> so I went with it, if you guys prefer we can merge it in >> bluetooth-next first as usual. > > Going via bluetooth-next sounds good! if you are ok with this going via bluetooth-next, then I need some sort of ACK from you or Dave. Regards Marcel
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> This reworks the parsing of HCI events using skb_pull_data to check event length, in addition to that it does introduce function tables to handle events, LE subevents, Command Complete and Command Status which simplify the callback by adding a common code that uses skb_pull_data when parsing such events. Luiz Augusto von Dentz (15): skbuff: introduce skb_pull_data Bluetooth: HCI: Use skb_pull_data to parse BR/EDR events Bluetooth: HCI: Use skb_pull_data to parse Command Complete event Bluetooth: HCI: Use skb_pull_data to parse Number of Complete Packets event Bluetooth: HCI: Use skb_pull_data to parse Inquiry Result event Bluetooth: HCI: Use skb_pull_data to parse Inquiry Result with RSSI event Bluetooth: HCI: Use skb_pull_data to parse Extended Inquiry Result event Bluetooth: HCI: Use skb_pull_data to parse LE Metaevents Bluetooth: HCI: Use skb_pull_data to parse LE Advertising Report event Bluetooth: HCI: Use skb_pull_data to parse LE Ext Advertising Report event Bluetooth: HCI: Use skb_pull_data to parse LE Direct Advertising Report event Bluetooth: hci_event: Use of a function table to handle HCI events Bluetooth: hci_event: Use of a function table to handle LE subevents Bluetooth: hci_event: Use of a function table to handle Command Complete Bluetooth: hci_event: Use of a function table to handle Command Status include/linux/skbuff.h | 2 + include/net/bluetooth/hci.h | 59 +- net/bluetooth/hci_event.c | 3031 +++++++++++++++++++---------------- net/bluetooth/msft.c | 2 +- net/bluetooth/msft.h | 2 +- net/core/skbuff.c | 23 + 6 files changed, 1689 insertions(+), 1430 deletions(-)