Message ID | 1638403212-29265-1-git-send-email-quic_fenglinw@quicinc.com |
---|---|
Headers | show |
Series | A bunch of fix and optimization patches in spmi-pmic-arb.c | expand |
On 02/12/2021 00:00, Fenglin Wu wrote: > Call handle_bad_irq() for handling spurious interrupt. While at it, > add an error print in cleanup_irq() for any spurious interrupt which > is fired but not having interrupt handler registered. Being excruciatingly pedantic, I'd suggest breaking this up into two patches, one for the ratelimit one for the logical change to the irq handling flow. > Signed-off-by: Abhijeet Dharmapurikar<adharmap@codeaurora.org> > Signed-off-by: David Collins<collinsd@codeaurora.org> > Signed-off-by: Fenglin Wu<quic_fenglinw@quicinc.com> > --- > drivers/spmi/spmi-pmic-arb.c | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c > index bbbd311..da629cc 100644 > --- a/drivers/spmi/spmi-pmic-arb.c > +++ b/drivers/spmi/spmi-pmic-arb.c > @@ -489,6 +489,8 @@ static void cleanup_irq(struct spmi_pmic_arb *pmic_arb, u16 apid, int id) > u8 per = ppid & 0xFF; > u8 irq_mask = BIT(id); > > + dev_err_ratelimited(&pmic_arb->spmic->dev, "%s apid=%d sid=0x%x per=0x%x irq=%d\n", > + __func__, apid, sid, per, id); > writel_relaxed(irq_mask, pmic_arb->ver_ops->irq_clear(pmic_arb, apid)); > > if (pmic_arb_write_cmd(pmic_arb->spmic, SPMI_CMD_EXT_WRITEL, sid, > @@ -502,10 +504,10 @@ static void cleanup_irq(struct spmi_pmic_arb *pmic_arb, u16 apid, int id) > irq_mask, ppid); > } > > -static void periph_interrupt(struct spmi_pmic_arb *pmic_arb, u16 apid) > +static int periph_interrupt(struct spmi_pmic_arb *pmic_arb, u16 apid) > { > unsigned int irq; > - u32 status, id; > + u32 status, id, handled = 0; If handled were an int > u8 sid = (pmic_arb->apid_data[apid].ppid >> 8) & 0xF; > u8 per = pmic_arb->apid_data[apid].ppid & 0xFF; > > @@ -520,7 +522,10 @@ static void periph_interrupt(struct spmi_pmic_arb *pmic_arb, u16 apid) > continue; > } > generic_handle_irq(irq); > + handled++; > } > + > + return (handled) ? 0 : -EINVAL; > } you could "return handled;" and then have if (periph_interrupt(pmic_arb, apid)) handled++; later on Its not important I suppose but please do at least break this up into two separate patches. --- bod
On 2021/12/2 10:39, Bryan O'Donoghue wrote: > On 02/12/2021 00:00, Fenglin Wu wrote: >> Call handle_bad_irq() for handling spurious interrupt. While at it, >> add an error print in cleanup_irq() for any spurious interrupt which >> is fired but not having interrupt handler registered. > > Being excruciatingly pedantic, I'd suggest breaking this up into two > patches, one for the ratelimit one for the logical change to the irq > handling flow. > The original patch actually only prints a message for any interrupt that's fired but not registered, and it got reviewed and commented to add logic to handle spurious interrupt like this.I might have misunderstood the comments so I combined them together, I agreed theyare not very related and I can separate them and send them again. Thanks. >> Signed-off-by: Abhijeet Dharmapurikar<adharmap@codeaurora.org> >> Signed-off-by: David Collins<collinsd@codeaurora.org> >> Signed-off-by: Fenglin Wu<quic_fenglinw@quicinc.com> >> --- >> drivers/spmi/spmi-pmic-arb.c | 17 +++++++++++++---- >> 1 file changed, 13 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c >> index bbbd311..da629cc 100644 >> --- a/drivers/spmi/spmi-pmic-arb.c >> +++ b/drivers/spmi/spmi-pmic-arb.c >> @@ -489,6 +489,8 @@ static void cleanup_irq(struct spmi_pmic_arb >> *pmic_arb, u16 apid, int id) >> u8 per = ppid & 0xFF; >> u8 irq_mask = BIT(id); >> + dev_err_ratelimited(&pmic_arb->spmic->dev, "%s apid=%d >> sid=0x%x per=0x%x irq=%d\n", >> + __func__, apid, sid, per, id); >> writel_relaxed(irq_mask, pmic_arb->ver_ops->irq_clear(pmic_arb, >> apid)); >> if (pmic_arb_write_cmd(pmic_arb->spmic, SPMI_CMD_EXT_WRITEL, >> sid, >> @@ -502,10 +504,10 @@ static void cleanup_irq(struct spmi_pmic_arb >> *pmic_arb, u16 apid, int id) >> irq_mask, ppid); >> } >> -static void periph_interrupt(struct spmi_pmic_arb *pmic_arb, u16 >> apid) >> +static int periph_interrupt(struct spmi_pmic_arb *pmic_arb, u16 apid) >> { >> unsigned int irq; >> - u32 status, id; >> + u32 status, id, handled = 0; > > If handled were an int > >> u8 sid = (pmic_arb->apid_data[apid].ppid >> 8) & 0xF; >> u8 per = pmic_arb->apid_data[apid].ppid & 0xFF; >> @@ -520,7 +522,10 @@ static void periph_interrupt(struct >> spmi_pmic_arb *pmic_arb, u16 apid) >> continue; >> } >> generic_handle_irq(irq); >> + handled++; >> } >> + >> + return (handled) ? 0 : -EINVAL; >> } > > you could "return handled;" and then have > > if (periph_interrupt(pmic_arb, apid)) > handled++; > > later on > > Its not important I suppose but please do at least break this up into > two separate patches. > Got it, will update it. Thanks > --- > bod
On Thu, 02 Dec 2021 08:00:12 +0800, Fenglin Wu wrote: > Convert the SPMI PMIC arbiter documentation to JSON/yaml. While at it, > update SPMI bus "reg" items constraint for SPMI PMIC arbiter to carry > it and update it with a smaller range. > > Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com> > --- > .../bindings/spmi/qcom,spmi-pmic-arb.txt | 67 ----------- > .../bindings/spmi/qcom,spmi-pmic-arb.yaml | 128 +++++++++++++++++++++ > Documentation/devicetree/bindings/spmi/spmi.yaml | 3 +- > 3 files changed, 130 insertions(+), 68 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt > create mode 100644 Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1562483 qcom,spmi@400f000: $nodename:0: 'qcom,spmi@400f000' does not match '^spmi@.*' arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dt.yaml arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dt.yaml arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dt.yaml arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dt.yaml qcom,spmi@400f000: 'pmic@0', 'pmic@1', 'pmic@2', 'pmic@3' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dt.yaml arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dt.yaml qcom,spmi@400f000: reg-names: 'oneOf' conditional failed, one must be fixed: arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dt.yaml arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dt.yaml qcom,spmi@c440000: $nodename:0: 'qcom,spmi@c440000' does not match '^spmi@.*' arch/arm/boot/dts/qcom-sdx55-mtp.dt.yaml arch/arm/boot/dts/qcom-sdx55-mtp.dt.yaml arch/arm/boot/dts/qcom-sdx55-t55.dt.yaml arch/arm/boot/dts/qcom-sdx55-t55.dt.yaml arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dt.yaml arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dt.yaml qcom,spmi@c440000: 'cell-index', 'pmic@2', 'pmic@3', 'pmic@8', 'pmic@9' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/qcom-sdx55-mtp.dt.yaml qcom,spmi@c440000: 'cell-index', 'pmic@8', 'pmic@9' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/qcom-sdx55-t55.dt.yaml arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dt.yaml qcom,spmi@c440000: reg-names: 'oneOf' conditional failed, one must be fixed: arch/arm/boot/dts/qcom-sdx55-mtp.dt.yaml arch/arm/boot/dts/qcom-sdx55-t55.dt.yaml arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dt.yaml spmi@1c40000: 'cell-index' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dt.yaml spmi@1c40000: reg-names: 'oneOf' conditional failed, one must be fixed: arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dt.yaml spmi@200f000: 'cell-index' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml spmi@200f000: 'pmic@0', 'pmic@1' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dt.yaml arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dt.yaml arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dt.yaml arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dt.yaml arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dt.yaml arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dt.yaml spmi@200f000: 'pms405@0', 'pms405@1' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/qcs404-evb-1000.dt.yaml arch/arm64/boot/dts/qcom/qcs404-evb-4000.dt.yaml spmi@200f000: reg-names: 'oneOf' conditional failed, one must be fixed: arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dt.yaml arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dt.yaml arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dt.yaml arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dt.yaml arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dt.yaml arch/arm64/boot/dts/qcom/qcs404-evb-1000.dt.yaml arch/arm64/boot/dts/qcom/qcs404-evb-4000.dt.yaml arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dt.yaml spmi@800f000: 'cell-index' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dt.yaml spmi@800f000: 'cell-index', 'pmic@0', 'pmic@1', 'pmic@2', 'pmic@3' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sdm630-sony-xperia-ganges-kirin.dt.yaml arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile-discovery.dt.yaml arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile-pioneer.dt.yaml arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile-voyager.dt.yaml arch/arm64/boot/dts/qcom/sdm636-sony-xperia-ganges-mermaid.dt.yaml spmi@800f000: 'cell-index', 'pmic@0', 'pmic@1', 'pmic@2', 'pmic@3', 'pmic@4', 'pmic@5' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dt.yaml arch/arm64/boot/dts/qcom/msm8998-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dt.yaml arch/arm64/boot/dts/qcom/msm8998-oneplus-dumpling.dt.yaml arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-lilac.dt.yaml arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-maple.dt.yaml arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dt.yaml spmi@800f000: 'cell-index', 'pmic@0', 'pmic@1', 'pmic@4', 'pmic@5' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/msm8998-asus-novago-tp370ql.dt.yaml arch/arm64/boot/dts/qcom/msm8998-hp-envy-x2.dt.yaml arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dt.yaml spmi@800f000: reg-names: 'oneOf' conditional failed, one must be fixed: arch/arm64/boot/dts/qcom/msm8998-asus-novago-tp370ql.dt.yaml arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dt.yaml arch/arm64/boot/dts/qcom/msm8998-hp-envy-x2.dt.yaml arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dt.yaml arch/arm64/boot/dts/qcom/msm8998-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dt.yaml arch/arm64/boot/dts/qcom/msm8998-oneplus-dumpling.dt.yaml arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-lilac.dt.yaml arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-maple.dt.yaml arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dt.yaml arch/arm64/boot/dts/qcom/sdm630-sony-xperia-ganges-kirin.dt.yaml arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile-discovery.dt.yaml arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile-pioneer.dt.yaml arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile-voyager.dt.yaml arch/arm64/boot/dts/qcom/sdm636-sony-xperia-ganges-mermaid.dt.yaml arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dt.yaml spmi@c440000: #address-cells:0:0: 2 was expected arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7280-herobrine.dt.yaml arch/arm64/boot/dts/qcom/sc7280-herobrine.dt.yaml arch/arm64/boot/dts/qcom/sc7280-herobrine.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp2.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp2.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp2.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp.dt.yaml spmi@c440000: 'cell-index' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml spmi@c440000: 'cell-index', 'pmic@0', 'pmic@1' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml spmi@c440000: 'cell-index', 'pmic@0', 'pmic@1', 'pmic@2', 'pmic@3' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml spmi@c440000: 'cell-index', 'pmic@0', 'pmic@1', 'pmic@2', 'pmic@3', 'pmic@4', 'pmic@5' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sm8150-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dt.yaml arch/arm64/boot/dts/qcom/sm8150-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-bahamut.dt.yaml arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-griffin.dt.yaml spmi@c440000: 'cell-index', 'pmic@0', 'pmic@1', 'pmic@4', 'pmic@5' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sa8155p-adp.dt.yaml arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml spmi@c440000: 'pmic@0', 'pmic@1' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dt.yaml spmi@c440000: 'pmic@0', 'pmic@1', 'pmic@2' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sc7280-herobrine.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp2.dt.yaml spmi@c440000: 'pmic@0', 'pmic@1', 'pmic@2', 'pmic@3', 'pmic@4', 'pmic@5' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8350-mtp.dt.yaml spmi@c440000: 'pmic@0', 'pmic@1', 'pmic@2', 'pmic@3', 'pmic@4', 'pmic@5', 'pmic@a', 'pmic@b' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml spmi@c440000: 'pmic@0', 'pmic@1', 'pmic@2', 'pmic@4' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sc7280-idp.dt.yaml spmi@c440000: reg-names: 'oneOf' conditional failed, one must be fixed: arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sa8155p-adp.dt.yaml arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7280-herobrine.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp2.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dt.yaml arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dt.yaml arch/arm64/boot/dts/qcom/sm8150-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dt.yaml arch/arm64/boot/dts/qcom/sm8150-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-bahamut.dt.yaml arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-griffin.dt.yaml arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml arch/arm64/boot/dts/qcom/sm8350-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8350-mtp.dt.yaml spmi@c440000: #size-cells:0:0: 0 was expected arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7280-herobrine.dt.yaml arch/arm64/boot/dts/qcom/sc7280-herobrine.dt.yaml arch/arm64/boot/dts/qcom/sc7280-herobrine.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp2.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp2.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp2.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp.dt.yaml spmi@fc4c0000: 'pmic@0', 'pmic@1', 'pmic@2', 'pmic@3' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/apq8094-sony-xperia-kitakami-karin_windy.dt.yaml arch/arm64/boot/dts/qcom/msm8992-bullhead-rev-101.dt.yaml arch/arm64/boot/dts/qcom/msm8992-msft-lumia-octagon-talkman.dt.yaml arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dt.yaml arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon-cityman.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-ivy.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-karin.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-satsuki.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-sumire.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-suzuran.dt.yaml spmi@fc4cf000: 'pm8226@0', 'pm8226@1' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/qcom-apq8026-lg-lenok.dt.yaml spmi@fc4cf000: 'pm8841@4', 'pm8841@5', 'pm8941@0', 'pm8941@1' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml spmi@fc4cf000: 'pma8084@0', 'pma8084@1' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml
Quoting Rob Herring (2021-12-02 05:58:09) > On Thu, 02 Dec 2021 08:00:12 +0800, Fenglin Wu wrote: > > Convert the SPMI PMIC arbiter documentation to JSON/yaml. While at it, > > update SPMI bus "reg" items constraint for SPMI PMIC arbiter to carry > > it and update it with a smaller range. > > > > Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com> > > --- > > .../bindings/spmi/qcom,spmi-pmic-arb.txt | 67 ----------- > > .../bindings/spmi/qcom,spmi-pmic-arb.yaml | 128 +++++++++++++++++++++ > > Documentation/devicetree/bindings/spmi/spmi.yaml | 3 +- > > 3 files changed, 130 insertions(+), 68 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt > > create mode 100644 Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1562483 Are any of these problems going to be fixed?
Sorry for late response. I had a check in the log and tried "make dtbs_check" at my side. There are 5 types of warnings, I guess I can fix two types of them. 1) : qcom,spmi@400f000: 'pmic@0', 'pmic@1', 'pmic@2', 'pmic@3' do not match any of the regexes: 'pinctrl-[0-9]+' This indicates the child nodes devices are not recognized, this can be fixed by adding pattern properties similar to what defines in spmi.yaml. I will address it in next patchset. 2) qcom,spmi@400f000: reg-names: 'oneOf' conditional failed, one must be fixed: This is because of the "items" defined in "reg-name" does not match between the dtsi nodes and the schema in sequence wise. I will update the scheme for "reg-name" like this to fix it in next patchset: reg-names: anyOf: - minItems: 3 - maxItems: 3 - enum: ["core", "intr", "cnfg"] - minItems: 5 - maxItems: 5 - enum: ["core", "intr", "cnfg", "chnls", "obsrvr"] 3) qcom,spmi@400f000: $nodename:0: 'qcom,spmi@400f000' does not match '^spmi@.*' This indicates the mismatch of the device node name between the dtsi and schema, I guess the fix should be in dtsi file instead of this binding, the spmi.yaml file has defined the nodename with "spmi@" prefix, qcom,spmi-pmic-arb.yaml should follow this. Should I make the change and update all the nodes names in dtsi file like this? Or can this be ignored and leave it to dtsi file owners to update them accordingly? 4) spmi@c440000: #address-cells:0:0: 2 was expected spmi@c440000: #size-cells:0:0: 0 was expected Some of the spmi device nodes specify #address-cell = < 1>, and #size-cell = <1>, the original .txt binding specified #address-cell = < 2>, and #size-cell = <0>. The change should be in dtsi to update them following the binding. Let me know if I should do this, or I can leave itto the dtsi file owners to update them accordingly. 5) spmi@1c40000: 'cell-index' does not match any of the regexes: 'pinctrl-[0-9]+' "cell-index" is not used in the driver, also it doesn't exist in the .txt binding, so this should be fixedin the corresponding dtsi file. Let me know if I need to fix it. Thanks On 2021/12/10 10:05, Stephen Boyd wrote: > Quoting Rob Herring (2021-12-02 05:58:09) >> On Thu, 02 Dec 2021 08:00:12 +0800, Fenglin Wu wrote: >>> Convert the SPMI PMIC arbiter documentation to JSON/yaml. While at it, >>> update SPMI bus "reg" items constraint for SPMI PMIC arbiter to carry >>> it and update it with a smaller range. >>> >>> Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com> >>> --- >>> .../bindings/spmi/qcom,spmi-pmic-arb.txt | 67 ----------- >>> .../bindings/spmi/qcom,spmi-pmic-arb.yaml | 128 +++++++++++++++++++++ >>> Documentation/devicetree/bindings/spmi/spmi.yaml | 3 +- >>> 3 files changed, 130 insertions(+), 68 deletions(-) >>> delete mode 100644 Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt >>> create mode 100644 Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml >>> >> Running 'make dtbs_check' with the schema in this patch gives the >> following warnings. Consider if they are expected or the schema is >> incorrect. These may not be new warnings. >> >> Note that it is not yet a requirement to have 0 warnings for dtbs_check. >> This will change in the future. >> >> Full log is available here: https://patchwork.ozlabs.org/patch/1562483 > Are any of these problems going to be fixed?