mbox series

[v2,0/2] scsi: qedi: Couple of warning fixes

Message ID 20211126201708.27140-1-f.fainelli@gmail.com
Headers show
Series scsi: qedi: Couple of warning fixes | expand

Message

Florian Fainelli Nov. 26, 2021, 8:17 p.m. UTC 
These warnings started to show up after enabling PCI on BMIPS (32-bit
MIPS architecture) and were reported by the kbuild robot.

I don't know whether they are technically correct, in particular the
unused 'page' variable might be unveiling a genuine bug whereby it
should have been used. Please review.

Changes in v2:

- added Acked-by to patch #1
- changed SYSFS_FLAG_FW_SEL_BOOT to contain the typecasting and not
  change the way it is formatted before sysfs printing

Florian Fainelli (2):
  scsi: qedi: Remove set but unused 'page' variable
  scsi: qedi: Fix SYSFS_FLAG_FW_SEL_BOOT formatting

 drivers/scsi/qedi/qedi.h      | 2 +-
 drivers/scsi/qedi/qedi_main.c | 3 ---
 2 files changed, 1 insertion(+), 4 deletions(-)

Comments

Martin K. Petersen Nov. 30, 2021, 4 a.m. UTC | #1 
Florian,

> The variable page is set but never used throughout qedi_alloc_bdq()
> therefore remove it.

Applied to 5.17/scsi-staging, thanks!
Martin K. Petersen Dec. 3, 2021, 3:03 a.m. UTC | #2 
On Fri, 26 Nov 2021 12:17:06 -0800, Florian Fainelli wrote:

> These warnings started to show up after enabling PCI on BMIPS (32-bit
> MIPS architecture) and were reported by the kbuild robot.
> 
> I don't know whether they are technically correct, in particular the
> unused 'page' variable might be unveiling a genuine bug whereby it
> should have been used. Please review.
> 
> [...]

Applied to 5.17/scsi-queue, thanks!

[1/2] scsi: qedi: Remove set but unused 'page' variable
      https://git.kernel.org/mkp/scsi/c/6d8619f034f0