| Message ID | 20211125152043.162655-1-geert@linux-m68k.org |
|---|---|
| State | Accepted |
| Commit | 4f45348934074553681a8964bae740a22599cf2e |
| Headers | show |
| Series | dt-bindings: gpio: sifive,gpio: Group interrupt tuples | expand |
Hi Linus, On Fri, Nov 26, 2021 at 2:22 AM Linus Walleij <linus.walleij@linaro.org> wrote: > On Thu, Nov 25, 2021 at 4:20 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > To improve human readability and enable automatic validation, the tuples > > in "interrupts" properties should be grouped using angle brackets. > > > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > > (...) > > - interrupts = <7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22>; > > + interrupts = <7>, <8>, <9>, <10>, <11>, <12>, <13>, <14>, <15>, <16>, > > + <17>, <18>, <19>, <20>, <21>, <22>; > > Tuples? Hm they look single. Like singletons? Yeah, plic has #interrupt-cells = <1>. > Anyway: > Acked-by: Linus Walleij <linus.walleij@linaro.org> Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Thu, Nov 25, 2021 at 4:20 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > To improve human readability and enable automatic validation, the tuples > in "interrupts" properties should be grouped using angle brackets. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > Documentation/devicetree/bindings/gpio/sifive,gpio.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml b/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml > index c2902aac25145205..e04349567eebb72c 100644 > --- a/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml > @@ -77,7 +77,8 @@ examples: > gpio@10060000 { > compatible = "sifive,fu540-c000-gpio", "sifive,gpio0"; > interrupt-parent = <&plic>; > - interrupts = <7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22>; > + interrupts = <7>, <8>, <9>, <10>, <11>, <12>, <13>, <14>, <15>, <16>, > + <17>, <18>, <19>, <20>, <21>, <22>; > reg = <0x10060000 0x1000>; > clocks = <&tlclk PRCI_CLK_TLCLK>; > gpio-controller; > -- > 2.25.1 > Applied, thanks! Bart
diff --git a/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml b/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml index c2902aac25145205..e04349567eebb72c 100644 --- a/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml +++ b/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml @@ -77,7 +77,8 @@ examples: gpio@10060000 { compatible = "sifive,fu540-c000-gpio", "sifive,gpio0"; interrupt-parent = <&plic>; - interrupts = <7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22>; + interrupts = <7>, <8>, <9>, <10>, <11>, <12>, <13>, <14>, <15>, <16>, + <17>, <18>, <19>, <20>, <21>, <22>; reg = <0x10060000 0x1000>; clocks = <&tlclk PRCI_CLK_TLCLK>; gpio-controller;
To improve human readability and enable automatic validation, the tuples in "interrupts" properties should be grouped using angle brackets. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- Documentation/devicetree/bindings/gpio/sifive,gpio.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)