| Message ID | cover.1637048107.git.quic_vamslank@quicinc.com |
|---|---|
| Headers | show |
| Series | Add pinctrl support for SDX65 | expand |
On Mon, Nov 15, 2021 at 11:39:45PM -0800, quic_vamslank@quicinc.com wrote: > From: Vamsi Krishna Lanka <quic_vamslank@quicinc.com> > > Add device tree binding Documentation details for Qualcomm SDX65 > pinctrl driver. > > Signed-off-by: Vamsi Krishna Lanka <quic_vamslank@quicinc.com> > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > .../bindings/pinctrl/qcom,sdx65-pinctrl.yaml | 195 ++++++++++++++++++ > 1 file changed, 195 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml This fails dt_binding_check: /builds/robherring/linux-dt/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.example.dt.yaml: pinctrl@f100000: 'serial-pins', 'uart-w-subnodes-state' do not match any of the regexes: '$-state', 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml The DT list was not Cc'ed so checks never ran nor was this reviewed. Rob
On Sat, Nov 27, 2021 at 01:07:16AM +0100, Linus Walleij wrote: > On Fri, Nov 26, 2021 at 11:01 PM Rob Herring <robh@kernel.org> wrote: > > On Mon, Nov 15, 2021 at 11:39:45PM -0800, quic_vamslank@quicinc.com wrote: > > > From: Vamsi Krishna Lanka <quic_vamslank@quicinc.com> > > > > > > Add device tree binding Documentation details for Qualcomm SDX65 > > > pinctrl driver. > > > > > > Signed-off-by: Vamsi Krishna Lanka <quic_vamslank@quicinc.com> > > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > > --- > > > .../bindings/pinctrl/qcom,sdx65-pinctrl.yaml | 195 ++++++++++++++++++ > > > 1 file changed, 195 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml > > > > This fails dt_binding_check: > > > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.example.dt.yaml: pinctrl@f100000: 'serial-pins', 'uart-w-subnodes-state' do not match any of the regexes: '$-state', 'pinctrl-[0-9]+' > > From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml > > > > The DT list was not Cc'ed so checks never ran nor was this reviewed. > > OK that's annoying, I didn't notice it wasn't posted to the DT list. > I reverted the patch, Vamsi can you please reiterate the patch > and include devicetree@vger.kernel.org on subsequent postings. > I have kept the kernel code in place, optimistically assuming the > bindings will be fixed soon-ish. I'm sorry for overlooking this. I will fix this and post a new patch soon. Thanks, Vamsi > > Yours, > Linus Walleij
From: Vamsi Krishna Lanka <quic_vamslank@quicinc.com> Hello, Changes from v3: - Addressed comments, fixed dt_binding check errors and collected reviewed by from Bjorn - Rebased on top of v5.16-rc1 Changes from v2: - Addressed comments from Bjorn - Collected Reviewed-by for the patches Changes from v1: - Addressed all Bjorn's comments This patch series adds pinctrl bindings and tlmm support for SDX65. Thanks, Vamsi Vamsi Krishna Lanka (2): dt-bindings: pinctrl: qcom: Add SDX65 pinctrl bindings pinctrl: qcom: Add SDX65 pincontrol driver .../bindings/pinctrl/qcom,sdx65-pinctrl.yaml | 195 ++++ drivers/pinctrl/qcom/Kconfig | 9 + drivers/pinctrl/qcom/Makefile | 1 + drivers/pinctrl/qcom/pinctrl-sdx65.c | 967 ++++++++++++++++++ 4 files changed, 1172 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml create mode 100644 drivers/pinctrl/qcom/pinctrl-sdx65.c base-commit: 8ab774587903771821b59471cc723bba6d893942 prerequisite-patch-id: 07cee59dfdf0a1bd637b4bdc95ae68b34b8ffb0d prerequisite-patch-id: b9bf5583d0b5368b8f2f32b9a94d5054899ec99a prerequisite-patch-id: 730337f77ae4f00c8320c309fb864e760cc5ed54 prerequisite-patch-id: ba1594c6d524ae889dd4325d0912848f5542633b prerequisite-patch-id: 6efd062dc77400d108f3f4a0c66010c69759d64a prerequisite-patch-id: fb27c240bc512176c822e6f1c7cb5b8d65633c56 prerequisite-patch-id: 8125f49031bb5d9ebca1ca3e622080d6d3683bfb prerequisite-patch-id: e6ecff6bfb4016b9118b2b25f4077355a1448220 prerequisite-patch-id: ba2f7d61be224484482d4910116ea69f1f5200ea