| Message ID | 20211015041053.2769193-17-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | user-only: Cleanup SIGSEGV and SIGBUS handling | expand |
On Thu, Oct 14, 2021 at 10:11 PM Richard Henderson < richard.henderson@linaro.org> wrote: > The named function no longer exists. > Refer to host_signal_handler instead. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/arm/sve_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Warner Losh <imp@bsdimp.com> > diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c > index dab5f1d1cd..07be55b7e1 100644 > --- a/target/arm/sve_helper.c > +++ b/target/arm/sve_helper.c > @@ -6118,7 +6118,7 @@ DO_LDN_2(4, dd, MO_64) > * linux-user/ in its get_user/put_user macros. > * > * TODO: Construct some helpers, written in assembly, that interact with > - * handle_cpu_signal to produce memory ops which can properly report > errors > + * host_signal_handler to produce memory ops which can properly report > errors > * without racing. > */ > > -- > 2.25.1 > > <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 14, 2021 at 10:11 PM Richard Henderson <<a href="mailto:richard.henderson@linaro.org">richard.henderson@linaro.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The named function no longer exists.<br> Refer to host_signal_handler instead.<br> <br> Signed-off-by: Richard Henderson <<a href="mailto:richard.henderson@linaro.org" target="_blank">richard.henderson@linaro.org</a>><br> ---<br> target/arm/sve_helper.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br></blockquote><div><br></div><div><div>Reviewed-by: Warner Losh <<a href="mailto:imp@bsdimp.com">imp@bsdimp.com</a>></div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c<br> index dab5f1d1cd..07be55b7e1 100644<br> --- a/target/arm/sve_helper.c<br> +++ b/target/arm/sve_helper.c<br> @@ -6118,7 +6118,7 @@ DO_LDN_2(4, dd, MO_64)<br> * linux-user/ in its get_user/put_user macros.<br> *<br> * TODO: Construct some helpers, written in assembly, that interact with<br> - * handle_cpu_signal to produce memory ops which can properly report errors<br> + * host_signal_handler to produce memory ops which can properly report errors<br> * without racing.<br> */<br> <br> -- <br> 2.25.1<br> <br> </blockquote></div></div>
On 10/15/21 06:10, Richard Henderson wrote: > The named function no longer exists. It seems to be declared inlined since QEMU v0.1.0 in 2003! So it was likely a typo. Anyhow, Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > Refer to host_signal_handler instead. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/arm/sve_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c > index dab5f1d1cd..07be55b7e1 100644 > --- a/target/arm/sve_helper.c > +++ b/target/arm/sve_helper.c > @@ -6118,7 +6118,7 @@ DO_LDN_2(4, dd, MO_64) > * linux-user/ in its get_user/put_user macros. > * > * TODO: Construct some helpers, written in assembly, that interact with > - * handle_cpu_signal to produce memory ops which can properly report errors > + * host_signal_handler to produce memory ops which can properly report errors > * without racing. > */ > >
diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c index dab5f1d1cd..07be55b7e1 100644 --- a/target/arm/sve_helper.c +++ b/target/arm/sve_helper.c @@ -6118,7 +6118,7 @@ DO_LDN_2(4, dd, MO_64) * linux-user/ in its get_user/put_user macros. * * TODO: Construct some helpers, written in assembly, that interact with - * handle_cpu_signal to produce memory ops which can properly report errors + * host_signal_handler to produce memory ops which can properly report errors * without racing. */
The named function no longer exists. Refer to host_signal_handler instead. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/arm/sve_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1