| Message ID | 20211026102234.3961636-28-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | testing, plugins and gdbstub for 6.2 | expand |
On 10/26/21 12:22, Alex Bennée wrote: > We set it bellow outside the #if leg. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > tests/tcg/multiarch/Makefile.target | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
On 10/26/21 3:22 AM, Alex Bennée wrote: > We set it bellow outside the #if leg. > > Signed-off-by: Alex Bennée<alex.bennee@linaro.org> > --- > tests/tcg/multiarch/Makefile.target | 2 -- > 1 file changed, 2 deletions(-) Surely it's better to have them inside the IF? Why add tests that we're definitely going to SKIP? r~
Richard Henderson <richard.henderson@linaro.org> writes: > On 10/26/21 3:22 AM, Alex Bennée wrote: >> We set it bellow outside the #if leg. >> Signed-off-by: Alex Bennée<alex.bennee@linaro.org> >> --- >> tests/tcg/multiarch/Makefile.target | 2 -- >> 1 file changed, 2 deletions(-) > > Surely it's better to have them inside the IF? > Why add tests that we're definitely going to SKIP? At least this way you get a visual indication of tests that are skipped (and you might be able to do something about that). -- Alex Bennée
diff --git a/tests/tcg/multiarch/Makefile.target b/tests/tcg/multiarch/Makefile.target index 6ccb592aac..c0d9e638e9 100644 --- a/tests/tcg/multiarch/Makefile.target +++ b/tests/tcg/multiarch/Makefile.target @@ -61,8 +61,6 @@ run-gdbstub-sha1: sha1 --bin $< --test $(MULTIARCH_SRC)/gdbstub/sha1.py, \ "basic gdbstub support") -EXTRA_RUNS += run-gdbstub-sha1 - run-gdbstub-qxfer-auxv-read: sha1 $(call run-test, $@, $(GDB_SCRIPT) \ --gdb $(HAVE_GDB_BIN) \
We set it bellow outside the #if leg. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- tests/tcg/multiarch/Makefile.target | 2 -- 1 file changed, 2 deletions(-) -- 2.30.2