diff mbox series

[v1,12/28] ebpf: really include it only in system emulators

Message ID 20211026102234.3961636-13-alex.bennee@linaro.org
State Superseded
Headers show
Series testing, plugins and gdbstub for 6.2 | expand

Commit Message

Alex Bennée Oct. 26, 2021, 10:22 a.m. UTC 
From: Paolo Bonzini <pbonzini@redhat.com>


eBPF libraries are being included in user emulators, which is useless and
also breaks --static compilation if a shared library for libbpf is
present in the system.

Reported-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20211012162252.263933-1-pbonzini@redhat.com>
---
 meson.build | 2 --
 1 file changed, 2 deletions(-)

-- 
2.30.2

Comments

Richard Henderson Oct. 26, 2021, 8:03 p.m. UTC | #1 
On 10/26/21 3:22 AM, Alex Bennée wrote:
> From: Paolo Bonzini<pbonzini@redhat.com>

> 

> eBPF libraries are being included in user emulators, which is useless and

> also breaks --static compilation if a shared library for libbpf is

> present in the system.

> 

> Reported-by: Alex Bennée<alex.bennee@linaro.org>

> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>

> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>

> Message-Id:<20211012162252.263933-1-pbonzini@redhat.com>

> ---

>   meson.build | 2 --

>   1 file changed, 2 deletions(-)


Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~
Warner Losh Oct. 27, 2021, 4:10 p.m. UTC | #2 
> On Oct 26, 2021, at 4:22 AM, Alex Bennée <alex.bennee@linaro.org> wrote:

> 

> From: Paolo Bonzini <pbonzini@redhat.com>

> 

> eBPF libraries are being included in user emulators, which is useless and

> also breaks --static compilation if a shared library for libbpf is

> present in the system.

> 

> Reported-by: Alex Bennée <alex.bennee@linaro.org>

> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> Message-Id: <20211012162252.263933-1-pbonzini@redhat.com>


Reviewed-bt: Warner Losh <imp@bsdimp.com>

> ---

> meson.build | 2 --

> 1 file changed, 2 deletions(-)

> 

> diff --git a/meson.build b/meson.build

> index 2c5b53cbe2..bc520b579c 100644

> --- a/meson.build

> +++ b/meson.build

> @@ -2610,8 +2610,6 @@ subdir('bsd-user')

> subdir('linux-user')

> subdir('ebpf')

> 

> -common_ss.add(libbpf)

> -

> specific_ss.add_all(when: 'CONFIG_BSD_USER', if_true: bsd_user_ss)

> 

> linux_user_ss.add(files('thunk.c'))

> -- 

> 2.30.2

> 

>
diff mbox series

Patch

diff --git a/meson.build b/meson.build
index 2c5b53cbe2..bc520b579c 100644
--- a/meson.build
+++ b/meson.build
@@ -2610,8 +2610,6 @@  subdir('bsd-user')
 subdir('linux-user')
 subdir('ebpf')
 
-common_ss.add(libbpf)
-
 specific_ss.add_all(when: 'CONFIG_BSD_USER', if_true: bsd_user_ss)
 
 linux_user_ss.add(files('thunk.c'))