mbox series

[RESEND,v3,0/4] input: MT6358 PMIC button support

Message ID 20210816100013.100412-1-mkorpershoek@baylibre.com
Headers show
Series input: MT6358 PMIC button support | expand

Message

Mattijs Korpershoek Aug. 16, 2021, 10 a.m. UTC 
The MediaTek MT6358 PMIC has support for two buttons: PWR and HOME.

The interrupt logic is a little different than other PMICs from the
same family:
for MT6323 and MT6397, we have one interrupt source per button
* for MT6358, we have two interrupts lines per button: the press and
* release interrupts are distinct sources.

Changes since original v2 at [1]:
* added 4th patch with device tree enable
* cover letter title prefixed with 'input'

This has been tested with evtest on mt8183-pumpkin on 5.14-rc6

Mattijs Korpershoek (4):
  Input: mtk-pmic-keys - use get_irq_byname() instead of index
  dt-bindings: input: mtk-pmic-keys: add MT6358 binding definition
  Input: mtk-pmic-keys - add support for MT6358
  arm64: dts: mt6358: add mt6358-keys node

 .../bindings/input/mtk-pmic-keys.txt          |  5 +-
 arch/arm64/boot/dts/mediatek/mt6358.dtsi      | 12 ++++
 drivers/input/keyboard/mtk-pmic-keys.c        | 56 +++++++++++++++++--
 3 files changed, 68 insertions(+), 5 deletions(-)

Comments

Kevin Hilman Sept. 14, 2021, 7:16 p.m. UTC | #1 
Hi Dmitry,

Mattijs Korpershoek <mkorpershoek@baylibre.com> writes:

> The MediaTek MT6358 PMIC has support for two buttons: PWR and HOME.

>

> The interrupt logic is a little different than other PMICs from the

> same family:

> for MT6323 and MT6397, we have one interrupt source per button

> * for MT6358, we have two interrupts lines per button: the press and

> * release interrupts are distinct sources.

>

> Changes since original v2 at [1]:

> * added 4th patch with device tree enable

> * cover letter title prefixed with 'input'

>

> This has been tested with evtest on mt8183-pumpkin on 5.14-rc6


Any feedback on this series?

The related MFD patches were merged already, so there are no out-of-tree
dependencies.

Thanks,

Kevin
Kevin Hilman Oct. 5, 2021, 5:48 p.m. UTC | #2 
Dmitry,

Kevin Hilman <khilman@baylibre.com> writes:

> Hi Dmitry,

>

> Mattijs Korpershoek <mkorpershoek@baylibre.com> writes:

>

>> The MediaTek MT6358 PMIC has support for two buttons: PWR and HOME.

>>

>> The interrupt logic is a little different than other PMICs from the

>> same family:

>> for MT6323 and MT6397, we have one interrupt source per button

>> * for MT6358, we have two interrupts lines per button: the press and

>> * release interrupts are distinct sources.

>>

>> Changes since original v2 at [1]:

>> * added 4th patch with device tree enable

>> * cover letter title prefixed with 'input'

>>

>> This has been tested with evtest on mt8183-pumpkin on 5.14-rc6

>

> Any feedback on this series?

>

> The related MFD patches were merged already, so there are no out-of-tree

> dependencies.


Gentle reminder ping.

Thanks,

Kevin