diff mbox series

dmascc: add CONFIG_VIRT_TO_BUS dependency

Message ID 20210927141529.1614679-1-arnd@kernel.org
State New
Headers show
Series dmascc: add CONFIG_VIRT_TO_BUS dependency | expand

Commit Message

Arnd Bergmann Sept. 27, 2021, 2:15 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>


Many architectures don't define virt_to_bus() any more, as drivers
should be using the dma-mapping interfaces where possible:

In file included from drivers/net/hamradio/dmascc.c:27:
drivers/net/hamradio/dmascc.c: In function 'tx_on':
drivers/net/hamradio/dmascc.c:976:30: error: implicit declaration of function 'virt_to_bus'; did you mean 'virt_to_fix'? [-Werror=implicit-function-declaration]
  976 |                              virt_to_bus(priv->tx_buf[priv->tx_tail]) + n);
      |                              ^~~~~~~~~~~
arch/arm/include/asm/dma.h:109:52: note: in definition of macro 'set_dma_addr'
  109 |         __set_dma_addr(chan, (void *)__bus_to_virt(addr))
      |                                                    ^~~~

Add the Kconfig dependency to prevent this from being built on
architectures without virt_to_bus().

Fixes: bc1abb9e55ce ("dmascc: use proper 'virt_to_bus()' rather than casting to 'int'")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/net/hamradio/Kconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.29.2

Comments

patchwork-bot+netdevbpf@kernel.org Sept. 28, 2021, 12:20 p.m. UTC | #1 
Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon, 27 Sep 2021 16:15:24 +0200 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>

> 

> Many architectures don't define virt_to_bus() any more, as drivers

> should be using the dma-mapping interfaces where possible:

> 

> In file included from drivers/net/hamradio/dmascc.c:27:

> drivers/net/hamradio/dmascc.c: In function 'tx_on':

> drivers/net/hamradio/dmascc.c:976:30: error: implicit declaration of function 'virt_to_bus'; did you mean 'virt_to_fix'? [-Werror=implicit-function-declaration]

>   976 |                              virt_to_bus(priv->tx_buf[priv->tx_tail]) + n);

>       |                              ^~~~~~~~~~~

> arch/arm/include/asm/dma.h:109:52: note: in definition of macro 'set_dma_addr'

>   109 |         __set_dma_addr(chan, (void *)__bus_to_virt(addr))

>       |                                                    ^~~~

> 

> [...]


Here is the summary with links:
  - dmascc: add CONFIG_VIRT_TO_BUS dependency
    https://git.kernel.org/netdev/net/c/05e97b3d33cb

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/net/hamradio/Kconfig b/drivers/net/hamradio/Kconfig
index f4843f9672c1..441da03c23ee 100644
--- a/drivers/net/hamradio/Kconfig
+++ b/drivers/net/hamradio/Kconfig
@@ -48,6 +48,7 @@  config BPQETHER
 config DMASCC
 	tristate "High-speed (DMA) SCC driver for AX.25"
 	depends on ISA && AX25 && BROKEN_ON_SMP && ISA_DMA_API
+	depends on VIRT_TO_BUS
 	help
 	  This is a driver for high-speed SCC boards, i.e. those supporting
 	  DMA on one port. You usually use those boards to connect your