| Message ID | 20210913192816.1225025-5-robh@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | Arm boards syscon 'unit_address_format' clean-ups | expand |
Quoting Rob Herring (2021-09-13 12:28:12) > 'reg' is the standard property for defining register banks/addresses. Add > it to use for the VCO register address and deprecate 'vco-offset'. This > will also allow for using standard node names with unit-addresses. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-clk@vger.kernel.org > Cc: Michael Turquette <mturquette@baylibre.com> > Signed-off-by: Rob Herring <robh@kernel.org> > > --- Reviewed-by: Stephen Boyd <sboyd@kernel.org>
On Mon, Sep 13, 2021 at 9:28 PM Rob Herring <robh@kernel.org> wrote: > 'reg' is the standard property for defining register banks/addresses. Add > it to use for the VCO register address and deprecate 'vco-offset'. This > will also allow for using standard node names with unit-addresses. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-clk@vger.kernel.org > Cc: Michael Turquette <mturquette@baylibre.com> > Signed-off-by: Rob Herring <robh@kernel.org> Yeah this is better, dunno why I did it like that. I guess it was the Wild West of DT bindings back then. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml index 118c5543e037..90eadf6869b2 100644 --- a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml +++ b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml @@ -69,6 +69,10 @@ properties: - arm,impd1-vco1 - arm,impd1-vco2 + reg: + maxItems: 1 + description: The VCO register + clocks: description: Parent clock for the ICST VCO maxItems: 1 @@ -83,6 +87,7 @@ properties: vco-offset: $ref: '/schemas/types.yaml#/definitions/uint32' description: Offset to the VCO register for the oscillator + deprecated: true required: - "#clock-cells"
'reg' is the standard property for defining register banks/addresses. Add it to use for the VCO register address and deprecate 'vco-offset'. This will also allow for using standard node names with unit-addresses. Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Stephen Boyd <sboyd@kernel.org> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-clk@vger.kernel.org Cc: Michael Turquette <mturquette@baylibre.com> Signed-off-by: Rob Herring <robh@kernel.org> --- v2: - Fix 'deprecated' --- Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 5 +++++ 1 file changed, 5 insertions(+)