| Message ID | 20210909085613.5577-1-atenart@kernel.org |
|---|---|
| Headers | show |
| Series | thermal: int340x: fix tcc offset on resume | expand |
On Thu, 2021-09-09 at 10:56 +0200, Antoine Tenart wrote: > Hi, > > This is a follow-up of [1]. As discussed in the initial thread, the fix > is now split into two commits: the two commits combined are fixing the > issue in a nice way for 5.15, but only the first one is meant to be > applied on stable kernels (to avoid conflicts). > > The issue this is fixing is described in patch 1. Tl;dr: a > suspend/resume cycle can end-up in setting a wrong tcc offset value, > which can lead to machines shutting down because of overheating (when > they should not). > > I've stripped the Acked-by/Tested-by flags from v1 as the patch was > split. But the end result for 5.15+ kernels should be the same. > > Thanks, > Antoine > > [1] > https://lore.kernel.org/linux-pm/20210908161632.15520-1-atenart@kernel.org/T/ > > Antoine Tenart (2): > thermal: int340x: do not set a wrong tcc offset on resume > thermal: int340x: improve the tcc offset saving for suspend/resume > > .../intel/int340x_thermal/int3401_thermal.c | 8 +++- > .../processor_thermal_device.c | 39 ++++++++++++++----- > .../processor_thermal_device.h | 1 + > .../processor_thermal_device_pci.c | 18 ++++++++- > .../processor_thermal_device_pci_legacy.c | 8 +++- > 5 files changed, 62 insertions(+), 12 deletions(-) > Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Tested-by: Srinivas Pandruvada <srinivas.pI andruvada@linux.intel.com>
Applied, thanks On 09/09/2021 10:56, Antoine Tenart wrote: > Hi, > > This is a follow-up of [1]. As discussed in the initial thread, the fix > is now split into two commits: the two commits combined are fixing the > issue in a nice way for 5.15, but only the first one is meant to be > applied on stable kernels (to avoid conflicts). > > The issue this is fixing is described in patch 1. Tl;dr: a > suspend/resume cycle can end-up in setting a wrong tcc offset value, > which can lead to machines shutting down because of overheating (when > they should not). > > I've stripped the Acked-by/Tested-by flags from v1 as the patch was > split. But the end result for 5.15+ kernels should be the same. > > Thanks, > Antoine > > [1] https://lore.kernel.org/linux-pm/20210908161632.15520-1-atenart@kernel.org/T/ > > Antoine Tenart (2): > thermal: int340x: do not set a wrong tcc offset on resume > thermal: int340x: improve the tcc offset saving for suspend/resume > > .../intel/int340x_thermal/int3401_thermal.c | 8 +++- > .../processor_thermal_device.c | 39 ++++++++++++++----- > .../processor_thermal_device.h | 1 + > .../processor_thermal_device_pci.c | 18 ++++++++- > .../processor_thermal_device_pci_legacy.c | 8 +++- > 5 files changed, 62 insertions(+), 12 deletions(-) > -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog