| Message ID | 20210913192816.1225025-1-robh@kernel.org |
|---|---|
| Headers | show |
| Series | Arm boards syscon 'unit_address_format' clean-ups | expand |
On Mon, Sep 13, 2021 at 12:28 PM Rob Herring <robh@kernel.org> wrote: > > With all the 'unit_address_format' warnings fixed, enable the warning by > default. > > Cc: Michal Marek <michal.lkml@markovi.net> > Cc: Nick Desaulniers <ndesaulniers@google.com> > Cc: linux-kbuild@vger.kernel.org > Acked-by: Masahiro Yamada <masahiroy@kernel.org> > Signed-off-by: Rob Herring <robh@kernel.org> Acked-by: Nick Desaulniers <ndesaulniers@google.com> > --- > scripts/Makefile.lib | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > index 54582673fc1a..56d50eb0cd80 100644 > --- a/scripts/Makefile.lib > +++ b/scripts/Makefile.lib > @@ -310,7 +310,6 @@ DTC_FLAGS += -Wno-interrupt_provider > # Disable noisy checks by default > ifeq ($(findstring 1,$(KBUILD_EXTRA_WARN)),) > DTC_FLAGS += -Wno-unit_address_vs_reg \ > - -Wno-unit_address_format \ > -Wno-avoid_unnecessary_addr_size \ > -Wno-alias_paths \ > -Wno-graph_child_address \ > -- > 2.30.2 > -- Thanks, ~Nick Desaulniers
Quoting Rob Herring (2021-09-13 12:28:12) > 'reg' is the standard property for defining register banks/addresses. Add > it to use for the VCO register address and deprecate 'vco-offset'. This > will also allow for using standard node names with unit-addresses. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-clk@vger.kernel.org > Cc: Michael Turquette <mturquette@baylibre.com> > Signed-off-by: Rob Herring <robh@kernel.org> > > --- Reviewed-by: Stephen Boyd <sboyd@kernel.org>
On Mon, Sep 13, 2021 at 02:28:08PM -0500, Rob Herring wrote: > This series addresses the last of the dtc 'unit_address_format' > warnings in the tree. > > The remaining issue was dealing with the node names on 2 bindings for > Arm Ltd boards syscon child nodes: register-bit-led and Versatile ICST. > Both of these used an offset property for register address rather than > 'reg' which is the preference nowadays. With a 'reg' property, then we > can have a proper node name and unit-address. This series adds support > for using 'reg' instead and updates the node names and unit-addresses. > > The dts file changes have inter-dependencies, but the clock and led > changes can go via each subsystem. > > Rob > > > Rob Herring (8): > dt-bindings: leds: Convert register-bit-led binding to DT schema > dt-bindings: leds: register-bit-led: Use 'reg' instead of 'offset' > leds: syscon: Support 'reg' in addition to 'offset' for register > address Pavel, Can you apply or comment on patches 1-3? Rob > dt-bindings: clock: arm,syscon-icst: Use 'reg' instead of 'vco-offset' > for VCO register address > clk: versatile: clk-icst: Support 'reg' in addition to 'vco-offset' > for register address > ARM: dts: arm: Update register-bit-led nodes 'reg' and node names > ARM: dts: arm: Update ICST clock nodes 'reg' and node names > kbuild: Enable dtc 'unit_address_format' warning by default
This series addresses the last of the dtc 'unit_address_format' warnings in the tree. The remaining issue was dealing with the node names on 2 bindings for Arm Ltd boards syscon child nodes: register-bit-led and Versatile ICST. Both of these used an offset property for register address rather than 'reg' which is the preference nowadays. With a 'reg' property, then we can have a proper node name and unit-address. This series adds support for using 'reg' instead and updates the node names and unit-addresses. The dts file changes have inter-dependencies, but the clock and led changes can go via each subsystem. Rob Rob Herring (8): dt-bindings: leds: Convert register-bit-led binding to DT schema dt-bindings: leds: register-bit-led: Use 'reg' instead of 'offset' leds: syscon: Support 'reg' in addition to 'offset' for register address dt-bindings: clock: arm,syscon-icst: Use 'reg' instead of 'vco-offset' for VCO register address clk: versatile: clk-icst: Support 'reg' in addition to 'vco-offset' for register address ARM: dts: arm: Update register-bit-led nodes 'reg' and node names ARM: dts: arm: Update ICST clock nodes 'reg' and node names kbuild: Enable dtc 'unit_address_format' warning by default .../bindings/clock/arm,syscon-icst.yaml | 5 + .../bindings/leds/register-bit-led.txt | 94 ------------------ .../bindings/leds/register-bit-led.yaml | 95 +++++++++++++++++++ arch/arm/boot/dts/arm-realview-eb.dtsi | 42 +++++--- arch/arm/boot/dts/arm-realview-pb1176.dts | 42 +++++--- arch/arm/boot/dts/arm-realview-pb11mp.dts | 48 +++++++--- arch/arm/boot/dts/arm-realview-pbx.dtsi | 42 +++++--- arch/arm/boot/dts/integrator.dtsi | 23 +++-- arch/arm/boot/dts/integratorap-im-pd1.dts | 9 +- arch/arm/boot/dts/integratorap.dts | 15 ++- arch/arm/boot/dts/integratorcp.dts | 9 +- arch/arm/boot/dts/mps2.dtsi | 10 +- arch/arm/boot/dts/versatile-ab-ib2.dts | 6 +- arch/arm/boot/dts/versatile-ab.dts | 27 ++++-- arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 27 ++++-- drivers/clk/versatile/clk-icst.c | 3 +- drivers/leds/leds-syscon.c | 3 +- scripts/Makefile.lib | 1 - 18 files changed, 316 insertions(+), 185 deletions(-) delete mode 100644 Documentation/devicetree/bindings/leds/register-bit-led.txt create mode 100644 Documentation/devicetree/bindings/leds/register-bit-led.yaml -- 2.30.2