diff mbox series

ARM: dts: at91: sama5d2_som1_ek: disable ISC node by default

Message ID 20210902121358.503589-1-eugen.hristev@microchip.com
State Accepted
Commit 4348cc10da6377a86940beb20ad357933b8f91bb
Headers show
Series ARM: dts: at91: sama5d2_som1_ek: disable ISC node by default | expand

Commit Message

Eugen Hristev Sept. 2, 2021, 12:13 p.m. UTC
Without a sensor node, the ISC will simply fail to probe, as the
corresponding port node is missing.
It is then logical to disable the node in the devicetree.
If we add a port with a connection to a sensor endpoint, ISC can be enabled.

Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
 arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 1 -
 1 file changed, 1 deletion(-)

Comments

Nicolas Ferre Sept. 14, 2021, 3:03 p.m. UTC | #1
On 02/09/2021 at 14:13, Eugen Hristev wrote:
> Without a sensor node, the ISC will simply fail to probe, as the

> corresponding port node is missing.

> It is then logical to disable the node in the devicetree.

> If we add a port with a connection to a sensor endpoint, ISC can be enabled.

> 

> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>


Makes sense:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>


And queued for at91-fixes in 5.15 as there is no point continuing to 
have a failing probe on this board.

Thanks, best regards,
   Nicolas

> ---

>   arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 1 -

>   1 file changed, 1 deletion(-)

> 

> diff --git a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts

> index 614999dcb990..cd4672501add 100644

> --- a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts

> +++ b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts

> @@ -71,7 +71,6 @@ apb {

>   			isc: isc@f0008000 {

>   				pinctrl-names = "default";

>   				pinctrl-0 = <&pinctrl_isc_base &pinctrl_isc_data_8bit &pinctrl_isc_data_9_10 &pinctrl_isc_data_11_12>;

> -				status = "okay";

>   			};

>   

>   			qspi1: spi@f0024000 {

> 



-- 
Nicolas Ferre
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
index 614999dcb990..cd4672501add 100644
--- a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
+++ b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
@@ -71,7 +71,6 @@  apb {
 			isc: isc@f0008000 {
 				pinctrl-names = "default";
 				pinctrl-0 = <&pinctrl_isc_base &pinctrl_isc_data_8bit &pinctrl_isc_data_9_10 &pinctrl_isc_data_11_12>;
-				status = "okay";
 			};
 
 			qspi1: spi@f0024000 {