diff mbox series

[v2,19/24] clk: mediatek: Add MT8195 vencsys clock support

Message ID 20210820111504.350-20-chun-jie.chen@mediatek.com
State Superseded
Headers show
Series Mediatek MT8195 clock support | expand

Commit Message

Chun-Jie Chen Aug. 20, 2021, 11:14 a.m. UTC
Add MT8195 vencsys clock controller which provide clock gate
control for video encoder.

Signed-off-by: Chun-Jie Chen <chun-jie.chen@mediatek.com>
---
 drivers/clk/mediatek/Makefile          |  2 +-
 drivers/clk/mediatek/clk-mt8195-venc.c | 69 ++++++++++++++++++++++++++
 2 files changed, 70 insertions(+), 1 deletion(-)
 create mode 100644 drivers/clk/mediatek/clk-mt8195-venc.c

Comments

Chen-Yu Tsai Aug. 25, 2021, 11:03 a.m. UTC | #1
On Fri, Aug 20, 2021 at 7:31 PM Chun-Jie Chen
<chun-jie.chen@mediatek.com> wrote:
>

> Add MT8195 vencsys clock controller which provide clock gate

> control for video encoder.

>

> Signed-off-by: Chun-Jie Chen <chun-jie.chen@mediatek.com>

> ---

>  drivers/clk/mediatek/Makefile          |  2 +-

>  drivers/clk/mediatek/clk-mt8195-venc.c | 69 ++++++++++++++++++++++++++

>  2 files changed, 70 insertions(+), 1 deletion(-)

>  create mode 100644 drivers/clk/mediatek/clk-mt8195-venc.c

>

> diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile

> index 3c8c8cdbd3ef..82ffcc4f2c52 100644

> --- a/drivers/clk/mediatek/Makefile

> +++ b/drivers/clk/mediatek/Makefile

> @@ -82,6 +82,6 @@ obj-$(CONFIG_COMMON_CLK_MT8192_VDECSYS) += clk-mt8192-vdec.o

>  obj-$(CONFIG_COMMON_CLK_MT8192_VENCSYS) += clk-mt8192-venc.o

>  obj-$(CONFIG_COMMON_CLK_MT8195) += clk-mt8195-apmixedsys.o clk-mt8195-topckgen.o clk-mt8195-peri_ao.o clk-mt8195-infra_ao.o clk-mt8195-cam.o \

>                                         clk-mt8195-ccu.o clk-mt8195-img.o clk-mt8195-ipe.o clk-mt8195-mfg.o clk-mt8195-scp_adsp.o \

> -                                       clk-mt8195-vdec.o clk-mt8195-vdo0.o clk-mt8195-vdo1.o

> +                                       clk-mt8195-vdec.o clk-mt8195-vdo0.o clk-mt8195-vdo1.o clk-mt8195-venc.o

>  obj-$(CONFIG_COMMON_CLK_MT8516) += clk-mt8516.o

>  obj-$(CONFIG_COMMON_CLK_MT8516_AUDSYS) += clk-mt8516-aud.o

> diff --git a/drivers/clk/mediatek/clk-mt8195-venc.c b/drivers/clk/mediatek/clk-mt8195-venc.c

> new file mode 100644

> index 000000000000..10702a4ad5ff

> --- /dev/null

> +++ b/drivers/clk/mediatek/clk-mt8195-venc.c

> @@ -0,0 +1,69 @@

> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)

> +//

> +// Copyright (c) 2021 MediaTek Inc.

> +// Author: Chun-Jie Chen <chun-jie.chen@mediatek.com>

> +

> +#include "clk-gate.h"

> +#include "clk-mtk.h"

> +

> +#include <dt-bindings/clock/mt8195-clk.h>

> +#include <linux/clk-provider.h>

> +#include <linux/platform_device.h>

> +

> +static const struct mtk_gate_regs venc_cg_regs = {

> +       .set_ofs = 0x4,

> +       .clr_ofs = 0x8,

> +       .sta_ofs = 0x0,

> +};

> +

> +#define GATE_VENC(_id, _name, _parent, _shift)                 \

> +       GATE_MTK(_id, _name, _parent, &venc_cg_regs, _shift, &mtk_clk_gate_ops_setclr_inv)

> +

> +static const struct mtk_gate venc_clks[] = {

> +       GATE_VENC(CLK_VENC_LARB, "venc_larb", "top_venc", 0),

> +       GATE_VENC(CLK_VENC_VENC, "venc_venc", "top_venc", 4),

> +       GATE_VENC(CLK_VENC_JPGENC, "venc_jpgenc", "top_venc", 8),

> +       GATE_VENC(CLK_VENC_JPGDEC, "venc_jpgdec", "top_venc", 12),

> +       GATE_VENC(CLK_VENC_JPGDEC_C1, "venc_jpgdec_c1", "top_venc", 16),

> +       GATE_VENC(CLK_VENC_GALS, "venc_gals", "top_venc", 28),

> +};

> +

> +static const struct mtk_gate venc_core1_clks[] = {

> +       GATE_VENC(CLK_VENC_CORE1_LARB, "venc_core1_larb", "top_venc", 0),

> +       GATE_VENC(CLK_VENC_CORE1_VENC, "venc_core1_venc", "top_venc", 4),

> +       GATE_VENC(CLK_VENC_CORE1_JPGENC, "venc_core1_jpgenc", "top_venc", 8),

> +       GATE_VENC(CLK_VENC_CORE1_JPGDEC, "venc_core1_jpgdec", "top_venc", 12),

> +       GATE_VENC(CLK_VENC_CORE1_JPGDEC_C1, "venc_core1_jpgdec_c1", "top_venc", 16),

> +       GATE_VENC(CLK_VENC_CORE1_GALS, "venc_core1_gals", "top_venc", 28),


The two hardware blocks look the same. Are there any actual differences?
I am somewhat skeptical about using different compatible strings just
to provide different clock names. This is normally handled with
"clock-output-names" properties in the device tree.

ChenYu

> +};

> +

> +static const struct mtk_clk_desc venc_desc = {

> +       .clks = venc_clks,

> +       .num_clks = ARRAY_SIZE(venc_clks),

> +};

> +

> +static const struct mtk_clk_desc venc_core1_desc = {

> +       .clks = venc_core1_clks,

> +       .num_clks = ARRAY_SIZE(venc_core1_clks),

> +};

> +

> +static const struct of_device_id of_match_clk_mt8195_venc[] = {

> +       {

> +               .compatible = "mediatek,mt8195-vencsys",

> +               .data = &venc_desc,

> +       }, {

> +               .compatible = "mediatek,mt8195-vencsys_core1",

> +               .data = &venc_core1_desc,

> +       }, {

> +               /* sentinel */

> +       }

> +};

> +

> +static struct platform_driver clk_mt8195_venc_drv = {

> +       .probe = mtk_clk_simple_probe,

> +       .driver = {

> +               .name = "clk-mt8195-venc",

> +               .of_match_table = of_match_clk_mt8195_venc,

> +       },

> +};

> +builtin_platform_driver(clk_mt8195_venc_drv);

> --

> 2.18.0

> _______________________________________________

> Linux-mediatek mailing list

> Linux-mediatek@lists.infradead.org

> http://lists.infradead.org/mailman/listinfo/linux-mediatek
Chun-Jie Chen Sept. 10, 2021, 11:09 a.m. UTC | #2
On Wed, 2021-08-25 at 19:03 +0800, Chen-Yu Tsai wrote:
> On Fri, Aug 20, 2021 at 7:31 PM Chun-Jie Chen

> <chun-jie.chen@mediatek.com> wrote:

> > 

> > Add MT8195 vencsys clock controller which provide clock gate

> > control for video encoder.

> > 

> > Signed-off-by: Chun-Jie Chen <chun-jie.chen@mediatek.com>

> > ---

> >  drivers/clk/mediatek/Makefile          |  2 +-

> >  drivers/clk/mediatek/clk-mt8195-venc.c | 69

> > ++++++++++++++++++++++++++

> >  2 files changed, 70 insertions(+), 1 deletion(-)

> >  create mode 100644 drivers/clk/mediatek/clk-mt8195-venc.c

> > 

> > diff --git a/drivers/clk/mediatek/Makefile

> > b/drivers/clk/mediatek/Makefile

> > index 3c8c8cdbd3ef..82ffcc4f2c52 100644

> > --- a/drivers/clk/mediatek/Makefile

> > +++ b/drivers/clk/mediatek/Makefile

> > @@ -82,6 +82,6 @@ obj-$(CONFIG_COMMON_CLK_MT8192_VDECSYS) += clk-

> > mt8192-vdec.o

> >  obj-$(CONFIG_COMMON_CLK_MT8192_VENCSYS) += clk-mt8192-venc.o

> >  obj-$(CONFIG_COMMON_CLK_MT8195) += clk-mt8195-apmixedsys.o clk-

> > mt8195-topckgen.o clk-mt8195-peri_ao.o clk-mt8195-infra_ao.o clk-

> > mt8195-cam.o \

> >                                         clk-mt8195-ccu.o clk-

> > mt8195-img.o clk-mt8195-ipe.o clk-mt8195-mfg.o clk-mt8195-

> > scp_adsp.o \

> > -                                       clk-mt8195-vdec.o clk-

> > mt8195-vdo0.o clk-mt8195-vdo1.o

> > +                                       clk-mt8195-vdec.o clk-

> > mt8195-vdo0.o clk-mt8195-vdo1.o clk-mt8195-venc.o

> >  obj-$(CONFIG_COMMON_CLK_MT8516) += clk-mt8516.o

> >  obj-$(CONFIG_COMMON_CLK_MT8516_AUDSYS) += clk-mt8516-aud.o

> > diff --git a/drivers/clk/mediatek/clk-mt8195-venc.c

> > b/drivers/clk/mediatek/clk-mt8195-venc.c

> > new file mode 100644

> > index 000000000000..10702a4ad5ff

> > --- /dev/null

> > +++ b/drivers/clk/mediatek/clk-mt8195-venc.c

> > @@ -0,0 +1,69 @@

> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)

> > +//

> > +// Copyright (c) 2021 MediaTek Inc.

> > +// Author: Chun-Jie Chen <chun-jie.chen@mediatek.com>

> > +

> > +#include "clk-gate.h"

> > +#include "clk-mtk.h"

> > +

> > +#include <dt-bindings/clock/mt8195-clk.h>

> > +#include <linux/clk-provider.h>

> > +#include <linux/platform_device.h>

> > +

> > +static const struct mtk_gate_regs venc_cg_regs = {

> > +       .set_ofs = 0x4,

> > +       .clr_ofs = 0x8,

> > +       .sta_ofs = 0x0,

> > +};

> > +

> > +#define GATE_VENC(_id, _name, _parent, _shift)                 \

> > +       GATE_MTK(_id, _name, _parent, &venc_cg_regs, _shift,

> > &mtk_clk_gate_ops_setclr_inv)

> > +

> > +static const struct mtk_gate venc_clks[] = {

> > +       GATE_VENC(CLK_VENC_LARB, "venc_larb", "top_venc", 0),

> > +       GATE_VENC(CLK_VENC_VENC, "venc_venc", "top_venc", 4),

> > +       GATE_VENC(CLK_VENC_JPGENC, "venc_jpgenc", "top_venc", 8),

> > +       GATE_VENC(CLK_VENC_JPGDEC, "venc_jpgdec", "top_venc", 12),

> > +       GATE_VENC(CLK_VENC_JPGDEC_C1, "venc_jpgdec_c1", "top_venc",

> > 16),

> > +       GATE_VENC(CLK_VENC_GALS, "venc_gals", "top_venc", 28),

> > +};

> > +

> > +static const struct mtk_gate venc_core1_clks[] = {

> > +       GATE_VENC(CLK_VENC_CORE1_LARB, "venc_core1_larb",

> > "top_venc", 0),

> > +       GATE_VENC(CLK_VENC_CORE1_VENC, "venc_core1_venc",

> > "top_venc", 4),

> > +       GATE_VENC(CLK_VENC_CORE1_JPGENC, "venc_core1_jpgenc",

> > "top_venc", 8),

> > +       GATE_VENC(CLK_VENC_CORE1_JPGDEC, "venc_core1_jpgdec",

> > "top_venc", 12),

> > +       GATE_VENC(CLK_VENC_CORE1_JPGDEC_C1, "venc_core1_jpgdec_c1",

> > "top_venc", 16),

> > +       GATE_VENC(CLK_VENC_CORE1_GALS, "venc_core1_gals",

> > "top_venc", 28),

> 

> The two hardware blocks look the same. Are there any actual

> differences?


These two hardware blocks are same, like venc core0 and core1.
Based on performance requirement we can choose to run one core or two
cores.

Thanks!
Best Regards,
Chun-Jie

> I am somewhat skeptical about using different compatible strings just

> to provide different clock names. This is normally handled with

> "clock-output-names" properties in the device tree.

> 

> ChenYu

> 

> > +};

> > +

> > +static const struct mtk_clk_desc venc_desc = {

> > +       .clks = venc_clks,

> > +       .num_clks = ARRAY_SIZE(venc_clks),

> > +};

> > +

> > +static const struct mtk_clk_desc venc_core1_desc = {

> > +       .clks = venc_core1_clks,

> > +       .num_clks = ARRAY_SIZE(venc_core1_clks),

> > +};

> > +

> > +static const struct of_device_id of_match_clk_mt8195_venc[] = {

> > +       {

> > +               .compatible = "mediatek,mt8195-vencsys",

> > +               .data = &venc_desc,

> > +       }, {

> > +               .compatible = "mediatek,mt8195-vencsys_core1",

> > +               .data = &venc_core1_desc,

> > +       }, {

> > +               /* sentinel */

> > +       }

> > +};

> > +

> > +static struct platform_driver clk_mt8195_venc_drv = {

> > +       .probe = mtk_clk_simple_probe,

> > +       .driver = {

> > +               .name = "clk-mt8195-venc",

> > +               .of_match_table = of_match_clk_mt8195_venc,

> > +       },

> > +};

> > +builtin_platform_driver(clk_mt8195_venc_drv);

> > --

> > 2.18.0

> > _______________________________________________

> > Linux-mediatek mailing list

> > Linux-mediatek@lists.infradead.org

> > 

https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!y1_g6m5bndRYKNdAsx1SEqMln7Rc-AmZ63Tn_4fTkT24K04mXhjGMOYcO1ew0k99Y72C$
> >
Chen-Yu Tsai Sept. 14, 2021, 3:47 a.m. UTC | #3
On Fri, Sep 10, 2021 at 7:09 PM Chun-Jie Chen
<chun-jie.chen@mediatek.com> wrote:
>

> On Wed, 2021-08-25 at 19:03 +0800, Chen-Yu Tsai wrote:

> > On Fri, Aug 20, 2021 at 7:31 PM Chun-Jie Chen

> > <chun-jie.chen@mediatek.com> wrote:

> > >

> > > Add MT8195 vencsys clock controller which provide clock gate

> > > control for video encoder.

> > >

> > > Signed-off-by: Chun-Jie Chen <chun-jie.chen@mediatek.com>

> > > ---

> > >  drivers/clk/mediatek/Makefile          |  2 +-

> > >  drivers/clk/mediatek/clk-mt8195-venc.c | 69

> > > ++++++++++++++++++++++++++

> > >  2 files changed, 70 insertions(+), 1 deletion(-)

> > >  create mode 100644 drivers/clk/mediatek/clk-mt8195-venc.c

> > >

> > > diff --git a/drivers/clk/mediatek/Makefile

> > > b/drivers/clk/mediatek/Makefile

> > > index 3c8c8cdbd3ef..82ffcc4f2c52 100644

> > > --- a/drivers/clk/mediatek/Makefile

> > > +++ b/drivers/clk/mediatek/Makefile

> > > @@ -82,6 +82,6 @@ obj-$(CONFIG_COMMON_CLK_MT8192_VDECSYS) += clk-

> > > mt8192-vdec.o

> > >  obj-$(CONFIG_COMMON_CLK_MT8192_VENCSYS) += clk-mt8192-venc.o

> > >  obj-$(CONFIG_COMMON_CLK_MT8195) += clk-mt8195-apmixedsys.o clk-

> > > mt8195-topckgen.o clk-mt8195-peri_ao.o clk-mt8195-infra_ao.o clk-

> > > mt8195-cam.o \

> > >                                         clk-mt8195-ccu.o clk-

> > > mt8195-img.o clk-mt8195-ipe.o clk-mt8195-mfg.o clk-mt8195-

> > > scp_adsp.o \

> > > -                                       clk-mt8195-vdec.o clk-

> > > mt8195-vdo0.o clk-mt8195-vdo1.o

> > > +                                       clk-mt8195-vdec.o clk-

> > > mt8195-vdo0.o clk-mt8195-vdo1.o clk-mt8195-venc.o

> > >  obj-$(CONFIG_COMMON_CLK_MT8516) += clk-mt8516.o

> > >  obj-$(CONFIG_COMMON_CLK_MT8516_AUDSYS) += clk-mt8516-aud.o

> > > diff --git a/drivers/clk/mediatek/clk-mt8195-venc.c

> > > b/drivers/clk/mediatek/clk-mt8195-venc.c

> > > new file mode 100644

> > > index 000000000000..10702a4ad5ff

> > > --- /dev/null

> > > +++ b/drivers/clk/mediatek/clk-mt8195-venc.c

> > > @@ -0,0 +1,69 @@

> > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)

> > > +//

> > > +// Copyright (c) 2021 MediaTek Inc.

> > > +// Author: Chun-Jie Chen <chun-jie.chen@mediatek.com>

> > > +

> > > +#include "clk-gate.h"

> > > +#include "clk-mtk.h"

> > > +

> > > +#include <dt-bindings/clock/mt8195-clk.h>

> > > +#include <linux/clk-provider.h>

> > > +#include <linux/platform_device.h>

> > > +

> > > +static const struct mtk_gate_regs venc_cg_regs = {

> > > +       .set_ofs = 0x4,

> > > +       .clr_ofs = 0x8,

> > > +       .sta_ofs = 0x0,

> > > +};

> > > +

> > > +#define GATE_VENC(_id, _name, _parent, _shift)                 \

> > > +       GATE_MTK(_id, _name, _parent, &venc_cg_regs, _shift,

> > > &mtk_clk_gate_ops_setclr_inv)

> > > +

> > > +static const struct mtk_gate venc_clks[] = {

> > > +       GATE_VENC(CLK_VENC_LARB, "venc_larb", "top_venc", 0),

> > > +       GATE_VENC(CLK_VENC_VENC, "venc_venc", "top_venc", 4),

> > > +       GATE_VENC(CLK_VENC_JPGENC, "venc_jpgenc", "top_venc", 8),

> > > +       GATE_VENC(CLK_VENC_JPGDEC, "venc_jpgdec", "top_venc", 12),

> > > +       GATE_VENC(CLK_VENC_JPGDEC_C1, "venc_jpgdec_c1", "top_venc",

> > > 16),

> > > +       GATE_VENC(CLK_VENC_GALS, "venc_gals", "top_venc", 28),

> > > +};

> > > +

> > > +static const struct mtk_gate venc_core1_clks[] = {

> > > +       GATE_VENC(CLK_VENC_CORE1_LARB, "venc_core1_larb",

> > > "top_venc", 0),

> > > +       GATE_VENC(CLK_VENC_CORE1_VENC, "venc_core1_venc",

> > > "top_venc", 4),

> > > +       GATE_VENC(CLK_VENC_CORE1_JPGENC, "venc_core1_jpgenc",

> > > "top_venc", 8),

> > > +       GATE_VENC(CLK_VENC_CORE1_JPGDEC, "venc_core1_jpgdec",

> > > "top_venc", 12),

> > > +       GATE_VENC(CLK_VENC_CORE1_JPGDEC_C1, "venc_core1_jpgdec_c1",

> > > "top_venc", 16),

> > > +       GATE_VENC(CLK_VENC_CORE1_GALS, "venc_core1_gals",

> > > "top_venc", 28),

> >

> > The two hardware blocks look the same. Are there any actual

> > differences?

>

> These two hardware blocks are same, like venc core0 and core1.

> Based on performance requirement we can choose to run one core or two

> cores.


What I meant was "are these two clock controllers the same"? If so
then we shouldn't be using compatible strings to distinguish them.

ChenYu

> Thanks!

> Best Regards,

> Chun-Jie

>

> > I am somewhat skeptical about using different compatible strings just

> > to provide different clock names. This is normally handled with

> > "clock-output-names" properties in the device tree.

> >

> > ChenYu

> >

> > > +};

> > > +

> > > +static const struct mtk_clk_desc venc_desc = {

> > > +       .clks = venc_clks,

> > > +       .num_clks = ARRAY_SIZE(venc_clks),

> > > +};

> > > +

> > > +static const struct mtk_clk_desc venc_core1_desc = {

> > > +       .clks = venc_core1_clks,

> > > +       .num_clks = ARRAY_SIZE(venc_core1_clks),

> > > +};

> > > +

> > > +static const struct of_device_id of_match_clk_mt8195_venc[] = {

> > > +       {

> > > +               .compatible = "mediatek,mt8195-vencsys",

> > > +               .data = &venc_desc,

> > > +       }, {

> > > +               .compatible = "mediatek,mt8195-vencsys_core1",

> > > +               .data = &venc_core1_desc,

> > > +       }, {

> > > +               /* sentinel */

> > > +       }

> > > +};

> > > +

> > > +static struct platform_driver clk_mt8195_venc_drv = {

> > > +       .probe = mtk_clk_simple_probe,

> > > +       .driver = {

> > > +               .name = "clk-mt8195-venc",

> > > +               .of_match_table = of_match_clk_mt8195_venc,

> > > +       },

> > > +};

> > > +builtin_platform_driver(clk_mt8195_venc_drv);

> > > --

> > > 2.18.0

> > > _______________________________________________

> > > Linux-mediatek mailing list

> > > Linux-mediatek@lists.infradead.org

> > >

> https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!y1_g6m5bndRYKNdAsx1SEqMln7Rc-AmZ63Tn_4fTkT24K04mXhjGMOYcO1ew0k99Y72C$

> > >

>
diff mbox series

Patch

diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile
index 3c8c8cdbd3ef..82ffcc4f2c52 100644
--- a/drivers/clk/mediatek/Makefile
+++ b/drivers/clk/mediatek/Makefile
@@ -82,6 +82,6 @@  obj-$(CONFIG_COMMON_CLK_MT8192_VDECSYS) += clk-mt8192-vdec.o
 obj-$(CONFIG_COMMON_CLK_MT8192_VENCSYS) += clk-mt8192-venc.o
 obj-$(CONFIG_COMMON_CLK_MT8195) += clk-mt8195-apmixedsys.o clk-mt8195-topckgen.o clk-mt8195-peri_ao.o clk-mt8195-infra_ao.o clk-mt8195-cam.o \
 					clk-mt8195-ccu.o clk-mt8195-img.o clk-mt8195-ipe.o clk-mt8195-mfg.o clk-mt8195-scp_adsp.o \
-					clk-mt8195-vdec.o clk-mt8195-vdo0.o clk-mt8195-vdo1.o
+					clk-mt8195-vdec.o clk-mt8195-vdo0.o clk-mt8195-vdo1.o clk-mt8195-venc.o
 obj-$(CONFIG_COMMON_CLK_MT8516) += clk-mt8516.o
 obj-$(CONFIG_COMMON_CLK_MT8516_AUDSYS) += clk-mt8516-aud.o
diff --git a/drivers/clk/mediatek/clk-mt8195-venc.c b/drivers/clk/mediatek/clk-mt8195-venc.c
new file mode 100644
index 000000000000..10702a4ad5ff
--- /dev/null
+++ b/drivers/clk/mediatek/clk-mt8195-venc.c
@@ -0,0 +1,69 @@ 
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Copyright (c) 2021 MediaTek Inc.
+// Author: Chun-Jie Chen <chun-jie.chen@mediatek.com>
+
+#include "clk-gate.h"
+#include "clk-mtk.h"
+
+#include <dt-bindings/clock/mt8195-clk.h>
+#include <linux/clk-provider.h>
+#include <linux/platform_device.h>
+
+static const struct mtk_gate_regs venc_cg_regs = {
+	.set_ofs = 0x4,
+	.clr_ofs = 0x8,
+	.sta_ofs = 0x0,
+};
+
+#define GATE_VENC(_id, _name, _parent, _shift)			\
+	GATE_MTK(_id, _name, _parent, &venc_cg_regs, _shift, &mtk_clk_gate_ops_setclr_inv)
+
+static const struct mtk_gate venc_clks[] = {
+	GATE_VENC(CLK_VENC_LARB, "venc_larb", "top_venc", 0),
+	GATE_VENC(CLK_VENC_VENC, "venc_venc", "top_venc", 4),
+	GATE_VENC(CLK_VENC_JPGENC, "venc_jpgenc", "top_venc", 8),
+	GATE_VENC(CLK_VENC_JPGDEC, "venc_jpgdec", "top_venc", 12),
+	GATE_VENC(CLK_VENC_JPGDEC_C1, "venc_jpgdec_c1", "top_venc", 16),
+	GATE_VENC(CLK_VENC_GALS, "venc_gals", "top_venc", 28),
+};
+
+static const struct mtk_gate venc_core1_clks[] = {
+	GATE_VENC(CLK_VENC_CORE1_LARB, "venc_core1_larb", "top_venc", 0),
+	GATE_VENC(CLK_VENC_CORE1_VENC, "venc_core1_venc", "top_venc", 4),
+	GATE_VENC(CLK_VENC_CORE1_JPGENC, "venc_core1_jpgenc", "top_venc", 8),
+	GATE_VENC(CLK_VENC_CORE1_JPGDEC, "venc_core1_jpgdec", "top_venc", 12),
+	GATE_VENC(CLK_VENC_CORE1_JPGDEC_C1, "venc_core1_jpgdec_c1", "top_venc", 16),
+	GATE_VENC(CLK_VENC_CORE1_GALS, "venc_core1_gals", "top_venc", 28),
+};
+
+static const struct mtk_clk_desc venc_desc = {
+	.clks = venc_clks,
+	.num_clks = ARRAY_SIZE(venc_clks),
+};
+
+static const struct mtk_clk_desc venc_core1_desc = {
+	.clks = venc_core1_clks,
+	.num_clks = ARRAY_SIZE(venc_core1_clks),
+};
+
+static const struct of_device_id of_match_clk_mt8195_venc[] = {
+	{
+		.compatible = "mediatek,mt8195-vencsys",
+		.data = &venc_desc,
+	}, {
+		.compatible = "mediatek,mt8195-vencsys_core1",
+		.data = &venc_core1_desc,
+	}, {
+		/* sentinel */
+	}
+};
+
+static struct platform_driver clk_mt8195_venc_drv = {
+	.probe = mtk_clk_simple_probe,
+	.driver = {
+		.name = "clk-mt8195-venc",
+		.of_match_table = of_match_clk_mt8195_venc,
+	},
+};
+builtin_platform_driver(clk_mt8195_venc_drv);