| Message ID | 20210902220112.55824-1-colin.king@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | [next] media: pvrusb2: add newline between two statements | expand |
On 03/09/2021 00:02, Colin Ian King wrote: > On 02/09/2021 23:01, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> There are two statements on the same line, add a newline to clean >> this up. >> >> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> --- >> drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c >> index d38dee1792e4..ca00b7fe1e7f 100644 >> --- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c >> +++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c >> @@ -1727,7 +1727,8 @@ int pvr2_hdw_set_streaming(struct pvr2_hdw *hdw,int enable_flag) >> enable_flag ? "enable" : "disable"); >> } >> pvr2_hdw_state_sched(hdw); >> - } while (0); LOCK_GIVE(hdw->big_lock); >> + } while (0); >> + LOCK_GIVE(hdw->big_lock); >> if ((ret = pvr2_hdw_wait(hdw,0)) < 0) return ret; >> if (enable_flag) { >> while ((st = hdw->master_state) != PVR2_STATE_RUN) { >> > > ignore, V2 being sent in a moment. I haven't seen a V2 yet... In any case, I've rejected this patch in patchwork. Regards, Hans
On 13/09/2021 12:00, Hans Verkuil wrote: > On 03/09/2021 00:02, Colin Ian King wrote: >> On 02/09/2021 23:01, Colin King wrote: >>> From: Colin Ian King <colin.king@canonical.com> >>> >>> There are two statements on the same line, add a newline to clean >>> this up. >>> >>> Signed-off-by: Colin Ian King <colin.king@canonical.com> >>> --- >>> drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c >>> index d38dee1792e4..ca00b7fe1e7f 100644 >>> --- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c >>> +++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c >>> @@ -1727,7 +1727,8 @@ int pvr2_hdw_set_streaming(struct pvr2_hdw *hdw,int enable_flag) >>> enable_flag ? "enable" : "disable"); >>> } >>> pvr2_hdw_state_sched(hdw); >>> - } while (0); LOCK_GIVE(hdw->big_lock); >>> + } while (0); >>> + LOCK_GIVE(hdw->big_lock); >>> if ((ret = pvr2_hdw_wait(hdw,0)) < 0) return ret; >>> if (enable_flag) { >>> while ((st = hdw->master_state) != PVR2_STATE_RUN) { >>> >> >> ignore, V2 being sent in a moment. > > I haven't seen a V2 yet... In any case, I've rejected this patch in patchwork. After looking at all the unconventional code style issues I chose not to clean this up. > > Regards, > > Hans >
diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c index d38dee1792e4..ca00b7fe1e7f 100644 --- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c +++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c @@ -1727,7 +1727,8 @@ int pvr2_hdw_set_streaming(struct pvr2_hdw *hdw,int enable_flag) enable_flag ? "enable" : "disable"); } pvr2_hdw_state_sched(hdw); - } while (0); LOCK_GIVE(hdw->big_lock); + } while (0); + LOCK_GIVE(hdw->big_lock); if ((ret = pvr2_hdw_wait(hdw,0)) < 0) return ret; if (enable_flag) { while ((st = hdw->master_state) != PVR2_STATE_RUN) {