| Message ID | 1631124057-17155-1-git-send-email-srivasam@codeaurora.org |
|---|---|
| Headers | show |
| Series | Machine driver to support LPASS SC7280 sound card registration | expand |
On Wed, 08 Sep 2021 23:30:56 +0530, Srinivasa Rao Mandadapu wrote: > Add devicetree bindings documentation file for sc7280 sound card > registration. > > Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > --- > .../bindings/sound/google,sc7280-herobrine.yaml | 169 +++++++++++++++++++++ > 1 file changed, 169 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/sound/google,sc7280-herobrine.example.dts:46.24-25 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:379: Documentation/devicetree/bindings/sound/google,sc7280-herobrine.example.dt.yaml] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1438: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1525980 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Thanks for info Rob!!!. This error is due to missing dependency patch.(https://patchwork.kernel.org/project/alsa-devel/list/?series=543829) Could You Please check with the above patch applied? On 9/9/2021 6:02 PM, Rob Herring wrote: > On Wed, 08 Sep 2021 23:30:56 +0530, Srinivasa Rao Mandadapu wrote: >> Add devicetree bindings documentation file for sc7280 sound card >> registration. >> >> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> >> --- >> .../bindings/sound/google,sc7280-herobrine.yaml | 169 +++++++++++++++++++++ >> 1 file changed, 169 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml >> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Error: Documentation/devicetree/bindings/sound/google,sc7280-herobrine.example.dts:46.24-25 syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:379: Documentation/devicetree/bindings/sound/google,sc7280-herobrine.example.dt.yaml] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:1438: dt_binding_check] Error 2 > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/1525980 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. >
On Mon, Sep 13, 2021 at 3:20 AM Srinivasa Rao Mandadapu <srivasam@codeaurora.org> wrote: > > Thanks for info Rob!!!. Don't top-post on maillists. > > This error is due to missing dependency > patch.(https://patchwork.kernel.org/project/alsa-devel/list/?series=543829) > > Could You Please check with the above patch applied? No. How is a script supposed to handle that? Where have you noted the dependency in the patch? Without that, I assume you just didn't run 'make dt_binding_check' and the maintainer doesn't know to check that the dependency is applied. Rob > > > On 9/9/2021 6:02 PM, Rob Herring wrote: > > On Wed, 08 Sep 2021 23:30:56 +0530, Srinivasa Rao Mandadapu wrote: > >> Add devicetree bindings documentation file for sc7280 sound card > >> registration. > >> > >> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > >> --- > >> .../bindings/sound/google,sc7280-herobrine.yaml | 169 +++++++++++++++++++++ > >> 1 file changed, 169 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml > >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > Error: Documentation/devicetree/bindings/sound/google,sc7280-herobrine.example.dts:46.24-25 syntax error > > FATAL ERROR: Unable to parse input tree > > make[1]: *** [scripts/Makefile.lib:379: Documentation/devicetree/bindings/sound/google,sc7280-herobrine.example.dt.yaml] Error 1 > > make[1]: *** Waiting for unfinished jobs.... > > make: *** [Makefile:1438: dt_binding_check] Error 2 > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/patch/1525980 > > > > This check can fail if there are any dependencies. The base for a patch > > series is generally the most recent rc1. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit. > > > -- > Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., > is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. >
On 9/14/2021 6:23 PM, Rob Herring wrote: > On Mon, Sep 13, 2021 at 3:20 AM Srinivasa Rao Mandadapu > <srivasam@codeaurora.org> wrote: >> Thanks for info Rob!!!. > Don't top-post on maillists. Okay. Will take care from Next time. > >> This error is due to missing dependency >> patch.(https://patchwork.kernel.org/project/alsa-devel/list/?series=543829) >> >> Could You Please check with the above patch applied? > No. How is a script supposed to handle that? > > Where have you noted the dependency in the patch? Without that, I > assume you just didn't run 'make dt_binding_check' and the maintainer > doesn't know to check that the dependency is applied. > > Rob Included dependency list in cover letter. Will include in this patch next time. >> >> On 9/9/2021 6:02 PM, Rob Herring wrote: >>> On Wed, 08 Sep 2021 23:30:56 +0530, Srinivasa Rao Mandadapu wrote: >>>> Add devicetree bindings documentation file for sc7280 sound card >>>> registration. >>>> >>>> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> >>>> --- >>>> .../bindings/sound/google,sc7280-herobrine.yaml | 169 +++++++++++++++++++++ >>>> 1 file changed, 169 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml >>>> >>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >>> on your patch (DT_CHECKER_FLAGS is new in v5.13): >>> >>> yamllint warnings/errors: >>> >>> dtschema/dtc warnings/errors: >>> Error: Documentation/devicetree/bindings/sound/google,sc7280-herobrine.example.dts:46.24-25 syntax error >>> FATAL ERROR: Unable to parse input tree >>> make[1]: *** [scripts/Makefile.lib:379: Documentation/devicetree/bindings/sound/google,sc7280-herobrine.example.dt.yaml] Error 1 >>> make[1]: *** Waiting for unfinished jobs.... >>> make: *** [Makefile:1438: dt_binding_check] Error 2 >>> >>> doc reference errors (make refcheckdocs): >>> >>> See https://patchwork.ozlabs.org/patch/1525980 >>> >>> This check can fail if there are any dependencies. The base for a patch >>> series is generally the most recent rc1. >>> >>> If you already ran 'make dt_binding_check' and didn't see the above >>> error(s), then make sure 'yamllint' is installed and dt-schema is up to >>> date: >>> >>> pip3 install dtschema --upgrade >>> >>> Please check and re-submit. >>> >> -- >> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., >> is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. >> -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.