| Message ID | 20210903155201.3004567-1-robh@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | kbuild: Enable DT schema checks for %.dtb targets | expand |
On Sat, Sep 4, 2021 at 12:52 AM Rob Herring <robh@kernel.org> wrote: > > It is possible to build a single dtb, but not with DT schema validation > enabled. Enable the schema validation to run for %.dtb targets. Anyone > building a dtb for a specific platform *should* pay attention to schema > warnings. > > This could be supported with a separate %.dt.yaml target instead. > However, the .dt.yaml format is considered an intermediate format and > could possibly go away at some point if schema checking is integrated > into dtc. Also, the plan is to enable the schema checks by default once > platforms are free of warnings, and this is a move in that direction. > > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Tom Rini <trini@konsulko.com> > Cc: Masahiro Yamada <masahiroy@kernel.org> > Cc: linux-kbuild@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Makefile b/Makefile > index ec9e8a0fe298..01b888cfe1dc 100644 > --- a/Makefile > +++ b/Makefile > @@ -1399,8 +1399,8 @@ endif > > ifneq ($(dtstree),) > > -%.dtb: include/config/kernel.release scripts_dtc > - $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@ > +%.dtb: dt_binding_check include/config/kernel.release scripts_dtc > + $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@ $(dtstree)/$*.dt.yaml > > %.dtbo: include/config/kernel.release scripts_dtc > $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@ Why didn't you change the %.dtbo part? > @@ -1409,7 +1409,7 @@ PHONY += dtbs dtbs_install dtbs_check > dtbs: include/config/kernel.release scripts_dtc > $(Q)$(MAKE) $(build)=$(dtstree) > > -ifneq ($(filter dtbs_check, $(MAKECMDGOALS)),) > +ifneq ($(filter dtbs_check %.dtb, $(MAKECMDGOALS)),) > export CHECK_DTBS=y > dtbs: dt_binding_check > endif > -- > 2.30.2 > -- Best Regards Masahiro Yamada
On Thu, Sep 9, 2021 at 8:05 AM Masahiro Yamada <masahiroy@kernel.org> wrote: > > On Sat, Sep 4, 2021 at 12:52 AM Rob Herring <robh@kernel.org> wrote: > > > > It is possible to build a single dtb, but not with DT schema validation > > enabled. Enable the schema validation to run for %.dtb targets. Anyone > > building a dtb for a specific platform *should* pay attention to schema > > warnings. > > > > This could be supported with a separate %.dt.yaml target instead. > > However, the .dt.yaml format is considered an intermediate format and > > could possibly go away at some point if schema checking is integrated > > into dtc. Also, the plan is to enable the schema checks by default once > > platforms are free of warnings, and this is a move in that direction. > > > > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Cc: Tom Rini <trini@konsulko.com> > > Cc: Masahiro Yamada <masahiroy@kernel.org> > > Cc: linux-kbuild@vger.kernel.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > Makefile | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/Makefile b/Makefile > > index ec9e8a0fe298..01b888cfe1dc 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -1399,8 +1399,8 @@ endif > > > > ifneq ($(dtstree),) > > > > -%.dtb: include/config/kernel.release scripts_dtc > > - $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@ > > +%.dtb: dt_binding_check include/config/kernel.release scripts_dtc > > + $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@ $(dtstree)/$*.dt.yaml > > > > %.dtbo: include/config/kernel.release scripts_dtc > > $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@ > > > Why didn't you change the %.dtbo part? Right, it should. Rob
diff --git a/Makefile b/Makefile index ec9e8a0fe298..01b888cfe1dc 100644 --- a/Makefile +++ b/Makefile @@ -1399,8 +1399,8 @@ endif ifneq ($(dtstree),) -%.dtb: include/config/kernel.release scripts_dtc - $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@ +%.dtb: dt_binding_check include/config/kernel.release scripts_dtc + $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@ $(dtstree)/$*.dt.yaml %.dtbo: include/config/kernel.release scripts_dtc $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@ @@ -1409,7 +1409,7 @@ PHONY += dtbs dtbs_install dtbs_check dtbs: include/config/kernel.release scripts_dtc $(Q)$(MAKE) $(build)=$(dtstree) -ifneq ($(filter dtbs_check, $(MAKECMDGOALS)),) +ifneq ($(filter dtbs_check %.dtb, $(MAKECMDGOALS)),) export CHECK_DTBS=y dtbs: dt_binding_check endif
It is possible to build a single dtb, but not with DT schema validation enabled. Enable the schema validation to run for %.dtb targets. Anyone building a dtb for a specific platform *should* pay attention to schema warnings. This could be supported with a separate %.dt.yaml target instead. However, the .dt.yaml format is considered an intermediate format and could possibly go away at some point if schema checking is integrated into dtc. Also, the plan is to enable the schema checks by default once platforms are free of warnings, and this is a move in that direction. Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Tom Rini <trini@konsulko.com> Cc: Masahiro Yamada <masahiroy@kernel.org> Cc: linux-kbuild@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.30.2