| Message ID | 20210830180758.251390-1-mike.rudenko@gmail.com |
|---|---|
| Headers | show |
| Series | phy: phy-rockchip-dphy-rx0: add support for tx1rx1 rx mode | expand |
Hi Mikhail, Some comments below. Have a look if it is useful. On 8/30/21 8:07 PM, Mikhail Rudenko wrote: > RK3399 TX1RX1 D-PHY is not a child of GRF and uses reg, thus add > corresponding properties conditionally. It also requires DSI clock to > operate, so check for it. Since we now support both rx0 and tx1rx1, > rename the schema to rockchip-mipi-dphy-rx.yaml. > > Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com> > --- > ...hy-rx0.yaml => rockchip-mipi-dphy-rx.yaml} | 39 +++++++++++++++++-- > 1 file changed, 35 insertions(+), 4 deletions(-) > rename Documentation/devicetree/bindings/phy/{rockchip-mipi-dphy-rx0.yaml => rockchip-mipi-dphy-rx.yaml} (65%) > > diff --git a/Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml b/Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx.yaml > similarity index 65% > rename from Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml > rename to Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx.yaml > index 7d888d358823..f42319448fc9 100644 > --- a/Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml > +++ b/Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx.yaml > @@ -1,10 +1,10 @@ > # SPDX-License-Identifier: (GPL-2.0+ OR MIT) > %YAML 1.2 > --- > -$id: http://devicetree.org/schemas/phy/rockchip-mipi-dphy-rx0.yaml# > +$id: http://devicetree.org/schemas/phy/rockchip-mipi-dphy-rx.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Rockchip SoC MIPI RX0 D-PHY Device Tree Bindings > +title: Rockchip SoC MIPI RX0/TX1RX1 D-PHY Device Tree Bindings > > maintainers: > - Helen Koike <helen.koike@collabora.com> > @@ -16,19 +16,28 @@ description: | > > properties: > compatible: > - const: rockchip,rk3399-mipi-dphy-rx0 > + enum: > + - rockchip,rk3399-mipi-dphy-rx0 > + - rockchip,rk3399-mipi-dphy-tx1rx1 > + > + reg: > + maxItems: 1 This allows every node to have a reg property. > > clocks: > + minItems: 3 > items: > - description: MIPI D-PHY ref clock > - - description: MIPI D-PHY RX0 cfg clock > + - description: MIPI D-PHY RX0/TX1RX1 cfg clock > - description: Video in/out general register file clock > + - description: MIPI D-PHY DSI clock > > clock-names: > + minItems: 3 > items: > - const: dphy-ref > - const: dphy-cfg > - const: grf > + - const: dsi > > '#phy-cells': > const: 0 > @@ -37,6 +46,12 @@ properties: > description: Video in/out power domain. > maxItems: 1 > > + rockchip,grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + The phandle of the syscon node for the general register file > + (GRF), required for TX1RX1 MIPI D-PHY on RK3399. This allows every node to have a rockchip,grf property. > + > required: > - compatible > - clocks > @@ -44,6 +59,22 @@ required: > - '#phy-cells' > - power-domains > > +if: > + properties: > + compatible: > + contains: > + const: rockchip,rk3399-mipi-dphy-tx1rx1 > +then: > + required: Move/swap the properties section above the required section. > + - reg > + - rockchip,grf > + > + properties: reg: maxItems: 1 > + clocks: > + minItems: 4 > + clock-names: > + minItems: 4 rockchip,grf: $ref: /schemas/types.yaml#/definitions/phandle description: The phandle of the syscon node for the general register file(GRF). ", required for TX1RX1 MIPI D-PHY on RK3399." This phrase is already said/done with the "required:" section above > additionalProperties: false > > examples: >
Hi Mikhail, The file in the link below is in need for a YAML conversion. Could you help? Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt - compatible: one of "rockchip,px30-mipi-dsi", "snps,dw-mipi-dsi" "rockchip,rk3288-mipi-dsi", "snps,dw-mipi-dsi" "rockchip,rk3399-mipi-dsi", "snps,dw-mipi-dsi" On 8/30/21 11:00 PM, Johan Jonker wrote: > Some comments below. Have a look if it is useful. >
On Mon, 30 Aug 2021 21:07:53 +0300, Mikhail Rudenko wrote: > RK3399 TX1RX1 D-PHY is not a child of GRF and uses reg, thus add > corresponding properties conditionally. It also requires DSI clock to > operate, so check for it. Since we now support both rx0 and tx1rx1, > rename the schema to rockchip-mipi-dphy-rx.yaml. > > Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com> > --- > ...hy-rx0.yaml => rockchip-mipi-dphy-rx.yaml} | 39 +++++++++++++++++-- > 1 file changed, 35 insertions(+), 4 deletions(-) > rename Documentation/devicetree/bindings/phy/{rockchip-mipi-dphy-rx0.yaml => rockchip-mipi-dphy-rx.yaml} (65%) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/dist-packages/dtschema/schemas/phy/rockchip-mipi-dphy-rx0.yaml' xargs: dt-doc-validate: exited with status 255; aborting make[1]: *** Deleting file 'Documentation/devicetree/bindings/soc/rockchip/grf.example.dt.yaml' Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/dist-packages/dtschema/schemas/phy/rockchip-mipi-dphy-rx0.yaml' make[1]: *** [scripts/Makefile.lib:380: Documentation/devicetree/bindings/soc/rockchip/grf.example.dt.yaml] Error 255 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1419: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1522296 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Hi all, thank you for reviewing this and sorry for me failing my prior research and overlooking existing Heiko's solution [1] [2]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=71f68fe7f12182ed968cfbbd1ef018721e4dee30 [2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=68e0277204c733dff19073686e2ac48239b06fbc -- Regards, Mikhail
Implement support for RX mode of TX1RX1 D-PHY on RK3399. Code is based on Rockchip BSP kernel branch 4.4. These patches have been tested on FriendlyElec NanoPi M4 with OmniVision 4689-based sensor. Mikhail Rudenko (5): phy: phy-rockchip-dphy-rx0: refactor for tx1rx1 addition phy: phy-rockchip-dphy-rx0: add support for tx1rx1 in receive mode phy: rename phy-rockchip-dphy-rx0 to phy-rockchip-dphy-rx dt-bindings: phy: phy-rockchip-dphy-rx0: add support for tx1rx1 phy arm64: dts: rockchip: add mipi-dphy-tx1rx1 for rk3399 ...hy-rx0.yaml => rockchip-mipi-dphy-rx.yaml} | 39 ++- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 15 ++ drivers/phy/rockchip/Kconfig | 8 +- drivers/phy/rockchip/Makefile | 2 +- ...chip-dphy-rx0.c => phy-rockchip-dphy-rx.c} | 231 +++++++++++++++--- 5 files changed, 252 insertions(+), 43 deletions(-) rename Documentation/devicetree/bindings/phy/{rockchip-mipi-dphy-rx0.yaml => rockchip-mipi-dphy-rx.yaml} (65%) rename drivers/phy/rockchip/{phy-rockchip-dphy-rx0.c => phy-rockchip-dphy-rx.c} (63%) -- 2.33.0