diff mbox series

[v2,1/5] ARM: dts: NSP: Add bcm958623hr board name to dts

Message ID 20210829223752.2748091-1-mnhagan88@gmail.com
State Accepted
Commit 695717eb4c61173d05a277e37132b5e2c6531bf1
Headers show
Series [v2,1/5] ARM: dts: NSP: Add bcm958623hr board name to dts | expand

Commit Message

Matthew Hagan Aug. 29, 2021, 10:37 p.m. UTC
This board was previously added to
Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml
however the dts file was not updated to reflect this change. This patch
corrects bcm958623hr.dts by adding the board name to the compatible.

Signed-off-by: Matthew Hagan <mnhagan88@gmail.com>
---
 arch/arm/boot/dts/bcm958623hr.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Lunn Aug. 30, 2021, 12:27 a.m. UTC | #1
On Sun, Aug 29, 2021 at 10:37:49PM +0000, Matthew Hagan wrote:
> While functional, the mdio-mux-mmioreg binding does not conform to

> Documentation/devicetree/bindings/net/mdio-mux-mmioreg.yaml in that an

> mdio-mux compatible is also required. Without this the following output

> is observed when running dtbs_check:

> 

> mdio-mux@32000: compatible: ['mdio-mux-mmioreg'] is too short

> 

> This change brings conformance to this requirement and corresponds

> likewise to Rafal Milecki's change to the BCM5301x platform[1].

> 

> [1] https://lore.kernel.org/linux-arm-kernel/20210822191256.3715003-1-f.fainelli@gmail.com/T/

> 

> Signed-off-by: Matthew Hagan <mnhagan88@gmail.com>


Thanks for the expanded commit message.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>


    Andrew
Florian Fainelli Sept. 2, 2021, 9:04 p.m. UTC | #2
On Sun, 29 Aug 2021 22:37:47 +0000, Matthew Hagan <mnhagan88@gmail.com> wrote:
> This board was previously added to

> Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml

> however the dts file was not updated to reflect this change. This patch

> corrects bcm958623hr.dts by adding the board name to the compatible.

> 

> Signed-off-by: Matthew Hagan <mnhagan88@gmail.com>

> ---


Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/bcm958623hr.dts b/arch/arm/boot/dts/bcm958623hr.dts
index 80556882951f..c06871915a1c 100644
--- a/arch/arm/boot/dts/bcm958623hr.dts
+++ b/arch/arm/boot/dts/bcm958623hr.dts
@@ -37,7 +37,7 @@ 
 
 / {
 	model = "NorthStar Plus SVK (BCM958623HR)";
-	compatible = "brcm,bcm58623", "brcm,nsp";
+	compatible = "brcm,bcm958623hr", "brcm,bcm58623", "brcm,nsp";
 
 	chosen {
 		stdout-path = "serial0:115200n8";