| Message ID | 20210819125018.8577-1-colin.king@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | rsi: make array fsm_state static const, makes object smaller | expand |
On Thu, 2021-08-19 at 13:50 +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Don't populate the array fsm_state on the stack but instead it > static const. Makes the object code smaller by 154 bytes: [] > diff --git a/drivers/net/wireless/rsi/rsi_91x_debugfs.c b/drivers/net/wireless/rsi/rsi_91x_debugfs.c [] > @@ -117,7 +117,7 @@ static int rsi_stats_read(struct seq_file *seq, void *data) > { > struct rsi_common *common = seq->private; > > - unsigned char fsm_state[][32] = { > + static const unsigned char fsm_state[][32] = { why not the even smaller with a defconfig static const char * const fsm_state[] = { > "FSM_FW_NOT_LOADED", > "FSM_CARD_NOT_READY", > "FSM_COMMON_DEV_PARAMS_SENT",
Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > Don't populate the array fsm_state on the stack but instead it > static const. Makes the object code smaller by 154 bytes: > > Before: > text data bss dec hex filename > 9213 3904 0 13117 333d .../wireless/rsi/rsi_91x_debugfs.o > > After: > text data bss dec hex filename > 8995 3968 0 12963 32a3 .../wireless/rsi/rsi_91x_debugfs.o > > (gcc version 10.3.0) > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Patch applied to wireless-drivers-next.git, thanks. f4c813641897 rsi: make array fsm_state static const, makes object smaller -- https://patchwork.kernel.org/project/linux-wireless/patch/20210819125018.8577-1-colin.king@canonical.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
diff --git a/drivers/net/wireless/rsi/rsi_91x_debugfs.c b/drivers/net/wireless/rsi/rsi_91x_debugfs.c index 24a417ea2ae7..f404ca4c38e8 100644 --- a/drivers/net/wireless/rsi/rsi_91x_debugfs.c +++ b/drivers/net/wireless/rsi/rsi_91x_debugfs.c @@ -117,7 +117,7 @@ static int rsi_stats_read(struct seq_file *seq, void *data) { struct rsi_common *common = seq->private; - unsigned char fsm_state[][32] = { + static const unsigned char fsm_state[][32] = { "FSM_FW_NOT_LOADED", "FSM_CARD_NOT_READY", "FSM_COMMON_DEV_PARAMS_SENT",