mbox series

[v2,0/2] Kconfig symbol fixes on powerpc

Message ID 20210819113954.17515-1-lukas.bulwahn@gmail.com
Headers show
Series Kconfig symbol fixes on powerpc | expand

Message

Lukas Bulwahn Aug. 19, 2021, 11:39 a.m. UTC 
Dear powerpc maintainers,

The script ./scripts/checkkconfigsymbols.py warns on invalid references to
Kconfig symbols (often, minor typos, name confusions or outdated references).

This patch series addresses all issues reported by
./scripts/checkkconfigsymbols.py in ./drivers/usb/ for Kconfig and Makefile
files. Issues in the Kconfig and Makefile files indicate some shortcomings in
the overall build definitions, and often are true actionable issues to address.

These issues can be identified and filtered by:

  ./scripts/checkkconfigsymbols.py | grep -E "arch/powerpc/.*(Kconfig|Makefile)" -B 1 -A 1

After applying this patch series on linux-next (next-20210817), the command
above yields just two false positives (SHELL, r13) due to tool shortcomings.

As these two patches are fixes, please consider if they are suitable for
backporting to stable.

v1 -> v2:
  Followed Christophe Leroy's comment and drop the obsolete select.


Lukas

Lukas Bulwahn (2):
  powerpc: kvm: remove obsolete and unneeded select
  powerpc: rectify selection to ARCH_ENABLE_SPLIT_PMD_PTLOCK

 arch/powerpc/kvm/Kconfig               | 1 -
 arch/powerpc/platforms/Kconfig.cputype | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

Comments

Daniel Axtens Aug. 19, 2021, 10:39 p.m. UTC | #1 
Hi Lukas,

> diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
> index e45644657d49..ff581d70f20c 100644
> --- a/arch/powerpc/kvm/Kconfig
> +++ b/arch/powerpc/kvm/Kconfig
> @@ -38,7 +38,6 @@ config KVM_BOOK3S_32_HANDLER
>  config KVM_BOOK3S_64_HANDLER
>  	bool
>  	select KVM_BOOK3S_HANDLER
> -	select PPC_DAWR_FORCE_ENABLE

I looked at some of the history here. It looks like this select was left
over from an earlier version of the patch series that added PPC_DAWR: v2
of the series has a new symbol PPC_DAWR_FORCE_ENABLE but by version 4
that new symbol had disappeared but the select had not.

v2: https://lore.kernel.org/linuxppc-dev/20190513071703.25243-1-mikey@neuling.org/
v5: https://lore.kernel.org/linuxppc-dev/20190604030037.9424-2-mikey@neuling.org/

The rest of the patch reasoning makes sense to me: DAWR support will be
selected anyway by virtue of PPC64->PPC_DAWR so there's no need to try
to select it again anyway.

Reviewed-by: Daniel Axtens <dja@axtens.net>

Kind regards,
Daniel

>  
>  config KVM_BOOK3S_PR_POSSIBLE
>  	bool
> -- 
> 2.26.2
Michael Ellerman Aug. 27, 2021, 1:15 p.m. UTC | #2 
On Thu, 19 Aug 2021 13:39:52 +0200, Lukas Bulwahn wrote:
> The script ./scripts/checkkconfigsymbols.py warns on invalid references to

> Kconfig symbols (often, minor typos, name confusions or outdated references).

> 

> This patch series addresses all issues reported by

> ./scripts/checkkconfigsymbols.py in ./drivers/usb/ for Kconfig and Makefile

> files. Issues in the Kconfig and Makefile files indicate some shortcomings in

> the overall build definitions, and often are true actionable issues to address.

> 

> [...]


Patch 1 applied to powerpc/next.

[1/2] powerpc: kvm: remove obsolete and unneeded select
      https://git.kernel.org/powerpc/c/c26d4c5d4f0df7207da3975458261927f9305465

cheers
Michael Ellerman Aug. 27, 2021, 1:28 p.m. UTC | #3 
On Thu, 19 Aug 2021 13:39:52 +0200, Lukas Bulwahn wrote:
> The script ./scripts/checkkconfigsymbols.py warns on invalid references to

> Kconfig symbols (often, minor typos, name confusions or outdated references).

> 

> This patch series addresses all issues reported by

> ./scripts/checkkconfigsymbols.py in ./drivers/usb/ for Kconfig and Makefile

> files. Issues in the Kconfig and Makefile files indicate some shortcomings in

> the overall build definitions, and often are true actionable issues to address.

> 

> [...]


Patch 2 applied to powerpc/fixes.

[2/2] powerpc: rectify selection to ARCH_ENABLE_SPLIT_PMD_PTLOCK
      https://git.kernel.org/powerpc/c/310d2e83cb9b7f1e7232319880e3fcb57592fa10

cheers