mbox series

[v2,0/3] kselftests: clean configs

Message ID 20210826015847.7416-1-lizhijian@cn.fujitsu.com
Headers show
Series kselftests: clean configs | expand

Message

Li Zhijian Aug. 26, 2021, 1:58 a.m. UTC 
0Day will check if all configs listing under selftests are able to be enabled properly.

For the missing configs, it will report something like:
LKP WARN miss config CONFIG_SYNC= of sync/config

CC: kernel test robot <lkp@intel.com>
CC: "Jason A. Donenfeld" <Jason@zx2c4.com>
CC: Nick Desaulniers <ndesaulniers@google.com>
CC: Masahiro Yamada <masahiroy@kernel.org>
CC: wireguard@lists.zx2c4.com
CC: netdev@vger.kernel.org

CC: "Rafael J. Wysocki" <rjw@rjwysocki.net>
CC: Viresh Kumar <viresh.kumar@linaro.org>
CC: linux-pm@vger.kernel.org
Reported-by: kernel test robot <lkp@intel.com>

Li Zhijian (3):
  selftests/sync: Remove the deprecated config SYNC
  selftests/cpufreq: Rename DEBUG_PI_LIST to DEBUG_PLIST
  selftests/wireguard: Rename DEBUG_PI_LIST to DEBUG_PLIST

 tools/testing/selftests/cpufreq/config              | 2 +-
 tools/testing/selftests/sync/config                 | 1 -
 tools/testing/selftests/wireguard/qemu/debug.config | 2 +-
 3 files changed, 2 insertions(+), 3 deletions(-)

Comments

Shuah Khan Aug. 26, 2021, 9:10 p.m. UTC | #1 
On 8/25/21 7:58 PM, Li Zhijian wrote:
> SYNC was removed since aff9da10e21 ("staging/android: make sync_timeline internal to sw_sync")
> LKP/0Day will check if all configs listing under selftests are able to be enabled properly.
> 

Can you please state what you arr fxing and also keep the sentences
75 chars or less.

Where is LKP warning? Include the warning and explain why this
change is necessary.

> For the missing configs, it will report something like:
> LKP WARN miss config CONFIG_SYNC= of sync/config
> 
> CC: Philip Li <philip.li@intel.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> ---

thanks,
-- Shuah
Zhijian Li (Fujitsu) Aug. 27, 2021, 1:35 a.m. UTC | #2 
On 27/08/2021 05:10, Shuah Khan wrote:
> On 8/25/21 7:58 PM, Li Zhijian wrote:

>> SYNC was removed since aff9da10e21 ("staging/android: make sync_timeline internal to sw_sync")

>> LKP/0Day will check if all configs listing under selftests are able to be enabled properly.

>>

>

> Can you please state what you arr fxing and also keep the sentences

> 75 chars or less.

>

> Where is LKP warning? 

https://01.org/lkp
LKP(aka. 0Day) often reports issue related to the *recent* kernel commits/WIP patches publicly.
As the LKP keeping improvement, it will cover more aspects in the kernel so that more issues will be detected.

So in this case, which is related to too old kernel, it just reported it internally.


> Include the warning and explain why this

> change is necessary.

- it's not reasonable to keep the deprecated configs, right ?

- In my understanding, configs under kselftests are recommended by corresponding tests.
So if some configs are missing, it will impact the testing results

Do you mean the commit log should include above 2 reasons ?

Thanks

>

>> For the missing configs, it will report something like:

>> LKP WARN miss config CONFIG_SYNC= of sync/config

>>

>> CC: Philip Li <philip.li@intel.com>

>> Reported-by: kernel test robot <lkp@intel.com>

>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>

>> ---

>

> thanks,

> -- Shuah

>

>
Shuah Khan Aug. 27, 2021, 5 p.m. UTC | #3 
On 8/26/21 7:35 PM, lizhijian@fujitsu.com wrote:
> 

> 

> On 27/08/2021 05:10, Shuah Khan wrote:

>> On 8/25/21 7:58 PM, Li Zhijian wrote:

>>> SYNC was removed since aff9da10e21 ("staging/android: make sync_timeline internal to sw_sync")

>>> LKP/0Day will check if all configs listing under selftests are able to be enabled properly.

>>>

>>

>> Can you please state what you arr fxing and also keep the sentences

>> 75 chars or less.

>>

>> Where is LKP warning?

> https://01.org/lkp

> LKP(aka. 0Day) often reports issue related to the *recent* kernel commits/WIP patches publicly.

> As the LKP keeping improvement, it will cover more aspects in the kernel so that more issues will be detected.

> 

> So in this case, which is related to too old kernel, it just reported it internally.

> 

> 

>> Include the warning and explain why this

>> change is necessary.

> - it's not reasonable to keep the deprecated configs, right ?

> 

> - In my understanding, configs under kselftests are recommended by corresponding tests.

> So if some configs are missing, it will impact the testing results

> 

> Do you mean the commit log should include above 2 reasons ?

> 


Correct. I am asking the commit log to include these details.

thanks,
-- Shuah