| Message ID | 20210817211803.283639-8-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | target/riscv: Use tcg_constant_* | expand |
On Wed, Aug 18, 2021 at 5:23 AM Richard Henderson <richard.henderson@linaro.org> wrote: > > Split out gen_mulh and gen_mulhu and use the common helper. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/riscv/insn_trans/trans_rvm.c.inc | 40 +++++++++++-------------- > 1 file changed, 18 insertions(+), 22 deletions(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On Wed, Aug 18, 2021 at 7:23 AM Richard Henderson <richard.henderson@linaro.org> wrote: > > Split out gen_mulh and gen_mulhu and use the common helper. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > target/riscv/insn_trans/trans_rvm.c.inc | 40 +++++++++++-------------- > 1 file changed, 18 insertions(+), 22 deletions(-) > > diff --git a/target/riscv/insn_trans/trans_rvm.c.inc b/target/riscv/insn_trans/trans_rvm.c.inc > index 3d93b24c25..80552be7a3 100644 > --- a/target/riscv/insn_trans/trans_rvm.c.inc > +++ b/target/riscv/insn_trans/trans_rvm.c.inc > @@ -25,20 +25,18 @@ static bool trans_mul(DisasContext *ctx, arg_mul *a) > return gen_arith(ctx, a, EXT_NONE, tcg_gen_mul_tl); > } > > +static void gen_mulh(TCGv ret, TCGv s1, TCGv s2) > +{ > + TCGv discard = tcg_temp_new(); > + > + tcg_gen_muls2_tl(discard, ret, s1, s2); > + tcg_temp_free(discard); > +} > + > static bool trans_mulh(DisasContext *ctx, arg_mulh *a) > { > REQUIRE_EXT(ctx, RVM); > - TCGv source1 = tcg_temp_new(); > - TCGv source2 = tcg_temp_new(); > - gen_get_gpr(ctx, source1, a->rs1); > - gen_get_gpr(ctx, source2, a->rs2); > - > - tcg_gen_muls2_tl(source2, source1, source1, source2); > - > - gen_set_gpr(ctx, a->rd, source1); > - tcg_temp_free(source1); > - tcg_temp_free(source2); > - return true; > + return gen_arith(ctx, a, EXT_NONE, gen_mulh); > } > > static bool trans_mulhsu(DisasContext *ctx, arg_mulhsu *a) > @@ -47,20 +45,18 @@ static bool trans_mulhsu(DisasContext *ctx, arg_mulhsu *a) > return gen_arith(ctx, a, EXT_NONE, gen_mulhsu); > } > > +static void gen_mulhu(TCGv ret, TCGv s1, TCGv s2) > +{ > + TCGv discard = tcg_temp_new(); > + > + tcg_gen_mulu2_tl(discard, ret, s1, s2); > + tcg_temp_free(discard); > +} > + > static bool trans_mulhu(DisasContext *ctx, arg_mulhu *a) > { > REQUIRE_EXT(ctx, RVM); > - TCGv source1 = tcg_temp_new(); > - TCGv source2 = tcg_temp_new(); > - gen_get_gpr(ctx, source1, a->rs1); > - gen_get_gpr(ctx, source2, a->rs2); > - > - tcg_gen_mulu2_tl(source2, source1, source1, source2); > - > - gen_set_gpr(ctx, a->rd, source1); > - tcg_temp_free(source1); > - tcg_temp_free(source2); > - return true; > + return gen_arith(ctx, a, EXT_NONE, gen_mulhu); > } > > static bool trans_div(DisasContext *ctx, arg_div *a) > -- > 2.25.1 > >
diff --git a/target/riscv/insn_trans/trans_rvm.c.inc b/target/riscv/insn_trans/trans_rvm.c.inc index 3d93b24c25..80552be7a3 100644 --- a/target/riscv/insn_trans/trans_rvm.c.inc +++ b/target/riscv/insn_trans/trans_rvm.c.inc @@ -25,20 +25,18 @@ static bool trans_mul(DisasContext *ctx, arg_mul *a) return gen_arith(ctx, a, EXT_NONE, tcg_gen_mul_tl); } +static void gen_mulh(TCGv ret, TCGv s1, TCGv s2) +{ + TCGv discard = tcg_temp_new(); + + tcg_gen_muls2_tl(discard, ret, s1, s2); + tcg_temp_free(discard); +} + static bool trans_mulh(DisasContext *ctx, arg_mulh *a) { REQUIRE_EXT(ctx, RVM); - TCGv source1 = tcg_temp_new(); - TCGv source2 = tcg_temp_new(); - gen_get_gpr(ctx, source1, a->rs1); - gen_get_gpr(ctx, source2, a->rs2); - - tcg_gen_muls2_tl(source2, source1, source1, source2); - - gen_set_gpr(ctx, a->rd, source1); - tcg_temp_free(source1); - tcg_temp_free(source2); - return true; + return gen_arith(ctx, a, EXT_NONE, gen_mulh); } static bool trans_mulhsu(DisasContext *ctx, arg_mulhsu *a) @@ -47,20 +45,18 @@ static bool trans_mulhsu(DisasContext *ctx, arg_mulhsu *a) return gen_arith(ctx, a, EXT_NONE, gen_mulhsu); } +static void gen_mulhu(TCGv ret, TCGv s1, TCGv s2) +{ + TCGv discard = tcg_temp_new(); + + tcg_gen_mulu2_tl(discard, ret, s1, s2); + tcg_temp_free(discard); +} + static bool trans_mulhu(DisasContext *ctx, arg_mulhu *a) { REQUIRE_EXT(ctx, RVM); - TCGv source1 = tcg_temp_new(); - TCGv source2 = tcg_temp_new(); - gen_get_gpr(ctx, source1, a->rs1); - gen_get_gpr(ctx, source2, a->rs2); - - tcg_gen_mulu2_tl(source2, source1, source1, source2); - - gen_set_gpr(ctx, a->rd, source1); - tcg_temp_free(source1); - tcg_temp_free(source2); - return true; + return gen_arith(ctx, a, EXT_NONE, gen_mulhu); } static bool trans_div(DisasContext *ctx, arg_div *a)
Split out gen_mulh and gen_mulhu and use the common helper. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/riscv/insn_trans/trans_rvm.c.inc | 40 +++++++++++-------------- 1 file changed, 18 insertions(+), 22 deletions(-) -- 2.25.1