diff mbox series

[-next] spi: tegra20-slink: remove spi_master_put() in tegra_slink_remove()

Message ID 20210810142230.2220453-1-yangyingliang@huawei.com
State Accepted
Commit 02cea7039ad52593ee05824c19233366914df9b2
Headers show
Series [-next] spi: tegra20-slink: remove spi_master_put() in tegra_slink_remove() | expand

Commit Message

Yang Yingliang Aug. 10, 2021, 2:22 p.m. UTC
spi_master_put() is already called in spi_unregister_master(), or it
will lead a double decrement refcount.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/spi/spi-tegra20-slink.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Mark Brown Aug. 18, 2021, 4:26 p.m. UTC | #1
On Tue, 10 Aug 2021 22:22:30 +0800, Yang Yingliang wrote:
> spi_master_put() is already called in spi_unregister_master(), or it

> will lead a double decrement refcount.

> 

> 

> 

> 


Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: tegra20-slink: remove spi_master_put() in tegra_slink_remove()
      commit: 02cea7039ad52593ee05824c19233366914df9b2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
index deff16ba6d58..ebd27f883033 100644
--- a/drivers/spi/spi-tegra20-slink.c
+++ b/drivers/spi/spi-tegra20-slink.c
@@ -1154,8 +1154,6 @@  static int tegra_slink_remove(struct platform_device *pdev)
 	if (tspi->rx_dma_chan)
 		tegra_slink_deinit_dma_param(tspi, true);
 
-	spi_master_put(master);
-
 	return 0;
 }