diff mbox series

[v2,15/55] target/sparc: Remove DEBUG_UNALIGNED

Message ID 20210803041443.55452-16-richard.henderson@linaro.org
State Superseded
Headers show
Series Unaligned access for user-only | expand

Commit Message

Richard Henderson Aug. 3, 2021, 4:14 a.m. UTC 
The printf should have been qemu_log_mask, the parameters
themselves no longer compile, and because this is placed
before unwinding the PC is actively wrong.

We get better (and correct) logging on the other side of
raising the exception, in sparc_cpu_do_interrupt.

Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 target/sparc/ldst_helper.c | 9 ---------
 1 file changed, 9 deletions(-)

-- 
2.25.1

Comments

Mark Cave-Ayland Aug. 18, 2021, 8:36 a.m. UTC | #1 
On 03/08/2021 05:14, Richard Henderson wrote:

> The printf should have been qemu_log_mask, the parameters

> themselves no longer compile, and because this is placed

> before unwinding the PC is actively wrong.

> 

> We get better (and correct) logging on the other side of

> raising the exception, in sparc_cpu_do_interrupt.

> 

> Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> ---

>   target/sparc/ldst_helper.c | 9 ---------

>   1 file changed, 9 deletions(-)

> 

> diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c

> index 22327d7d72..974afea041 100644

> --- a/target/sparc/ldst_helper.c

> +++ b/target/sparc/ldst_helper.c

> @@ -27,7 +27,6 @@

>   

>   //#define DEBUG_MMU

>   //#define DEBUG_MXCC

> -//#define DEBUG_UNALIGNED

>   //#define DEBUG_UNASSIGNED

>   //#define DEBUG_ASI

>   //#define DEBUG_CACHE_CONTROL

> @@ -364,10 +363,6 @@ static void do_check_align(CPUSPARCState *env, target_ulong addr,

>                              uint32_t align, uintptr_t ra)

>   {

>       if (addr & align) {

> -#ifdef DEBUG_UNALIGNED

> -        printf("Unaligned access to 0x" TARGET_FMT_lx " from 0x" TARGET_FMT_lx

> -               "\n", addr, env->pc);

> -#endif

>           cpu_raise_exception_ra(env, TT_UNALIGNED, ra);

>       }

>   }

> @@ -1968,10 +1963,6 @@ void QEMU_NORETURN sparc_cpu_do_unaligned_access(CPUState *cs, vaddr addr,

>       SPARCCPU *cpu = SPARC_CPU(cs);

>       CPUSPARCState *env = &cpu->env;

>   

> -#ifdef DEBUG_UNALIGNED

> -    printf("Unaligned access to 0x" TARGET_FMT_lx " from 0x" TARGET_FMT_lx

> -           "\n", addr, env->pc);

> -#endif

>       cpu_raise_exception_ra(env, TT_UNALIGNED, retaddr);

>   }

>   #endif


Indeed. I suspect that this was originally intended for developers to capture that an 
unaligned access occurred rather than processing it correctly.

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>



ATB,

Mark.
diff mbox series

Patch

diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c
index 22327d7d72..974afea041 100644
--- a/target/sparc/ldst_helper.c
+++ b/target/sparc/ldst_helper.c
@@ -27,7 +27,6 @@ 
 
 //#define DEBUG_MMU
 //#define DEBUG_MXCC
-//#define DEBUG_UNALIGNED
 //#define DEBUG_UNASSIGNED
 //#define DEBUG_ASI
 //#define DEBUG_CACHE_CONTROL
@@ -364,10 +363,6 @@  static void do_check_align(CPUSPARCState *env, target_ulong addr,
                            uint32_t align, uintptr_t ra)
 {
     if (addr & align) {
-#ifdef DEBUG_UNALIGNED
-        printf("Unaligned access to 0x" TARGET_FMT_lx " from 0x" TARGET_FMT_lx
-               "\n", addr, env->pc);
-#endif
         cpu_raise_exception_ra(env, TT_UNALIGNED, ra);
     }
 }
@@ -1968,10 +1963,6 @@  void QEMU_NORETURN sparc_cpu_do_unaligned_access(CPUState *cs, vaddr addr,
     SPARCCPU *cpu = SPARC_CPU(cs);
     CPUSPARCState *env = &cpu->env;
 
-#ifdef DEBUG_UNALIGNED
-    printf("Unaligned access to 0x" TARGET_FMT_lx " from 0x" TARGET_FMT_lx
-           "\n", addr, env->pc);
-#endif
     cpu_raise_exception_ra(env, TT_UNALIGNED, retaddr);
 }
 #endif