mbox series

[V4,0/8] Introduce an attribute to choose timing setting

Message ID 1626517079-9057-1-git-send-email-kewei.xu@mediatek.com
Headers show
Series Introduce an attribute to choose timing setting | expand

Message

Kewei Xu July 17, 2021, 10:17 a.m. UTC
v4:
1. Remove the repeated assignment of the inter_clk_div parameter
2. Modify the wrong assignment of OFFSET_MULTI_DMA
3. Unify the log print format of the i2c_dump_register() and drop the extra outer parentheses
4. Place the fixes at the very least
5. Add fixed tags 25708278f810 ("i2c: mediatek: Add i2c support for MediaTek MT8183")
6. Add "i2c: mediatek: modify bus speed calculation formula"
7. Fix single line characters exceeding 80 characters
8. Combine two different series of patches.

v3:
1. Fix code errors caused by v2 modification

v2:
1. Add "dt-bindings: i2c: add attribute default-timing-adjust"
2. Split the fix into sepatate patch.

Kewei Xu (8):
  i2c: mediatek: fixing the incorrect register offset
  dt-bindings: i2c: update bindings for MT8195 SoC
  i2c: mediatek: Reset the handshake signal between i2c and dma
  i2c: mediatek: Dump i2c/dma register when a timeout occurs
  dt-bindings: i2c: add attribute default-timing-adjust
  i2c: mediatek: Add OFFSET_EXT_CONF setting back
  i2c: mediatek: Isolate speed setting via dts for special devices
  i2c: mediatek: modify bus speed calculation formula

 .../devicetree/bindings/i2c/i2c-mt65xx.txt    |   3 +
 drivers/i2c/busses/i2c-mt65xx.c               | 194 ++++++++++++++++--
 2 files changed, 180 insertions(+), 17 deletions(-)

Comments

Rob Herring (Arm) July 22, 2021, 3:10 a.m. UTC | #1
On Sat, Jul 17, 2021 at 06:17:56PM +0800, Kewei Xu wrote:
> Add attribute default-timing-adjust for DT-binding document.
> 
> Fixes: be5ce0e97cc7 ("i2c: mediatek: Add i2c ac-timing adjust support")
> Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
> ---
>  Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> index 7c4915bc4439..7b80a11d4d4c 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> @@ -33,6 +33,8 @@ Optional properties:
>    - mediatek,have-pmic: platform can control i2c form special pmic side.
>      Only mt6589 and mt8135 support this feature.
>    - mediatek,use-push-pull: IO config use push-pull mode.
> +  - mediatek,default-timing-adjust: use default timing calculation, no timing
> +    adjustment.

'mediatek,use-default-timing' perhaps as it means don't adjust anything.

>  
>  Example:
>  
> -- 
> 2.18.0
> 
>
Kewei Xu Aug. 18, 2021, 6:37 a.m. UTC | #2
On Wed, 2021-07-21 at 21:10 -0600, Rob Herring wrote:
> On Sat, Jul 17, 2021 at 06:17:56PM +0800, Kewei Xu wrote:

> > Add attribute default-timing-adjust for DT-binding document.

> > 

> > Fixes: be5ce0e97cc7 ("i2c: mediatek: Add i2c ac-timing adjust

> > support")

> > Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>

> > ---

> >  Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 2 ++

> >  1 file changed, 2 insertions(+)

> > 

> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt

> > b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt

> > index 7c4915bc4439..7b80a11d4d4c 100644

> > --- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt

> > +++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt

> > @@ -33,6 +33,8 @@ Optional properties:

> >    - mediatek,have-pmic: platform can control i2c form special pmic

> > side.

> >      Only mt6589 and mt8135 support this feature.

> >    - mediatek,use-push-pull: IO config use push-pull mode.

> > +  - mediatek,default-timing-adjust: use default timing

> > calculation, no timing

> > +    adjustment.

> 

> 'mediatek,use-default-timing' perhaps as it means don't adjust

> anything.

> 

> >  

> >  Example:

> >  

> > -- 

> > 2.18.0

> > 

Hi Rob,

Thanks for your suggestion. We will use "mediatek,use-default-timing"
instead of "mediatek,default-timing-adjust" in the next version of
patch.

Thanks
kewei