| Message ID | 20210812165218.2508258-3-angus@akkea.ca |
|---|---|
| State | Accepted |
| Commit | 192aa65ac00ce0bc70c3f271cf3ee030acc0655a |
| Headers | show |
| Series | [v3,1/2] brcmfmac: add 43752 SDIO ids and initialization | expand |
Hi Angus, > Bluetooth on the BCM43752 needs a patchram file to function correctly. > > Signed-off-by: Angus Ainslie <angus@akkea.ca> > --- > drivers/bluetooth/btbcm.c | 1 + > 1 file changed, 1 insertion(+) patch has been applied to bluetooth-next tree. Regards Marcel
On 8/12/2021 6:52 PM, Angus Ainslie wrote: > Bluetooth on the BCM43752 needs a patchram file to function correctly. > > Signed-off-by: Angus Ainslie <angus@akkea.ca> > --- > drivers/bluetooth/btbcm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c > index e5d706ed55ea..e4182acee488 100644 > --- a/drivers/bluetooth/btbcm.c > +++ b/drivers/bluetooth/btbcm.c > @@ -387,6 +387,7 @@ struct bcm_subver_table { > }; > > static const struct bcm_subver_table bcm_uart_subver_table[] = { > + { 0x1111, "BCM4362A2" }, /* 000.017.017 */ Noticed Marcel applied this one already, but as I asked in earlier patch I would like to know why the commit message says 43752 but this entry says 4362? Still confused. Regards, Arend
Hi Arend, >> Bluetooth on the BCM43752 needs a patchram file to function correctly. >> Signed-off-by: Angus Ainslie <angus@akkea.ca> >> --- >> drivers/bluetooth/btbcm.c | 1 + >> 1 file changed, 1 insertion(+) >> diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c >> index e5d706ed55ea..e4182acee488 100644 >> --- a/drivers/bluetooth/btbcm.c >> +++ b/drivers/bluetooth/btbcm.c >> @@ -387,6 +387,7 @@ struct bcm_subver_table { >> }; >> static const struct bcm_subver_table bcm_uart_subver_table[] = { >> + { 0x1111, "BCM4362A2" }, /* 000.017.017 */ > > Noticed Marcel applied this one already, but as I asked in earlier patch I would like to know why the commit message says 43752 but this entry says 4362? Still confused. seems I missed that part. Can you look internally what this hardware is and we fix it? Regards Marcel
On August 19, 2021 5:26:42 PM Marcel Holtmann <marcel@holtmann.org> wrote: > Hi Arend, > >>> Bluetooth on the BCM43752 needs a patchram file to function correctly. >>> Signed-off-by: Angus Ainslie <angus@akkea.ca> >>> --- >>> drivers/bluetooth/btbcm.c | 1 + >>> 1 file changed, 1 insertion(+) >>> diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c >>> index e5d706ed55ea..e4182acee488 100644 >>> --- a/drivers/bluetooth/btbcm.c >>> +++ b/drivers/bluetooth/btbcm.c >>> @@ -387,6 +387,7 @@ struct bcm_subver_table { >>> }; >>> static const struct bcm_subver_table bcm_uart_subver_table[] = { >>> + { 0x1111, "BCM4362A2" }, /* 000.017.017 */ >> >> Noticed Marcel applied this one already, but as I asked in earlier patch I >> would like to know why the commit message says 43752 but this entry says >> 4362? Still confused. > > seems I missed that part. Can you look internally what this hardware is and > we fix it? I will check although not internally as this is probably a Cypress chipset. Anyway, I will follow up on this. Regards, Arend
diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c index e5d706ed55ea..e4182acee488 100644 --- a/drivers/bluetooth/btbcm.c +++ b/drivers/bluetooth/btbcm.c @@ -387,6 +387,7 @@ struct bcm_subver_table { }; static const struct bcm_subver_table bcm_uart_subver_table[] = { + { 0x1111, "BCM4362A2" }, /* 000.017.017 */ { 0x4103, "BCM4330B1" }, /* 002.001.003 */ { 0x410d, "BCM4334B0" }, /* 002.001.013 */ { 0x410e, "BCM43341B0" }, /* 002.001.014 */
Bluetooth on the BCM43752 needs a patchram file to function correctly. Signed-off-by: Angus Ainslie <angus@akkea.ca> --- drivers/bluetooth/btbcm.c | 1 + 1 file changed, 1 insertion(+)