diff mbox series

i2c: at91: mark PM ops as __maybe unused

Message ID 20210811131002.2201-1-wsa@kernel.org
State Accepted
Commit a2c21668a0fe6640bd6b3069bb569e3b201ef92d
Headers show
Series i2c: at91: mark PM ops as __maybe unused | expand

Commit Message

Wolfram Sang Aug. 11, 2021, 1:10 p.m. UTC
The driver uses pm_ptr(), so the PM ops could be unused.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: dab4b0e8c9a5 ("i2c: at91: remove #define CONFIG_PM")
Signed-off-by: Wolfram Sang <wsa@kernel.org>
---
 drivers/i2c/busses/i2c-at91-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Codrin Ciubotariu Aug. 11, 2021, 1:22 p.m. UTC | #1
On 11.08.2021 16:10, Wolfram Sang wrote:
> The driver uses pm_ptr(), so the PM ops could be unused.

> 

> Reported-by: kernel test robot <lkp@intel.com>

> Fixes: dab4b0e8c9a5 ("i2c: at91: remove #define CONFIG_PM")

> Signed-off-by: Wolfram Sang <wsa@kernel.org>


Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>


Thanks!
Wolfram Sang Aug. 11, 2021, 1:54 p.m. UTC | #2
On Wed, Aug 11, 2021 at 03:10:02PM +0200, Wolfram Sang wrote:
> The driver uses pm_ptr(), so the PM ops could be unused.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: dab4b0e8c9a5 ("i2c: at91: remove #define CONFIG_PM")
> Signed-off-by: Wolfram Sang <wsa@kernel.org>

Applied to for-next, thanks!
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-at91-core.c b/drivers/i2c/busses/i2c-at91-core.c
index 9f3c3e8e8011..2df9df585131 100644
--- a/drivers/i2c/busses/i2c-at91-core.c
+++ b/drivers/i2c/busses/i2c-at91-core.c
@@ -333,7 +333,7 @@  static int __maybe_unused at91_twi_resume_noirq(struct device *dev)
 	return 0;
 }
 
-static const struct dev_pm_ops at91_twi_pm = {
+static const struct dev_pm_ops __maybe_unused at91_twi_pm = {
 	.suspend_noirq	= at91_twi_suspend_noirq,
 	.resume_noirq	= at91_twi_resume_noirq,
 	.runtime_suspend	= at91_twi_runtime_suspend,