diff mbox series

[27/38] padata: Replace deprecated CPU-hotplug functions.

Message ID 20210803141621.780504-28-bigeasy@linutronix.de
State Accepted
Commit 80771c8228029daff4b3402e00883cde06e07d46
Headers show
Series Replace deprecated CPU-hotplug | expand

Commit Message

Sebastian Andrzej Siewior Aug. 3, 2021, 2:16 p.m. UTC
The functions get_online_cpus() and put_online_cpus() have been
deprecated during the CPU hotplug rework. They map directly to
cpus_read_lock() and cpus_read_unlock().

Replace deprecated CPU-hotplug functions with the official version.
The behavior remains unchanged.

Cc: Steffen Klassert <steffen.klassert@secunet.com>
Cc: Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 kernel/padata.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Comments

Daniel Jordan Aug. 4, 2021, 2:52 p.m. UTC | #1
On Tue, Aug 03, 2021 at 04:16:10PM +0200, Sebastian Andrzej Siewior wrote:
> The functions get_online_cpus() and put_online_cpus() have been

> deprecated during the CPU hotplug rework. They map directly to

> cpus_read_lock() and cpus_read_unlock().

> 

> Replace deprecated CPU-hotplug functions with the official version.

> The behavior remains unchanged.

> 

> Cc: Steffen Klassert <steffen.klassert@secunet.com>

> Cc: Daniel Jordan <daniel.m.jordan@oracle.com>

> Cc: linux-crypto@vger.kernel.org

> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>


Satisfying to see the old wrappers finally go away.

Acked-by: Daniel Jordan <daniel.m.jordan@oracle.com>
Herbert Xu Aug. 12, 2021, 11:36 a.m. UTC | #2
On Tue, Aug 03, 2021 at 02:16:10PM +0000, Sebastian Andrzej Siewior wrote:
> The functions get_online_cpus() and put_online_cpus() have been

> deprecated during the CPU hotplug rework. They map directly to

> cpus_read_lock() and cpus_read_unlock().

> 

> Replace deprecated CPU-hotplug functions with the official version.

> The behavior remains unchanged.

> 

> Cc: Steffen Klassert <steffen.klassert@secunet.com>

> Cc: Daniel Jordan <daniel.m.jordan@oracle.com>

> Cc: linux-crypto@vger.kernel.org

> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

> ---

>  kernel/padata.c | 14 +++++++-------

>  1 file changed, 7 insertions(+), 7 deletions(-)


Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
diff mbox series

Patch

diff --git a/kernel/padata.c b/kernel/padata.c
index d4d3ba6e1728a..0b0b6e8917d10 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -733,7 +733,7 @@  int padata_set_cpumask(struct padata_instance *pinst, int cpumask_type,
 	struct cpumask *serial_mask, *parallel_mask;
 	int err = -EINVAL;
 
-	get_online_cpus();
+	cpus_read_lock();
 	mutex_lock(&pinst->lock);
 
 	switch (cpumask_type) {
@@ -753,7 +753,7 @@  int padata_set_cpumask(struct padata_instance *pinst, int cpumask_type,
 
 out:
 	mutex_unlock(&pinst->lock);
-	put_online_cpus();
+	cpus_read_unlock();
 
 	return err;
 }
@@ -992,7 +992,7 @@  struct padata_instance *padata_alloc(const char *name)
 	if (!pinst->parallel_wq)
 		goto err_free_inst;
 
-	get_online_cpus();
+	cpus_read_lock();
 
 	pinst->serial_wq = alloc_workqueue("%s_serial", WQ_MEM_RECLAIM |
 					   WQ_CPU_INTENSIVE, 1, name);
@@ -1026,7 +1026,7 @@  struct padata_instance *padata_alloc(const char *name)
 						    &pinst->cpu_dead_node);
 #endif
 
-	put_online_cpus();
+	cpus_read_unlock();
 
 	return pinst;
 
@@ -1036,7 +1036,7 @@  struct padata_instance *padata_alloc(const char *name)
 err_free_serial_wq:
 	destroy_workqueue(pinst->serial_wq);
 err_put_cpus:
-	put_online_cpus();
+	cpus_read_unlock();
 	destroy_workqueue(pinst->parallel_wq);
 err_free_inst:
 	kfree(pinst);
@@ -1074,9 +1074,9 @@  struct padata_shell *padata_alloc_shell(struct padata_instance *pinst)
 
 	ps->pinst = pinst;
 
-	get_online_cpus();
+	cpus_read_lock();
 	pd = padata_alloc_pd(ps);
-	put_online_cpus();
+	cpus_read_unlock();
 
 	if (!pd)
 		goto out_free_ps;