mbox series

[PATCH/RFC,0/4] dt-bindings: i2c: renesas,riic: Add interrupt-names

Message ID cover.1626267422.git.geert+renesas@glider.be
Headers show
Series dt-bindings: i2c: renesas,riic: Add interrupt-names | expand

Message

Geert Uytterhoeven July 14, 2021, 1:19 p.m. UTC 
Hi all,

The Renesas RZ/A and RZ/G2L I2C Bus Interface has no less than 8
interrupts.  So I think it makes sense to use "interrupt-names"
property, to make it easier to review the interrupt mappings in DTS
files.

Hence this series documents the "interrupt-names" property in the DT
bindings, adds the property to the DTS files, and marks it required in
the DT bindings. Obviously the last step cannot be applied until all
earlier patches are upstream.

What do you think?
Thanks for your comments!

Geert Uytterhoeven (4):
  dt-bindings: i2c: renesas,riic: Add interrupt-names
  ARM: dts: rza: Add I2C interrupt-names
  arm64: dts: renesas: r9a07g044: Add I2C interrupt-names
  dt-bindings: i2c: renesas,riic: Make interrupt-names required

 .../devicetree/bindings/i2c/renesas,riic.yaml | 30 ++++++++++++++-----
 arch/arm/boot/dts/r7s72100.dtsi               |  8 +++++
 arch/arm/boot/dts/r7s9210.dtsi                |  8 +++++
 arch/arm64/boot/dts/renesas/r9a07g044.dtsi    |  8 +++++
 4 files changed, 46 insertions(+), 8 deletions(-)

Comments

Wolfram Sang Aug. 11, 2021, 2:23 p.m. UTC | #1 
Hi Geert,

> The Renesas RZ/A and RZ/G2L I2C Bus Interface has no less than 8

> interrupts.  So I think it makes sense to use "interrupt-names"

> property, to make it easier to review the interrupt mappings in DTS

> files.

> 

> Hence this series documents the "interrupt-names" property in the DT

> bindings, adds the property to the DTS files, and marks it required in

> the DT bindings. Obviously the last step cannot be applied until all

> earlier patches are upstream.

> 

> What do you think?


I like it and I'd think it is good to go. It is probably easiest if you
take the series via your tree to avoid merge conflicts and/or subsystem
dependencies. It's unlikely the YAML file will see further updates. So,
for the series:

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


Let me know if you think another way is better.

Happy hacking,

   Wolfram
Geert Uytterhoeven Aug. 11, 2021, 3:29 p.m. UTC | #2 
Hi Wolfram,

On Wed, Aug 11, 2021 at 4:23 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> > The Renesas RZ/A and RZ/G2L I2C Bus Interface has no less than 8
> > interrupts.  So I think it makes sense to use "interrupt-names"
> > property, to make it easier to review the interrupt mappings in DTS
> > files.
> >
> > Hence this series documents the "interrupt-names" property in the DT
> > bindings, adds the property to the DTS files, and marks it required in
> > the DT bindings. Obviously the last step cannot be applied until all
> > earlier patches are upstream.
> >
> > What do you think?
>
> I like it and I'd think it is good to go. It is probably easiest if you
> take the series via your tree to avoid merge conflicts and/or subsystem
> dependencies. It's unlikely the YAML file will see further updates. So,
> for the series:

Probably it is not worth doing this in lockstep (1/4 in v5.15 through
i2c, 2/4 and 3/4 in v5.16 through renesas-devel, and 4/4 in v5.17
through i2c).
I have different branches for DT binding and DTS, but I guess it
doesn't hurt to deviate and apply both to renesas-arm-dt-for-v5.15...

> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thanks!

Gr{oetje,eeting}s,

                        Geert
Wolfram Sang Aug. 11, 2021, 7:04 p.m. UTC | #3 
Hi Geert,

> Probably it is not worth doing this in lockstep (1/4 in v5.15 through
> i2c, 2/4 and 3/4 in v5.16 through renesas-devel, and 4/4 in v5.17
> through i2c).

I agree!

> I have different branches for DT binding and DTS, but I guess it
> doesn't hurt to deviate and apply both to renesas-arm-dt-for-v5.15...

Sounds good, thanks!

All the best,

   Wolfram