diff mbox series

[1/2] pinctrl: pmic-mpp: Add missing dt-bindings mpp function defs

Message ID 20210225213605.117201-1-konrad.dybcio@somainline.org
State New
Headers show
Series [1/2] pinctrl: pmic-mpp: Add missing dt-bindings mpp function defs | expand

Commit Message

Konrad Dybcio Feb. 25, 2021, 9:36 p.m. UTC
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>

The pinctrl-spmi-mpp driver supports setting more mpp functions
than the ones defined in the dt-bindings header, specifically,
digital, analog and sink.

To follow the current way of specifying the function config
in Device-Tree, add the missing three definitions in the
appropriate dt-bindings header as:
GPIO_MPP_FUNC_{DIGITAL,ANALOG,SINK}.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
---
 include/dt-bindings/pinctrl/qcom,pmic-mpp.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rob Herring (Arm) March 6, 2021, 9:21 p.m. UTC | #1
On Thu, 25 Feb 2021 22:36:04 +0100, Konrad Dybcio wrote:
> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> 
> The pinctrl-spmi-mpp driver supports setting more mpp functions
> than the ones defined in the dt-bindings header, specifically,
> digital, analog and sink.
> 
> To follow the current way of specifying the function config
> in Device-Tree, add the missing three definitions in the
> appropriate dt-bindings header as:
> GPIO_MPP_FUNC_{DIGITAL,ANALOG,SINK}.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
>  include/dt-bindings/pinctrl/qcom,pmic-mpp.h | 3 +++
>  1 file changed, 3 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Rob Herring (Arm) March 6, 2021, 9:21 p.m. UTC | #2
On Thu, 25 Feb 2021 22:36:05 +0100, Konrad Dybcio wrote:
> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> 
> Some SoCs do have a USB DP/DM ADC at 0x43, 0x44.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
>  include/dt-bindings/iio/qcom,spmi-vadc.h | 3 +++
>  1 file changed, 3 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Bjorn Andersson March 11, 2021, 12:03 a.m. UTC | #3
On Thu 25 Feb 15:36 CST 2021, Konrad Dybcio wrote:

> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>

> 

> The pinctrl-spmi-mpp driver supports setting more mpp functions

> than the ones defined in the dt-bindings header, specifically,

> digital, analog and sink.

> 

> To follow the current way of specifying the function config

> in Device-Tree, add the missing three definitions in the

> appropriate dt-bindings header as:

> GPIO_MPP_FUNC_{DIGITAL,ANALOG,SINK}.

> 


Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>


> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>

> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>

> ---

>  include/dt-bindings/pinctrl/qcom,pmic-mpp.h | 3 +++

>  1 file changed, 3 insertions(+)

> 

> diff --git a/include/dt-bindings/pinctrl/qcom,pmic-mpp.h b/include/dt-bindings/pinctrl/qcom,pmic-mpp.h

> index 32e66ee7e830..3cdca7ee1b3f 100644

> --- a/include/dt-bindings/pinctrl/qcom,pmic-mpp.h

> +++ b/include/dt-bindings/pinctrl/qcom,pmic-mpp.h

> @@ -98,6 +98,9 @@

>  /* To be used with "function" */

>  #define PMIC_MPP_FUNC_NORMAL		"normal"

>  #define PMIC_MPP_FUNC_PAIRED		"paired"

> +#define PMIC_MPP_FUNC_DIGITAL		"digital"

> +#define PMIC_MPP_FUNC_ANALOG		"analog"

> +#define PMIC_MPP_FUNC_SINK		"sink"

>  #define PMIC_MPP_FUNC_DTEST1		"dtest1"

>  #define PMIC_MPP_FUNC_DTEST2		"dtest2"

>  #define PMIC_MPP_FUNC_DTEST3		"dtest3"

> -- 

> 2.30.1

>
Bjorn Andersson Aug. 3, 2021, 11:30 p.m. UTC | #4
On Thu 25 Feb 15:36 CST 2021, Konrad Dybcio wrote:

> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> 
> The pinctrl-spmi-mpp driver supports setting more mpp functions
> than the ones defined in the dt-bindings header, specifically,
> digital, analog and sink.
> 
> To follow the current way of specifying the function config
> in Device-Tree, add the missing three definitions in the
> appropriate dt-bindings header as:
> GPIO_MPP_FUNC_{DIGITAL,ANALOG,SINK}.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>

I noticed that this has not been picked up yet.

As changes to these files typically goes through the respective
maintainer's tree I think it would be good if you pick up the acks and
resend them.

Also patch 1 and 2 has no real relationship, and per above request would
be picked by two different maintainers, so please post them separately
instead.

PS. I merged the Tone dts using the strings instead of the defines
(which I still prefer over using these defines).

Regards,
Bjorn

> ---
>  include/dt-bindings/pinctrl/qcom,pmic-mpp.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/dt-bindings/pinctrl/qcom,pmic-mpp.h b/include/dt-bindings/pinctrl/qcom,pmic-mpp.h
> index 32e66ee7e830..3cdca7ee1b3f 100644
> --- a/include/dt-bindings/pinctrl/qcom,pmic-mpp.h
> +++ b/include/dt-bindings/pinctrl/qcom,pmic-mpp.h
> @@ -98,6 +98,9 @@
>  /* To be used with "function" */
>  #define PMIC_MPP_FUNC_NORMAL		"normal"
>  #define PMIC_MPP_FUNC_PAIRED		"paired"
> +#define PMIC_MPP_FUNC_DIGITAL		"digital"
> +#define PMIC_MPP_FUNC_ANALOG		"analog"
> +#define PMIC_MPP_FUNC_SINK		"sink"
>  #define PMIC_MPP_FUNC_DTEST1		"dtest1"
>  #define PMIC_MPP_FUNC_DTEST2		"dtest2"
>  #define PMIC_MPP_FUNC_DTEST3		"dtest3"
> -- 
> 2.30.1
>
diff mbox series

Patch

diff --git a/include/dt-bindings/pinctrl/qcom,pmic-mpp.h b/include/dt-bindings/pinctrl/qcom,pmic-mpp.h
index 32e66ee7e830..3cdca7ee1b3f 100644
--- a/include/dt-bindings/pinctrl/qcom,pmic-mpp.h
+++ b/include/dt-bindings/pinctrl/qcom,pmic-mpp.h
@@ -98,6 +98,9 @@ 
 /* To be used with "function" */
 #define PMIC_MPP_FUNC_NORMAL		"normal"
 #define PMIC_MPP_FUNC_PAIRED		"paired"
+#define PMIC_MPP_FUNC_DIGITAL		"digital"
+#define PMIC_MPP_FUNC_ANALOG		"analog"
+#define PMIC_MPP_FUNC_SINK		"sink"
 #define PMIC_MPP_FUNC_DTEST1		"dtest1"
 #define PMIC_MPP_FUNC_DTEST2		"dtest2"
 #define PMIC_MPP_FUNC_DTEST3		"dtest3"