| Message ID | 20210803041443.55452-40-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Unaligned access for user-only | expand |
On 8/3/21 6:14 AM, Richard Henderson wrote: > The helper_*_mmu functions were the only thing available > when this code was written. This could have been adjusted > when we added cpu_*_mmuidx_ra, but now we can most easily > use the newest set of interfaces. > > Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/sparc/ldst_helper.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
On 03/08/2021 05:14, Richard Henderson wrote: > The helper_*_mmu functions were the only thing available > when this code was written. This could have been adjusted > when we added cpu_*_mmuidx_ra, but now we can most easily > use the newest set of interfaces. > > Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/sparc/ldst_helper.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c > index 299fc386ea..a3e1cf9b6e 100644 > --- a/target/sparc/ldst_helper.c > +++ b/target/sparc/ldst_helper.c > @@ -1328,27 +1328,27 @@ uint64_t helper_ld_asi(CPUSPARCState *env, target_ulong addr, > oi = make_memop_idx(memop, idx); > switch (size) { > case 1: > - ret = helper_ret_ldub_mmu(env, addr, oi, GETPC()); > + ret = cpu_ldb_mmu(env, addr, oi, GETPC()); > break; > case 2: > if (asi & 8) { > - ret = helper_le_lduw_mmu(env, addr, oi, GETPC()); > + ret = cpu_ldw_le_mmu(env, addr, oi, GETPC()); > } else { > - ret = helper_be_lduw_mmu(env, addr, oi, GETPC()); > + ret = cpu_ldw_be_mmu(env, addr, oi, GETPC()); > } > break; > case 4: > if (asi & 8) { > - ret = helper_le_ldul_mmu(env, addr, oi, GETPC()); > + ret = cpu_ldl_le_mmu(env, addr, oi, GETPC()); > } else { > - ret = helper_be_ldul_mmu(env, addr, oi, GETPC()); > + ret = cpu_ldl_be_mmu(env, addr, oi, GETPC()); > } > break; > case 8: > if (asi & 8) { > - ret = helper_le_ldq_mmu(env, addr, oi, GETPC()); > + ret = cpu_ldq_le_mmu(env, addr, oi, GETPC()); > } else { > - ret = helper_be_ldq_mmu(env, addr, oi, GETPC()); > + ret = cpu_ldq_be_mmu(env, addr, oi, GETPC()); > } > break; > default: Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> ATB, Mark.
diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index 299fc386ea..a3e1cf9b6e 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -1328,27 +1328,27 @@ uint64_t helper_ld_asi(CPUSPARCState *env, target_ulong addr, oi = make_memop_idx(memop, idx); switch (size) { case 1: - ret = helper_ret_ldub_mmu(env, addr, oi, GETPC()); + ret = cpu_ldb_mmu(env, addr, oi, GETPC()); break; case 2: if (asi & 8) { - ret = helper_le_lduw_mmu(env, addr, oi, GETPC()); + ret = cpu_ldw_le_mmu(env, addr, oi, GETPC()); } else { - ret = helper_be_lduw_mmu(env, addr, oi, GETPC()); + ret = cpu_ldw_be_mmu(env, addr, oi, GETPC()); } break; case 4: if (asi & 8) { - ret = helper_le_ldul_mmu(env, addr, oi, GETPC()); + ret = cpu_ldl_le_mmu(env, addr, oi, GETPC()); } else { - ret = helper_be_ldul_mmu(env, addr, oi, GETPC()); + ret = cpu_ldl_be_mmu(env, addr, oi, GETPC()); } break; case 8: if (asi & 8) { - ret = helper_le_ldq_mmu(env, addr, oi, GETPC()); + ret = cpu_ldq_le_mmu(env, addr, oi, GETPC()); } else { - ret = helper_be_ldq_mmu(env, addr, oi, GETPC()); + ret = cpu_ldq_be_mmu(env, addr, oi, GETPC()); } break; default:
The helper_*_mmu functions were the only thing available when this code was written. This could have been adjusted when we added cpu_*_mmuidx_ra, but now we can most easily use the newest set of interfaces. Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/sparc/ldst_helper.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) -- 2.25.1