| Message ID | 20210625235532.19575-10-dipenp@nvidia.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Intro to Hardware timestamping engine | expand |
On Sat, Jun 26, 2021 at 1:48 AM Dipen Patel <dipenp@nvidia.com> wrote: > gpiolib-cdev is extended to support hardware clock type, this > patch reflects that fact. > > Signed-off-by: Dipen Patel <dipenp@nvidia.com> (...) > case 'w': > config.flags |= GPIO_V2_LINE_FLAG_EVENT_CLOCK_REALTIME; > break; > + case 't': > + config.flags |= GPIO_V2_LINE_FLAG_EVENT_CLOCK_HARDWARE; > + break; After the checking of the command line options we need a small sanity check so we don't try to enable both realtime and hardware clock at the same time, we will only be able to request one of them. Yours, Linus Walleij
On 6/27/21 4:36 AM, Linus Walleij wrote: > On Sat, Jun 26, 2021 at 1:48 AM Dipen Patel <dipenp@nvidia.com> wrote: > >> gpiolib-cdev is extended to support hardware clock type, this >> patch reflects that fact. >> >> Signed-off-by: Dipen Patel <dipenp@nvidia.com> > (...) >> case 'w': >> config.flags |= GPIO_V2_LINE_FLAG_EVENT_CLOCK_REALTIME; >> break; >> + case 't': >> + config.flags |= GPIO_V2_LINE_FLAG_EVENT_CLOCK_HARDWARE; >> + break; > After the checking of the command line options we need a small sanity > check so we don't try to enable both realtime and hardware clock > at the same time, we will only be able to request one of them. This will any way fail at gpiolib-cdev layer. Do we want to add it here as well? > > Yours, > Linus Walleij
On Thu, Jul 29, 2021 at 08:17:22PM -0700, Dipen Patel wrote: > > On 6/27/21 4:36 AM, Linus Walleij wrote: > > On Sat, Jun 26, 2021 at 1:48 AM Dipen Patel <dipenp@nvidia.com> wrote: > > > >> gpiolib-cdev is extended to support hardware clock type, this > >> patch reflects that fact. > >> > >> Signed-off-by: Dipen Patel <dipenp@nvidia.com> > > (...) > >> case 'w': > >> config.flags |= GPIO_V2_LINE_FLAG_EVENT_CLOCK_REALTIME; > >> break; > >> + case 't': > >> + config.flags |= GPIO_V2_LINE_FLAG_EVENT_CLOCK_HARDWARE; > >> + break; > > After the checking of the command line options we need a small sanity > > check so we don't try to enable both realtime and hardware clock > > at the same time, we will only be able to request one of them. > > This will any way fail at gpiolib-cdev layer. Do we want to add it here > > as well? > I can't speak for Linus, but I'm fine with it as is as it allows the tool to be used to exercise the sanity check in the kernel. Cheers, Kent.
On Sat, Jul 31, 2021 at 8:16 AM Kent Gibson <warthog618@gmail.com> wrote: > On Thu, Jul 29, 2021 at 08:17:22PM -0700, Dipen Patel wrote: > > > > On 6/27/21 4:36 AM, Linus Walleij wrote: > > > On Sat, Jun 26, 2021 at 1:48 AM Dipen Patel <dipenp@nvidia.com> wrote: > > > > > >> gpiolib-cdev is extended to support hardware clock type, this > > >> patch reflects that fact. > > >> > > >> Signed-off-by: Dipen Patel <dipenp@nvidia.com> > > > (...) > > >> case 'w': > > >> config.flags |= GPIO_V2_LINE_FLAG_EVENT_CLOCK_REALTIME; > > >> break; > > >> + case 't': > > >> + config.flags |= GPIO_V2_LINE_FLAG_EVENT_CLOCK_HARDWARE; > > >> + break; > > > After the checking of the command line options we need a small sanity > > > check so we don't try to enable both realtime and hardware clock > > > at the same time, we will only be able to request one of them. > > > > This will any way fail at gpiolib-cdev layer. Do we want to add it here > > > > as well? > > > > I can't speak for Linus, but I'm fine with it as is as it allows the tool > to be used to exercise the sanity check in the kernel. Fair enough, that sounds useful. Go ahead with this as-is. Yours, Linus Walleij
diff --git a/tools/gpio/gpio-event-mon.c b/tools/gpio/gpio-event-mon.c index a2b233fdb572..bed52333698d 100644 --- a/tools/gpio/gpio-event-mon.c +++ b/tools/gpio/gpio-event-mon.c @@ -149,6 +149,7 @@ void print_usage(void) " -r Listen for rising edges\n" " -f Listen for falling edges\n" " -w Report the wall-clock time for events\n" + " -t Report the hardware timestamp for events\n" " -b <n> Debounce the line with period n microseconds\n" " [-c <n>] Do <n> loops (optional, infinite loop if not stated)\n" " -? This helptext\n" @@ -174,7 +175,7 @@ int main(int argc, char **argv) memset(&config, 0, sizeof(config)); config.flags = GPIO_V2_LINE_FLAG_INPUT; - while ((c = getopt(argc, argv, "c:n:o:b:dsrfw?")) != -1) { + while ((c = getopt(argc, argv, "c:n:o:b:dsrfwt?")) != -1) { switch (c) { case 'c': loops = strtoul(optarg, NULL, 10); @@ -208,6 +209,9 @@ int main(int argc, char **argv) case 'w': config.flags |= GPIO_V2_LINE_FLAG_EVENT_CLOCK_REALTIME; break; + case 't': + config.flags |= GPIO_V2_LINE_FLAG_EVENT_CLOCK_HARDWARE; + break; case '?': print_usage(); return -1;
gpiolib-cdev is extended to support hardware clock type, this patch reflects that fact. Signed-off-by: Dipen Patel <dipenp@nvidia.com> --- tools/gpio/gpio-event-mon.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)