mbox series

[0/2] iio: ti-dac5571: Add TI DAC081C081 support

Message ID 20210723183114.26017-1-laurent.pinchart@ideasonboard.com
Headers show
Series iio: ti-dac5571: Add TI DAC081C081 support | expand

Message

Laurent Pinchart July 23, 2021, 6:31 p.m. UTC 
Hello,

This small patch series adds support for the TI DAC081C081 in the
ti-dac5571 IIO driver. Patch 1/2 addresses the DT bindings, and patch
2/2 the driver.

I've expanded the CC list to the I2C mailing list and Wolfram because I
think the second patch may not be the best option. Instead of addressing
this issue in all drivers, it wonder if it wouldn't be better for the
I2C subsystem to handle this internally. One option would be to extend
i2c_match_id to walk through the compatible values in case of an
OF-based match, but I'm worried this could introduce regressions.
Feedback would be welcome.

The series could still be merged as-is in the meantime if desired.

Jose Cazarin (1):
  iio: dac: dac5571: Fix chip id detection for OF devices

Laurent Pinchart (1):
  dt-bindings: iio: dac: ti,dac5571: Add TI DAC081C081 support

 .../bindings/iio/dac/ti,dac5571.yaml          | 24 ++++++++++-------
 drivers/iio/dac/ti-dac5571.c                  | 27 ++++++++++++-------
 2 files changed, 31 insertions(+), 20 deletions(-)

Comments

Rob Herring (Arm) July 29, 2021, 9:26 p.m. UTC | #1 
On Fri, 23 Jul 2021 21:31:13 +0300, Laurent Pinchart wrote:
> The TI DAC081C081 is compatible with the TI DAC5571 from a software
> point of view. Add a device-specific compatible string value with a
> fallback to "ti,dac5571".
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  .../bindings/iio/dac/ti,dac5571.yaml          | 24 +++++++++++--------
>  1 file changed, 14 insertions(+), 10 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>