diff mbox series

[1/2] dt-bindings: panel: Add Samsung S6E3FA2 panel

Message ID 20210725140339.2465677-1-alexeymin@postmarketos.org
State New
Headers show
Series [1/2] dt-bindings: panel: Add Samsung S6E3FA2 panel | expand

Commit Message

Alexey Minnekhanov July 25, 2021, 2:03 p.m. UTC
The Samsung S6E3FA2 AMOLED cmd LCD panel is used on Samsung Galaxy
S5 (klte) phone.

Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
---
 .../display/panel/samsung,s6e3fa2.yaml        | 63 +++++++++++++++++++
 1 file changed, 63 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e3fa2.yaml

Comments

Linus Walleij July 26, 2021, 7:51 a.m. UTC | #1
On Sun, Jul 25, 2021 at 4:04 PM Alexey Minnekhanov
<alexeymin@postmarketos.org> wrote:

> The Samsung S6E3FA2 AMOLED cmd LCD panel is used on Samsung Galaxy
> S5 (klte) phone.
>
> Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>

Grr gmail put this in my spam folder, sorry for confused mails.

With Sam's comments addressed:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Rob Herring (Arm) July 29, 2021, 10:30 p.m. UTC | #2
On Mon, Jul 26, 2021 at 09:51:40AM +0200, Linus Walleij wrote:
> On Sun, Jul 25, 2021 at 4:04 PM Alexey Minnekhanov
> <alexeymin@postmarketos.org> wrote:
> 
> > The Samsung S6E3FA2 AMOLED cmd LCD panel is used on Samsung Galaxy
> > S5 (klte) phone.
> >
> > Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
> 
> Grr gmail put this in my spam folder, sorry for confused mails.
> 
> With Sam's comments addressed:

What comments? Sam's mails seem to have problems getting to the lists.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e3fa2.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e3fa2.yaml
new file mode 100644
index 000000000000..d5628ae81141
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e3fa2.yaml
@@ -0,0 +1,63 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/samsung,s6e3fa2.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung s6e3fa2 AMOLED CMD LCD DSI panel
+
+maintainers:
+  - Alexey Minnekhanov <alexeymin@postmarketos.org>
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: samsung,s6e3fa2
+
+  reg: true
+  reset-gpios: true
+  port: true
+
+  iovdd-supply:
+    description: IOVDD regulator
+
+  vddr-supply:
+    description: VDDR regulator
+
+required:
+  - compatible
+  - reset-gpios
+  - iovdd-supply
+  - vddr-supply
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    /* from Samsung Galaxy S5 klte */
+    #include <dt-bindings/gpio/gpio.h>
+
+    dsi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        panel@0 {
+            compatible = "samsung,s6e3fa2";
+            reg = <0>;
+
+            reset-gpios = <&pma8084_gpios 17 GPIO_ACTIVE_LOW>;
+
+            iovdd-supply = <&pma8084_lvs4>;
+            vddr-supply = <&vreg_panel>;
+
+            port {
+                panel_in: endpoint {
+                    remote-endpoint = <&dsi0_out>;
+                };
+            };
+        };
+    };
+
+...