| Message ID | 20210726182850.14328-1-prabhakar.mahadev-lad.rj@bp.renesas.com |
|---|---|
| Headers | show |
| Series | Renesas RZ/G2L ADC driver support | expand |
On Mon, 26 Jul 2021 19:28:48 +0100, Lad Prabhakar wrote: > Add binding documentation for Renesas RZ/G2L A/D converter block. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > .../bindings/iio/adc/renesas,rzg2l-adc.yaml | 134 ++++++++++++++++++ > 1 file changed, 134 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.example.dts:26.28-29 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:380: Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.example.dt.yaml] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1418: dt_binding_check] Error 2 \ndoc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1510163 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Hi Rob, On Mon, Jul 26, 2021 at 10:42 PM Rob Herring <robh@kernel.org> wrote: > > On Mon, 26 Jul 2021 19:28:48 +0100, Lad Prabhakar wrote: > > Add binding documentation for Renesas RZ/G2L A/D converter block. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > .../bindings/iio/adc/renesas,rzg2l-adc.yaml | 134 ++++++++++++++++++ > > 1 file changed, 134 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Error: Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.example.dts:26.28-29 syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:380: Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.example.dt.yaml] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:1418: dt_binding_check] Error 2 > \ndoc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/1510163 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > The base patch series required for this path is v5.14-rc2. (I had mentioned it in the cover letter, maybe I should have added a note here too) Sorry for the inconvenience. Cheers, Prabhakar > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. >
On Mon, Jul 26, 2021 at 12:31 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > Add binding documentation for Renesas RZ/G2L A/D converter block. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > .../bindings/iio/adc/renesas,rzg2l-adc.yaml | 134 ++++++++++++++++++ > 1 file changed, 134 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml Reviewed-by: Rob Herring <robh@kernel.org>
Hi All, This patch series adds ADC support for Renesas RZ/G2L family. Patches apply on top of v5.14-rc2. Cheers, Prabhakar Changes for v3 (as requested by Jonathan): * Made use of FIELD_PREP() * Renamed _CLEAR to _MASK and inverted inline as required * Moved |= pair's on same lines * Made use of sysfs_emit() while reading the labels * Used for_each_bit_set() in rzg2l_adc_isr() * Renamed rzg2l_adc_parse_of() -> rzg2l_adc_parse_properties() * Used devm_add_action_or_reset() for asserting the reset signals and disabling pm_runtime and eventually removing remove() callback * Added comments in isr handler for channel select interrupt * Moved enabling/disabling of pclk during hw init in rzg2l_adc_hw_init() * Dropped clock patch 3/4 (https://lore.kernel.org/patchwork/patch/1462152/) from previous series as its queued up in renesas-clk-for-v5.15 Changes for v2: * Update binding doc, dropped gpios/renesas-rzg2l,adc-trigger-mode properties included channel property to represent each wired channel. * Fixed review comments pointed by Alexandru, implemented pm runtime support, dropped mlock usage * Fixed review comments pointed by Jonathan, renamed the macros, simplified the code. * Included clock and DT patches v1: https://patchwork.kernel.org/project/linux-renesas-soc/cover/ 20210629220328.13366-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ Lad Prabhakar (3): dt-bindings: iio: adc: Add binding documentation for Renesas RZ/G2L A/D converter iio: adc: Add driver for Renesas RZ/G2L A/D converter arm64: dts: renesas: r9a07g044: Add ADC node .../bindings/iio/adc/renesas,rzg2l-adc.yaml | 134 ++++ MAINTAINERS | 8 + arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 42 ++ drivers/iio/adc/Kconfig | 10 + drivers/iio/adc/Makefile | 1 + drivers/iio/adc/rzg2l_adc.c | 595 ++++++++++++++++++ 6 files changed, 790 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml create mode 100644 drivers/iio/adc/rzg2l_adc.c