Message ID | 20210719233248.557923-2-pierre-louis.bossart@linux.intel.com |
---|---|
State | Accepted |
Commit | caa15c8dcb00f9dfe9f304e6e0955c5b29cf2499 |
Headers | show |
Series | ASoC/soundwire: add quirks for Intel 'Bishop County' NUC M15 | expand |
On 19-07-21, 18:32, Pierre-Louis Bossart wrote: > The same quirk is used for LAPBC510 and LAPBC710 skews who use the > same audio design. > > These devices have the same BIOS issues inherited from the Intel > reference, add the same _ADR remap previously used on HP devices. This fails to apply on rc1, pls rebase or if there are any dependencies, do spell them out
On 7/22/21 9:02 AM, Vinod Koul wrote: > On 19-07-21, 18:32, Pierre-Louis Bossart wrote: >> The same quirk is used for LAPBC510 and LAPBC710 skews who use the >> same audio design. >> >> These devices have the same BIOS issues inherited from the Intel >> reference, add the same _ADR remap previously used on HP devices. > > This fails to apply on rc1, pls rebase or if there are any dependencies, > do spell them out it likely depends on [PATCH] soundwire: dmi-quirks: add ull suffix for SoundWire _ADR values which was sent by Bard when the merge window opened.
On 7/22/21 9:25 AM, Pierre-Louis Bossart wrote: > > > On 7/22/21 9:02 AM, Vinod Koul wrote: >> On 19-07-21, 18:32, Pierre-Louis Bossart wrote: >>> The same quirk is used for LAPBC510 and LAPBC710 skews who use the >>> same audio design. >>> >>> These devices have the same BIOS issues inherited from the Intel >>> reference, add the same _ADR remap previously used on HP devices. >> >> This fails to apply on rc1, pls rebase or if there are any dependencies, >> do spell them out > > it likely depends on > > [PATCH] soundwire: dmi-quirks: add ull suffix for SoundWire _ADR values > > which was sent by Bard when the merge window opened. And you've just applied that dependency, do you mind retrying Vinod?
On 22-07-21, 09:25, Pierre-Louis Bossart wrote: > > > On 7/22/21 9:02 AM, Vinod Koul wrote: > > On 19-07-21, 18:32, Pierre-Louis Bossart wrote: > >> The same quirk is used for LAPBC510 and LAPBC710 skews who use the > >> same audio design. > >> > >> These devices have the same BIOS issues inherited from the Intel > >> reference, add the same _ADR remap previously used on HP devices. > > > > This fails to apply on rc1, pls rebase or if there are any dependencies, > > do spell them out > > it likely depends on > > [PATCH] soundwire: dmi-quirks: add ull suffix for SoundWire _ADR values As I said above, if there is a dependency, pls spell it out! > which was sent by Bard when the merge window opened.
On 22-07-21, 09:29, Pierre-Louis Bossart wrote: > > > On 7/22/21 9:25 AM, Pierre-Louis Bossart wrote: > > > > > > On 7/22/21 9:02 AM, Vinod Koul wrote: > >> On 19-07-21, 18:32, Pierre-Louis Bossart wrote: > >>> The same quirk is used for LAPBC510 and LAPBC710 skews who use the > >>> same audio design. > >>> > >>> These devices have the same BIOS issues inherited from the Intel > >>> reference, add the same _ADR remap previously used on HP devices. > >> > >> This fails to apply on rc1, pls rebase or if there are any dependencies, > >> do spell them out > > > > it likely depends on > > > > [PATCH] soundwire: dmi-quirks: add ull suffix for SoundWire _ADR values > > > > which was sent by Bard when the merge window opened. > > And you've just applied that dependency, do you mind retrying Vinod? Yes it applies now...
diff --git a/drivers/soundwire/dmi-quirks.c b/drivers/soundwire/dmi-quirks.c index 1ac16687e315..0ca2a3e3a02e 100644 --- a/drivers/soundwire/dmi-quirks.c +++ b/drivers/soundwire/dmi-quirks.c @@ -16,11 +16,11 @@ struct adr_remap { }; /* - * HP Spectre 360 Convertible devices do not expose the correct _ADR - * in the DSDT. + * Some TigerLake devices based on an initial Intel BIOS do not expose + * the correct _ADR in the DSDT. * Remap the bad _ADR values to the ones reported by hardware */ -static const struct adr_remap hp_spectre_360[] = { +static const struct adr_remap intel_tgl_bios[] = { { 0x000010025D070100ull, 0x000020025D071100ull @@ -61,7 +61,15 @@ static const struct dmi_system_id adr_remap_quirk_table[] = { DMI_MATCH(DMI_SYS_VENDOR, "HP"), DMI_MATCH(DMI_PRODUCT_NAME, "HP Spectre x360 Convertible"), }, - .driver_data = (void *)hp_spectre_360, + .driver_data = (void *)intel_tgl_bios, + }, + { + /* quirk used for NUC15 'Bishop County' LAPBC510 and LAPBC710 skews */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Intel(R) Client Systems"), + DMI_MATCH(DMI_PRODUCT_NAME, "LAPBC"), + }, + .driver_data = (void *)intel_tgl_bios, }, { .matches = {