| Message ID | 20210722170827.GA4362@pc |
|---|---|
| State | Accepted |
| Commit | 089015d36127f2f620c7a1dca28449f676654850 |
| Headers | show |
| Series | [RESEND] crypto: atmel-aes: use swap() | expand |
On 7/22/21 8:08 PM, Salah Triki wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Use swap() instead of implementing it in order to make code more clean. > > Signed-off-by: Salah Triki <salah.triki@gmail.com> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com> > --- > drivers/crypto/atmel-aes.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c > index b1d286004295..60041022c4f5 100644 > --- a/drivers/crypto/atmel-aes.c > +++ b/drivers/crypto/atmel-aes.c > @@ -1819,12 +1819,8 @@ static int atmel_aes_xts_process_data(struct atmel_aes_dev *dd) > * the order of the ciphered tweak bytes need to be reversed before > * writing them into the ODATARx registers. > */ > - for (i = 0; i < AES_BLOCK_SIZE/2; ++i) { > - u8 tmp = tweak_bytes[AES_BLOCK_SIZE - 1 - i]; > - > - tweak_bytes[AES_BLOCK_SIZE - 1 - i] = tweak_bytes[i]; > - tweak_bytes[i] = tmp; > - } > + for (i = 0; i < AES_BLOCK_SIZE/2; ++i) > + swap(tweak_bytes[i], tweak_bytes[AES_BLOCK_SIZE - 1 - i]); > > /* Process the data. */ > atmel_aes_write_ctrl(dd, use_dma, NULL); > -- > 2.25.1 >
On 7/22/21 8:08 PM, Salah Triki wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Use swap() instead of implementing it in order to make code more clean. > > Signed-off-by: Salah Triki <salah.triki@gmail.com> > --- > drivers/crypto/atmel-aes.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c > index b1d286004295..60041022c4f5 100644 > --- a/drivers/crypto/atmel-aes.c > +++ b/drivers/crypto/atmel-aes.c > @@ -1819,12 +1819,8 @@ static int atmel_aes_xts_process_data(struct atmel_aes_dev *dd) > * the order of the ciphered tweak bytes need to be reversed before > * writing them into the ODATARx registers. > */ > - for (i = 0; i < AES_BLOCK_SIZE/2; ++i) { > - u8 tmp = tweak_bytes[AES_BLOCK_SIZE - 1 - i]; > - > - tweak_bytes[AES_BLOCK_SIZE - 1 - i] = tweak_bytes[i]; > - tweak_bytes[i] = tmp; > - } > + for (i = 0; i < AES_BLOCK_SIZE/2; ++i) There could have been spaces around that '/', but I see it was kept as it was before. It's fine either way. > + swap(tweak_bytes[i], tweak_bytes[AES_BLOCK_SIZE - 1 - i]); > > /* Process the data. */ > atmel_aes_write_ctrl(dd, use_dma, NULL); > -- > 2.25.1 >
On Thu, Jul 22, 2021 at 06:08:27PM +0100, Salah Triki wrote: > Use swap() instead of implementing it in order to make code more clean. > > Signed-off-by: Salah Triki <salah.triki@gmail.com> > --- > drivers/crypto/atmel-aes.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c index b1d286004295..60041022c4f5 100644 --- a/drivers/crypto/atmel-aes.c +++ b/drivers/crypto/atmel-aes.c @@ -1819,12 +1819,8 @@ static int atmel_aes_xts_process_data(struct atmel_aes_dev *dd) * the order of the ciphered tweak bytes need to be reversed before * writing them into the ODATARx registers. */ - for (i = 0; i < AES_BLOCK_SIZE/2; ++i) { - u8 tmp = tweak_bytes[AES_BLOCK_SIZE - 1 - i]; - - tweak_bytes[AES_BLOCK_SIZE - 1 - i] = tweak_bytes[i]; - tweak_bytes[i] = tmp; - } + for (i = 0; i < AES_BLOCK_SIZE/2; ++i) + swap(tweak_bytes[i], tweak_bytes[AES_BLOCK_SIZE - 1 - i]); /* Process the data. */ atmel_aes_write_ctrl(dd, use_dma, NULL);
Use swap() instead of implementing it in order to make code more clean. Signed-off-by: Salah Triki <salah.triki@gmail.com> --- drivers/crypto/atmel-aes.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)