| Message ID | 20210721215810.889975-2-jolsa@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | libbpf: Export bpf_program__attach_kprobe_opts function | expand |
On Wed, Jul 21, 2021 at 11:58:08PM +0200, Jiri Olsa wrote: > Adding missing free for func pointer in attach_kprobe function. > and of course.. Fixes: a2488b5f483f ("libbpf: Allow specification of "kprobe/function+offset"") jirka > Reported-by: Andrii Nakryiko <andrii@kernel.org> > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > --- > tools/lib/bpf/libbpf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > index 4c153c379989..d46c2dd37be2 100644 > --- a/tools/lib/bpf/libbpf.c > +++ b/tools/lib/bpf/libbpf.c > @@ -10431,6 +10431,7 @@ static struct bpf_link *attach_kprobe(const struct bpf_sec_def *sec, > return libbpf_err_ptr(err); > } > if (opts.retprobe && offset != 0) { > + free(func); > err = -EINVAL; > pr_warn("kretprobes do not support offset specification\n"); > return libbpf_err_ptr(err); > -- > 2.31.1 >
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c index 4c153c379989..d46c2dd37be2 100644 --- a/tools/lib/bpf/libbpf.c +++ b/tools/lib/bpf/libbpf.c @@ -10431,6 +10431,7 @@ static struct bpf_link *attach_kprobe(const struct bpf_sec_def *sec, return libbpf_err_ptr(err); } if (opts.retprobe && offset != 0) { + free(func); err = -EINVAL; pr_warn("kretprobes do not support offset specification\n"); return libbpf_err_ptr(err);
Adding missing free for func pointer in attach_kprobe function. Reported-by: Andrii Nakryiko <andrii@kernel.org> Signed-off-by: Jiri Olsa <jolsa@kernel.org> --- tools/lib/bpf/libbpf.c | 1 + 1 file changed, 1 insertion(+)