| Message ID | 20210719144947.891096868@linuxfoundation.org |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On Mon, 19 Jul 2021 at 21:42, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > From: Kishon Vijay Abraham I <kishon@ti.com> > > [ Upstream commit f2a7657ad7a821de9cc77d071a5587b243144cd5 ] > > Use external clock for all the SERDES used by PCIe controller. This will > make the same clock used by the local SERDES as well as the clock > provided to the PCIe connector. > > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > Reviewed-by: Aswath Govindraju <a-govindraju@ti.com> > Signed-off-by: Nishanth Menon <nm@ti.com> > Link: https://lore.kernel.org/r/20210603143427.28735-4-kishon@ti.com > Signed-off-by: Sasha Levin <sashal@kernel.org> > --- > .../dts/ti/k3-j721e-common-proc-board.dts | 40 +++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > index 7cd31ac67f88..56a92f59c3a1 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > @@ -9,6 +9,7 @@ > #include <dt-bindings/gpio/gpio.h> > #include <dt-bindings/input/input.h> > #include <dt-bindings/net/ti-dp83867.h> > +#include <dt-bindings/phy/phy-cadence.h> Following build errors noticed on arm64 architecture on 5.10 branch. make --silent --keep-going --jobs=8 O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- 'CC=sccache aarch64-linux-gnu-gcc' 'HOSTCC=sccache gcc' /builds/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:12:10: fatal error: dt-bindings/phy/phy-cadence.h: No such file or directory 12 | #include <dt-bindings/phy/phy-cadence.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[3]: *** [scripts/Makefile.lib:326: arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb] Error 1 make[3]: Target '__build' not remade because of errors. make[2]: *** [/builds/linux/scripts/Makefile.build:497: arch/arm64/boot/dts/ti] Error 2 make[2]: Target '__build' not remade because of errors. make[1]: *** [/builds/linux/Makefile:1358: dtbs] Error 2 Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> ref: https://builds.tuxbuild.com/1vXT3b334rT9K155TzUSkMWobkx/ https://builds.tuxbuild.com/1vXT3b334rT9K155TzUSkMWobkx/config Steps to reproduce: -------------------- # TuxMake is a command line tool and Python library that provides # portable and repeatable Linux kernel builds across a variety of # architectures, toolchains, kernel configurations, and make targets. # # TuxMake supports the concept of runtimes. # See https://docs.tuxmake.org/runtimes/, for that to work it requires # that you install podman or docker on your system. # # To install tuxmake on your system globally: # sudo pip3 install -U tuxmake # # See https://docs.tuxmake.org/ for complete documentation. tuxmake --runtime podman --target-arch arm64 --toolchain gcc-11 --kconfig defconfig --kconfig-add https://builds.tuxbuild.com/1vXT3b334rT9K155TzUSkMWobkx/config -- Linaro LKFT https://lkft.linaro.org
On Mon, 19 Jul 2021 at 22:01, Naresh Kamboju <naresh.kamboju@linaro.org> wrote: > > On Mon, 19 Jul 2021 at 21:42, Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > > > From: Kishon Vijay Abraham I <kishon@ti.com> > > > > [ Upstream commit f2a7657ad7a821de9cc77d071a5587b243144cd5 ] > > > > Use external clock for all the SERDES used by PCIe controller. This will > > make the same clock used by the local SERDES as well as the clock > > provided to the PCIe connector. > > > > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > > Reviewed-by: Aswath Govindraju <a-govindraju@ti.com> > > Signed-off-by: Nishanth Menon <nm@ti.com> > > Link: https://lore.kernel.org/r/20210603143427.28735-4-kishon@ti.com > > Signed-off-by: Sasha Levin <sashal@kernel.org> > > --- > > .../dts/ti/k3-j721e-common-proc-board.dts | 40 +++++++++++++++++++ > > 1 file changed, 40 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > > index 7cd31ac67f88..56a92f59c3a1 100644 > > --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > > +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > > @@ -9,6 +9,7 @@ > > #include <dt-bindings/gpio/gpio.h> > > #include <dt-bindings/input/input.h> > > #include <dt-bindings/net/ti-dp83867.h> > > +#include <dt-bindings/phy/phy-cadence.h> > > Following build errors noticed on arm64 architecture on 5.10 branch. also noticed on stable-rc 5.12. > make --silent --keep-going --jobs=8 > O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=arm64 > CROSS_COMPILE=aarch64-linux-gnu- 'CC=sccache aarch64-linux-gnu-gcc' > 'HOSTCC=sccache gcc' > /builds/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:12:10: > fatal error: dt-bindings/phy/phy-cadence.h: No such file or directory > 12 | #include <dt-bindings/phy/phy-cadence.h> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > compilation terminated. > make[3]: *** [scripts/Makefile.lib:326: > arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb] Error 1 > make[3]: Target '__build' not remade because of errors. > make[2]: *** [/builds/linux/scripts/Makefile.build:497: > arch/arm64/boot/dts/ti] Error 2 > make[2]: Target '__build' not remade because of errors. > make[1]: *** [/builds/linux/Makefile:1358: dtbs] Error 2 > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> > > > ref: > https://builds.tuxbuild.com/1vXT3b334rT9K155TzUSkMWobkx/ > https://builds.tuxbuild.com/1vXT3b334rT9K155TzUSkMWobkx/config > > Steps to reproduce: > -------------------- > # TuxMake is a command line tool and Python library that provides > # portable and repeatable Linux kernel builds across a variety of > # architectures, toolchains, kernel configurations, and make targets. > # > # TuxMake supports the concept of runtimes. > # See https://docs.tuxmake.org/runtimes/, for that to work it requires > # that you install podman or docker on your system. > # > # To install tuxmake on your system globally: > # sudo pip3 install -U tuxmake > # > # See https://docs.tuxmake.org/ for complete documentation. > > > tuxmake --runtime podman --target-arch arm64 --toolchain gcc-11 > --kconfig defconfig --kconfig-add > https://builds.tuxbuild.com/1vXT3b334rT9K155TzUSkMWobkx/config > > -- > Linaro LKFT > https://lkft.linaro.org
On 13:57-20210719, Sasha Levin wrote: > On Mon, Jul 19, 2021 at 10:59:14PM +0530, Naresh Kamboju wrote: > > On Mon, 19 Jul 2021 at 22:01, Naresh Kamboju <naresh.kamboju@linaro.org> wrote: > > > > > > On Mon, 19 Jul 2021 at 21:42, Greg Kroah-Hartman > > > <gregkh@linuxfoundation.org> wrote: > > > > > > > > From: Kishon Vijay Abraham I <kishon@ti.com> > > > > > > > > [ Upstream commit f2a7657ad7a821de9cc77d071a5587b243144cd5 ] > > > > > > > > Use external clock for all the SERDES used by PCIe controller. This will > > > > make the same clock used by the local SERDES as well as the clock > > > > provided to the PCIe connector. > > > > > > > > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > > > > Reviewed-by: Aswath Govindraju <a-govindraju@ti.com> > > > > Signed-off-by: Nishanth Menon <nm@ti.com> > > > > Link: https://lore.kernel.org/r/20210603143427.28735-4-kishon@ti.com > > > > Signed-off-by: Sasha Levin <sashal@kernel.org> > > > > --- > > > > .../dts/ti/k3-j721e-common-proc-board.dts | 40 +++++++++++++++++++ > > > > 1 file changed, 40 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > > > > index 7cd31ac67f88..56a92f59c3a1 100644 > > > > --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > > > > +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > > > > @@ -9,6 +9,7 @@ > > > > #include <dt-bindings/gpio/gpio.h> > > > > #include <dt-bindings/input/input.h> > > > > #include <dt-bindings/net/ti-dp83867.h> > > > > +#include <dt-bindings/phy/phy-cadence.h> > > > > > > Following build errors noticed on arm64 architecture on 5.10 branch. > > > > also noticed on stable-rc 5.12. > > Dropped from both, thanks! Sorry about that. Kishon: You might want to send the fixes separately to stable for fixup.
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts index 7cd31ac67f88..56a92f59c3a1 100644 --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts @@ -9,6 +9,7 @@ #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/input/input.h> #include <dt-bindings/net/ti-dp83867.h> +#include <dt-bindings/phy/phy-cadence.h> / { chosen { @@ -564,7 +565,40 @@ clock-frequency = <100000000>; }; +&wiz0_pll1_refclk { + assigned-clocks = <&wiz0_pll1_refclk>; + assigned-clock-parents = <&cmn_refclk1>; +}; + +&wiz0_refclk_dig { + assigned-clocks = <&wiz0_refclk_dig>; + assigned-clock-parents = <&cmn_refclk1>; +}; + +&wiz1_pll1_refclk { + assigned-clocks = <&wiz1_pll1_refclk>; + assigned-clock-parents = <&cmn_refclk1>; +}; + +&wiz1_refclk_dig { + assigned-clocks = <&wiz1_refclk_dig>; + assigned-clock-parents = <&cmn_refclk1>; +}; + +&wiz2_pll1_refclk { + assigned-clocks = <&wiz2_pll1_refclk>; + assigned-clock-parents = <&cmn_refclk1>; +}; + +&wiz2_refclk_dig { + assigned-clocks = <&wiz2_refclk_dig>; + assigned-clock-parents = <&cmn_refclk1>; +}; + &serdes0 { + assigned-clocks = <&serdes0 CDNS_SIERRA_PLL_CMNLC>; + assigned-clock-parents = <&wiz0_pll1_refclk>; + serdes0_pcie_link: link@0 { reg = <0>; cdns,num-lanes = <1>; @@ -575,6 +609,9 @@ }; &serdes1 { + assigned-clocks = <&serdes1 CDNS_SIERRA_PLL_CMNLC>; + assigned-clock-parents = <&wiz1_pll1_refclk>; + serdes1_pcie_link: link@0 { reg = <0>; cdns,num-lanes = <2>; @@ -585,6 +622,9 @@ }; &serdes2 { + assigned-clocks = <&serdes2 CDNS_SIERRA_PLL_CMNLC>; + assigned-clock-parents = <&wiz2_pll1_refclk>; + serdes2_pcie_link: link@0 { reg = <0>; cdns,num-lanes = <2>;