| Message ID | 20210704222659.882193-1-luke@ljones.dev |
|---|---|
| State | Accepted |
| Commit | 3fdcf7cdfc229346d028242e73562704ad644dd0 |
| Headers | show |
| Series | HID: asus: Remove check for same LED brightness on set | expand |
On Mon, 5 Jul 2021, Luke D. Jones wrote: > Remove the early return on LED brightness set so that any controller > application, daemon, or desktop may set the same brightness at any stage. > > This is required because many ASUS ROG keyboards will default to max > brightness on laptop resume if the LEDs were set to off before sleep. > > Signed-off-by: Luke D Jones <luke@ljones.dev> Applied, thanks. -- Jiri Kosina SUSE Labs
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 60606c11bdaf..19da81d2a910 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -486,9 +486,6 @@ static void asus_kbd_backlight_set(struct led_classdev *led_cdev, { struct asus_kbd_leds *led = container_of(led_cdev, struct asus_kbd_leds, cdev); - if (led->brightness == brightness) - return; - led->brightness = brightness; schedule_work(&led->work); }
Remove the early return on LED brightness set so that any controller application, daemon, or desktop may set the same brightness at any stage. This is required because many ASUS ROG keyboards will default to max brightness on laptop resume if the LEDs were set to off before sleep. Signed-off-by: Luke D Jones <luke@ljones.dev> --- drivers/hid/hid-asus.c | 3 --- 1 file changed, 3 deletions(-) -- 2.31.1