diff mbox series

[v1] drm/msm/disp/dpu1: add safe lut config in dpu driver

Message ID 1625827244-23274-1-git-send-email-kalyan_t@codeaurora.org
State Superseded
Headers show
Series [v1] drm/msm/disp/dpu1: add safe lut config in dpu driver | expand

Commit Message

Kalyan Thota July 9, 2021, 10:40 a.m. UTC
Add safe lut configuration for all the targets in dpu
driver as per QOS recommendation.

Issue reported on SC7280:

With wait-for-safe feature in smmu enabled, RT client
buffer levels are checked to be safe before smmu invalidation.
Since display was always set to unsafe it was delaying the
invalidaiton process thus impacting the performance on NRT clients
such as eMMC and NVMe.

Validated this change on SC7280, With this change eMMC performance
has improved significantly.

Signed-off-by: Kalyan Thota <kalyan_t@codeaurora.org>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Sai Prakash Ranjan July 12, 2021, 3:41 a.m. UTC | #1
On 2021-07-09 16:10, Kalyan Thota wrote:
> Add safe lut configuration for all the targets in dpu

> driver as per QOS recommendation.

> 

> Issue reported on SC7280:

> 

> With wait-for-safe feature in smmu enabled, RT client

> buffer levels are checked to be safe before smmu invalidation.

> Since display was always set to unsafe it was delaying the

> invalidaiton process thus impacting the performance on NRT clients

> such as eMMC and NVMe.

> 

> Validated this change on SC7280, With this change eMMC performance

> has improved significantly.

> 

> Signed-off-by: Kalyan Thota <kalyan_t@codeaurora.org>

> ---

>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 5 +++++

>  1 file changed, 5 insertions(+)

> 

> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c

> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c

> index d01c4c9..2e482cd 100644

> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c

> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c

> @@ -974,6 +974,7 @@ static const struct dpu_perf_cfg sdm845_perf_data = 

> {

>  	.amortizable_threshold = 25,

>  	.min_prefill_lines = 24,

>  	.danger_lut_tbl = {0xf, 0xffff, 0x0},

> +	.safe_lut_tbl = {0xfff0, 0xf000, 0xffff},

>  	.qos_lut_tbl = {

>  		{.nentry = ARRAY_SIZE(sdm845_qos_linear),

>  		.entries = sdm845_qos_linear

> @@ -1001,6 +1002,7 @@ static const struct dpu_perf_cfg sc7180_perf_data 

> = {

>  	.min_dram_ib = 1600000,

>  	.min_prefill_lines = 24,

>  	.danger_lut_tbl = {0xff, 0xffff, 0x0},

> +	.safe_lut_tbl = {0xfff0, 0xff00, 0xffff},

>  	.qos_lut_tbl = {

>  		{.nentry = ARRAY_SIZE(sc7180_qos_linear),

>  		.entries = sc7180_qos_linear

> @@ -1028,6 +1030,7 @@ static const struct dpu_perf_cfg sm8150_perf_data 

> = {

>  	.min_dram_ib = 800000,

>  	.min_prefill_lines = 24,

>  	.danger_lut_tbl = {0xf, 0xffff, 0x0},

> +	.safe_lut_tbl = {0xfff8, 0xf000, 0xffff},

>  	.qos_lut_tbl = {

>  		{.nentry = ARRAY_SIZE(sm8150_qos_linear),

>  		.entries = sm8150_qos_linear

> @@ -1056,6 +1059,7 @@ static const struct dpu_perf_cfg sm8250_perf_data 

> = {

>  	.min_dram_ib = 800000,

>  	.min_prefill_lines = 35,

>  	.danger_lut_tbl = {0xf, 0xffff, 0x0},

> +	.safe_lut_tbl = {0xfff0, 0xff00, 0xffff},

>  	.qos_lut_tbl = {

>  		{.nentry = ARRAY_SIZE(sc7180_qos_linear),

>  		.entries = sc7180_qos_linear

> @@ -1084,6 +1088,7 @@ static const struct dpu_perf_cfg sc7280_perf_data 

> = {

>  	.min_dram_ib = 1600000,

>  	.min_prefill_lines = 24,

>  	.danger_lut_tbl = {0xffff, 0xffff, 0x0},

> +	.safe_lut_tbl = {0xff00, 0xff00, 0xffff},

>  	.qos_lut_tbl = {

>  		{.nentry = ARRAY_SIZE(sc7180_qos_macrotile),

>  		.entries = sc7180_qos_macrotile


Tested-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> 

(sc7280, sc7180)

This will need fixes and stable tag and I think this should also fix the
wait-for-safe issue with sdm845 (ufs/usb speed slowdown with display 
active)
which we have in arm-smmu-qcom.

Thanks,
Sai

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation
diff mbox series

Patch

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
index d01c4c9..2e482cd 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
@@ -974,6 +974,7 @@  static const struct dpu_perf_cfg sdm845_perf_data = {
 	.amortizable_threshold = 25,
 	.min_prefill_lines = 24,
 	.danger_lut_tbl = {0xf, 0xffff, 0x0},
+	.safe_lut_tbl = {0xfff0, 0xf000, 0xffff},
 	.qos_lut_tbl = {
 		{.nentry = ARRAY_SIZE(sdm845_qos_linear),
 		.entries = sdm845_qos_linear
@@ -1001,6 +1002,7 @@  static const struct dpu_perf_cfg sc7180_perf_data = {
 	.min_dram_ib = 1600000,
 	.min_prefill_lines = 24,
 	.danger_lut_tbl = {0xff, 0xffff, 0x0},
+	.safe_lut_tbl = {0xfff0, 0xff00, 0xffff},
 	.qos_lut_tbl = {
 		{.nentry = ARRAY_SIZE(sc7180_qos_linear),
 		.entries = sc7180_qos_linear
@@ -1028,6 +1030,7 @@  static const struct dpu_perf_cfg sm8150_perf_data = {
 	.min_dram_ib = 800000,
 	.min_prefill_lines = 24,
 	.danger_lut_tbl = {0xf, 0xffff, 0x0},
+	.safe_lut_tbl = {0xfff8, 0xf000, 0xffff},
 	.qos_lut_tbl = {
 		{.nentry = ARRAY_SIZE(sm8150_qos_linear),
 		.entries = sm8150_qos_linear
@@ -1056,6 +1059,7 @@  static const struct dpu_perf_cfg sm8250_perf_data = {
 	.min_dram_ib = 800000,
 	.min_prefill_lines = 35,
 	.danger_lut_tbl = {0xf, 0xffff, 0x0},
+	.safe_lut_tbl = {0xfff0, 0xff00, 0xffff},
 	.qos_lut_tbl = {
 		{.nentry = ARRAY_SIZE(sc7180_qos_linear),
 		.entries = sc7180_qos_linear
@@ -1084,6 +1088,7 @@  static const struct dpu_perf_cfg sc7280_perf_data = {
 	.min_dram_ib = 1600000,
 	.min_prefill_lines = 24,
 	.danger_lut_tbl = {0xffff, 0xffff, 0x0},
+	.safe_lut_tbl = {0xff00, 0xff00, 0xffff},
 	.qos_lut_tbl = {
 		{.nentry = ARRAY_SIZE(sc7180_qos_macrotile),
 		.entries = sc7180_qos_macrotile