diff mbox series

[v2,32/39] contrib/plugins: enable -Wall for building plugins

Message ID 20210708190941.16980-33-alex.bennee@linaro.org
State Superseded
Headers show
Series testing and plugins pre-PR series | expand

Commit Message

Alex Bennée July 8, 2021, 7:09 p.m. UTC 
Lets spot the obvious errors.

Reviewed-by: Thomas Huth <thuth@redhat.com>

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>


---
v2
  - also $(filter -W%, $(QEMU_CFLAGS)) from the main build
---
 contrib/plugins/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1

Comments

Richard Henderson July 8, 2021, 8:44 p.m. UTC | #1 
On 7/8/21 12:09 PM, Alex Bennée wrote:
> Lets spot the obvious errors.

> 

> Reviewed-by: Thomas Huth<thuth@redhat.com>

> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>

> 

> ---

> v2

>    - also $(filter -W%, $(QEMU_CFLAGS)) from the main build

> ---

>   contrib/plugins/Makefile | 2 +-

>   1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~
diff mbox series

Patch

diff --git a/contrib/plugins/Makefile b/contrib/plugins/Makefile
index b9d7935e5e..3431bc1ce9 100644
--- a/contrib/plugins/Makefile
+++ b/contrib/plugins/Makefile
@@ -24,7 +24,7 @@  SONAMES := $(addsuffix .so,$(addprefix lib,$(NAMES)))
 # The main QEMU uses Glib extensively so it's perfectly fine to use it
 # in plugins (which many example do).
 CFLAGS = $(GLIB_CFLAGS)
-CFLAGS += -fPIC
+CFLAGS += -fPIC -Wall $(filter -W%, $(QEMU_CFLAGS))
 CFLAGS += $(if $(findstring no-psabi,$(QEMU_CFLAGS)),-Wpsabi)
 CFLAGS += -I$(SRC_PATH)/include/qemu